Re: [Wireshark-dev] Custom item not related to the packet

2021-05-26 Thread Antonello Tartamo
pt contains 16 bytes I have filled up. I'm telling proto_tree_add_item to read these bytes from offset 0 with length 16. The field is properly shown (correct bytes) in the Packet Details tree but when I select it in the Packet Bytes view the bytes selected are not the same shown in the Packet Detai

Re: [Wireshark-dev] Windows HTML Help

2021-05-26 Thread chuck c
Just like the racks of backup tapes that never get tested, I've just found that the CHM files my dev system has been dutifully building are empty. Once I get that resolved, I'll try upping the IE level in https://gitlab.com/wireshark/wireshark/-/blob/master/docbook/custom_layer_chm.xsl . Another o

Re: [Wireshark-dev] Windows HTML Help

2021-05-26 Thread Gerald Combs
I think the only advantage that HTML Help offers at this point is the ability to search for keywords. It otherwise adds a build requirement which results in shipping a different help format on Windows, and the HTML Help Viewer seems to behave worse as time goes on. I'd be OK with switching to p

Re: [Wireshark-dev] Windows HTML Help

2021-05-26 Thread Graham Bloice
Personally I prefer help to be local and not require internet access, and I despise those local help abominations that spew hundreds of html files into the filesystem. Not sure what's up with the links, maybe we need to make them pass off to the system default browser rather than trying to render

[Wireshark-dev] Windows HTML Help

2021-05-26 Thread chuck c
https://www.wireshark.org/lists/wireshark-dev/200701/msg00396.html "Pressing the help button will: - on Win32 only: if available, open the Windows Help viewer with locally installed user-guide.chm file - and if that fails ... - on all systems: start a web browser and open the corresponding wiresha

Re: [Wireshark-dev] Custom item not related to the packet

2021-05-26 Thread Roland Knall
You misunderstood. pt must contain the bytes you want to be inside the subset. It seems, that you collect different bytes for this array as you select for your hf_item selection which is then highlighted in the packet-view kind regard Roland Am Mi., 26. Mai 2021 um 14:39 Uhr schrieb Antonello Tar

Re: [Wireshark-dev] Custom item not related to the packet

2021-05-26 Thread Antonello Tartamo
Hello pt is an array (uint8_t pt[16];). pt is an array generated after processing a part of the packet. As I've created a new tvb the offset is 0 and the length is 16. Hope I've answered your questions. Il giorno mer 26 mag 2021 alle ore 14:32 Roland Knall ha scritto: > The data displayed in

Re: [Wireshark-dev] Custom item not related to the packet

2021-05-26 Thread Roland Knall
The data displayed in the subitem is the one from pt, your data variable which you used to create the new tvb. The hf_item seems to point to a different data structure. How is pt being generated? Are you using the same length and start offset as for the hf item? regards Roland Am Mi., 26. Mai 202