Re: [Wireshark-dev] USB Attached SCSI dissector

2021-10-25 Thread Tomasz Moń
On Mon, Oct 25, 2021 at 9:08 PM Guy Harris wrote: > On Oct 25, 2021, at 12:03 PM, Tomasz Moń wrote: > > The heuristic should not be the main USB traffic detection method > > IMHO. The main thing is that people don't necessarily understand that > > capturing full enumeration sequence (aka starting

Re: [Wireshark-dev] USB Attached SCSI dissector

2021-10-25 Thread Tomasz Moń
On Sat, Oct 23, 2021 at 3:07 AM Aidan MacDonald via Wireshark-dev wrote: > I have two questions. First, is it fine to open a merge request early on and > keep updating it as I add functionality? Or is it preferred to wait until > it's more complete? If you have some major questions, then in my

Re: [Wireshark-dev] USB Attached SCSI dissector

2021-10-25 Thread Guy Harris
On Oct 25, 2021, at 12:03 PM, Tomasz Moń wrote: > The heuristic should not be the main USB traffic detection method > IMHO. The main thing is that people don't necessarily understand that > capturing full enumeration sequence (aka starting capture before > plugging in the device) will give you mu

Re: [Wireshark-dev] USB Attached SCSI dissector

2021-10-25 Thread Tomasz Moń
On Mon, Oct 25, 2021 at 4:57 PM Kennedy, Smith (Wireless & IPP Standards) via Wireshark-dev wrote: > The "Universal Serial Bus Common Class Specification" > (https://usb.org/sites/default/files/usbccs10.pdf) discusses matching > "drivers" to devices based on the device's or interface's class, su

Re: [Wireshark-dev] Non-core cherry pick

2021-10-25 Thread chuck c
Long time listener. First time cherry-picker. I was just hoping to get the tick marks around tshark -G folders in the 3.6 release notes. Otherwise no need for me to cherry pick. If the MRs I submit need to be in releases it's done by the person doing the actual merge. There is a News.txt in .gitig

Re: [Wireshark-dev] USB Attached SCSI dissector

2021-10-25 Thread Kennedy, Smith (Wireless & IPP Standards) via Wireshark-dev
On Oct 22, 2021, at 10:36 PM, Guy Harris mailto:ghar...@sonic.net>> wrote: On Oct 22, 2021, at 6:06 PM, Aidan MacDonald via Wireshark-dev mailto:wireshark-dev@wireshark.org>> wrote: > Second, the hooks provided by the generic USB dissector seemingly aren't a > good fit. Basically, it seems t