Re: [Wireshark-dev] My latest Merge Request pipeline failed in a weird way in the Windows build

On 12/14/21 7:22 PM, Richard Sharpe wrote: Hi folks, This pipeline failed: https://gitlab.com/wireshark/wireshark/-/pipelines/429686197 The failure is: $ cmake -G "Visual Studio 16 2019" -A x64 -DENABLE_LTO=off .. 57-- Selecting Windows SDK version to target Windows

[Wireshark-dev] My latest Merge Request pipeline failed in a weird way in the Windows build

Hi folks, This pipeline failed: https://gitlab.com/wireshark/wireshark/-/pipelines/429686197 The failure is: $ cmake -G "Visual Studio 16 2019" -A x64 -DENABLE_LTO=off .. 57-- Selecting Windows SDK version to target Windows 10.0.17763. 58-- The C compiler identification

Re: [Wireshark-dev] Exporting FTP objects

On Tue, Dec 14, 2021 at 1:36 PM Richard Sharpe wrote: > On Tue, Dec 14, 2021 at 10:18 AM Moshe Kaplan > wrote: > > > > I considered using such a data structure, but the challenge there is > that there's no guarantee of a 'file transfer complete' that could be used > to trigger reassembly and

Re: [Wireshark-dev] Errors building 3.7 plugins.

On Dec 14, 2021, at 5:49 AM, João Valverde wrote: > On 14/12/21 13:39, Gisle Vanem wrote: >> João Valverde wrote: >> >>> you can (and probably should) include "config.h", just like other Wireshark >>> bundled plugins do. >> >> Why does this project not use '-FI./config.h'? > > The header

Re: [Wireshark-dev] Exporting FTP objects

On Tue, Dec 14, 2021 at 10:18 AM Moshe Kaplan wrote: > > I considered using such a data structure, but the challenge there is that > there's no guarantee of a 'file transfer complete' that could be used to > trigger reassembly and adding to the export objects list. AFAIK, it's also > not

Re: [Wireshark-dev] Exporting FTP objects

I considered using such a data structure, but the challenge there is that there's no guarantee of a 'file transfer complete' that could be used to trigger reassembly and adding to the export objects list. AFAIK, it's also not possible to have a function to run after all packets were dissected to

Re: [Wireshark-dev] Exporting FTP objects

On Tue, Dec 14, 2021 at 9:34 AM Moshe Kaplan wrote: > > Good afternoon, > > I've been working on MR 1611 for exporting FTP objects. One of the > complexities is that because the transmitted FTP files are spread across > multiple "packets", they need to be reassembled by the export objects 'tap'

[Wireshark-dev] Exporting FTP objects

Good afternoon, I've been working on MR 1611 for exporting FTP objects. One of the complexities is that because the transmitted FTP files are spread across multiple "packets", they need to be reassembled by the export objects 'tap'

Re: [Wireshark-dev] Errors building 3.7 plugins.

On 14/12/21 13:39, Gisle Vanem wrote: João Valverde wrote: you can (and probably should) include "config.h", just like other Wireshark bundled plugins do. Why does this project not use '-FI./config.h'? The header works fine, the consideration is that external plugins can only use the

Re: [Wireshark-dev] Errors building 3.7 plugins.

João Valverde wrote: you can (and probably should) include "config.h", just like other Wireshark bundled plugins do. Why does this project not use '-FI./config.h'? -- --gv ___ Sent via:Wireshark-dev mailing list

Re: [Wireshark-dev] Errors building 3.7 plugins.

Glad to hear. This should be fixed in fb0e1a49076a3268a5e8c29c46c8516a91a6cefe. To amend something I said previously, since you are using Windows, and almost certainly building your plugins in-tree (internal plugins), you can (and probably should) include "config.h", just like other Wireshark

Re: [Wireshark-dev] Errors building 3.7 plugins.

João, Thank you for the reply. My plugins are now working again! So, to sum up, to get external plugins working again in 3.7 from 3.4: API change in proto_tree_add_uint_bits_format_value(…) and #define ssize_t long int ahead of the #include in some plugins. Thanks, Peter M. Sent from my