[Wireshark-dev] Calling payload dissector from AMQP dissector

2022-10-18 Thread Ragnar Paulson (he/him) via Wireshark-dev
Hello, I few weeks ago I mentioned we were working on adding the ability to call other dissectors from the AMQP dissector. We have this work complete and are ready to create a PR. The basic model is the same as in the MQTT dissector. There is a new preferences entry, "Protocol Preferences

Re: [Wireshark-dev] How do I indicate that a commit or MR fixes an issue?

2022-10-18 Thread chuck c
Should be ok if it's !8558 https://docs.gitlab.com/ee/user/project/issues/managing_issues.html#closing-issues-automatically On Tue, Oct 18, 2022 at 12:59 PM Richard Sharpe wrote: > On Tue, Oct 18, 2022 at 10:54 AM chuck c wrote: > > > > > https://wiki.wireshark.org/Development/SubmittingPatc

Re: [Wireshark-dev] How do I indicate that a commit or MR fixes an issue?

2022-10-18 Thread Richard Sharpe
On Tue, Oct 18, 2022 at 10:54 AM chuck c wrote: > > https://wiki.wireshark.org/Development/SubmittingPatches#writing-a-good-commit-message > > As mentioned above, you can use "#" to reference issues. > "Closes #1234" is special – it will close issue 1234 when the change is > merged, while other r

Re: [Wireshark-dev] How do I indicate that a commit or MR fixes an issue?

2022-10-18 Thread chuck c
https://wiki.wireshark.org/Development/SubmittingPatches#writing-a-good-commit-message As mentioned above, you can use "#" to reference issues. "Closes #1234" is special – it will close issue 1234 when the change is merged, while other references such as "see #4512" will simply link to the issue.

[Wireshark-dev] How do I indicate that a commit or MR fixes an issue?

2022-10-18 Thread Richard Sharpe
Hi folks. What do I put in a commit message to indicate that it fixes an issue? -- Regards, Richard Sharpe (何以解憂？唯有杜康。--曹操)(传说杜康是酒的发明者) ___ Sent via:Wireshark-dev mailing list Archives:https://www.wireshark.org/list

Re: [Wireshark-dev] Max size of a field seems to be 240 for a dissector

2022-10-18 Thread Gerald Combs
On 10/18/22 9:49 AM, Richard Sharpe wrote: On Tue, Oct 18, 2022 at 9:39 AM Pascal Quantin wrote: Hi Richard, Le mar. 18 oct. 2022 à 18:30, Richard Sharpe a écrit : Hi folks, How do I squeeze more than 240 chars into a string field? You can't currently. As seen in epan/proto.h, you hav

Re: [Wireshark-dev] Max size of a field seems to be 240 for a dissector

2022-10-18 Thread Richard Sharpe
On Tue, Oct 18, 2022 at 9:39 AM Pascal Quantin wrote: > > Hi Richard, > > Le mar. 18 oct. 2022 à 18:30, Richard Sharpe a > écrit : >> >> Hi folks, >> >> How do I squeeze more than 240 chars into a string field? > > You can't currently. As seen in epan/proto.h, you have the ITEM_LABEL_LENGTH >

Re: [Wireshark-dev] Max size of a field seems to be 240 for a dissector

2022-10-18 Thread Pascal Quantin
Hi Richard, Le mar. 18 oct. 2022 à 18:30, Richard Sharpe a écrit : > Hi folks, > > How do I squeeze more than 240 chars into a string field? > You can't currently. As seen in epan/proto.h, you have the ITEM_LABEL_LENGTH define set to 240 and that exists since ages. > I am trying to fix an is

Re: [Wireshark-dev] Max size of a field seems to be 240 for a dissector

2022-10-18 Thread chuck c
Allow user to edit ITEM_LABEL_LENGTH to modify the character limit in the packet detail pane https://gitlab.com/wireshark/wireshark/-/issues/14874 On Tue, Oct 18, 2022 at 11:30 AM Richard Sharpe wrote: > Hi folks, > > How do I squeeze more than 240 chars into a string field? > > I am trying to

[Wireshark-dev] Max size of a field seems to be 240 for a dissector

2022-10-18 Thread Richard Sharpe
Hi folks, How do I squeeze more than 240 chars into a string field? I am trying to fix an issue with the beamforming matrices for 802.11ax and 802.11be and maybe 802.11ac. When I try to assemble all of a single SCIDX, I get this: S [truncated]: SCIDX: -122, phi11:57,