Re: [Wireshark-dev] Push failed after amend (Change 27518)

2018-06-11 Thread Ahmad Fatoum
> On 11Jun 2018, at 09:28, david_agge...@hispeed.ch wrote: > > == > remote: Processing changes: refs: 1, done > To ssh://code.wireshark.org:29418/wireshark > ! [remote rejected] HEAD -> refs/publish/master/dicom-heuristic > (duplicate request) > error: failed to push some refs to >

Re: [Wireshark-dev] Embed SSL keylog file in pcap-ng

2018-05-05 Thread Ahmad Fatoum
> On 5May 2018, at 10:47, Guy Harris wrote: > > That doesn't require "some authority that allocates protocol identifiers", > because it doesn't require protocol identifiers; all that needs to be done is > to allocate pcapng block types to those protocols that require some

Re: [Wireshark-dev] Embed SSL keylog file in pcap-ng

2018-05-05 Thread Ahmad Fatoum
Hi, > On 5May 2018, at 09:31, Guy Harris wrote: > > "Support multiple protocols in a capture" in what sense? multiple protocols with a key block each, e.g. TLS and Tibia interleaved in the same capture file. > On 4May 2018, at 09:21, Paul Zander

Re: [Wireshark-dev] Embed SSL keylog file in pcap-ng

2018-05-04 Thread Ahmad Fatoum
> On 4May 2018, at 19:10, Guy Harris wrote: > > That might *also* be useful, but the advantage of blocks that *aren't* tied > to Wireshark is that *other* programs can use the data without having to > track Wireshark. I see, but to support multiple protocols in a capture,

Re: [Wireshark-dev] Embed SSL keylog file in pcap-ng

2018-05-04 Thread Ahmad Fatoum
> On 4May 2018, at 01:13, Ben Higgins wrote: > > What I'd like to do is instead create a new pcap-ng block type that we can > put SSL keylog file contents into verbatim. How about a generic "Wireshark dissector preferences" pcapng block with { pref.key => value } tuples?

Re: [Wireshark-dev] git question

2017-12-02 Thread Ahmad Fatoum
In future, better use branches, so you can trim them when they're no longer needed. You can do this now with: git branch my-change git reset --hard HEAD~3 After that you can git pull master and decide whether you want to git branch --delete my-change Alternatively, you can also git pull

Re: [Wireshark-dev] Newbie

2017-10-09 Thread Ahmad Fatoum
Hello Peter, You could start by implementing/extending a Wireshark dissector for a protocol you use in order to get accustomed to the API. For example, my first Wireshark-related project was writing a protocol dissector for a game I used to play. doc/README.developer and doc/README.dissector

Re: [Wireshark-dev] Intro & first patch

2017-10-09 Thread Ahmad Fatoum
Hello Brenton, Welcome! For the packet capture, please open a Bugzilla ticket at https://bugs.wireshark.org, preferably with the same title as your commit and attach your pcap files there. Afterwards reference the Bugzilla ticket from the commit message of your patch on Gerrit by adding Bug:

Re: [Wireshark-dev] Importing raw application protocol data with Wireshark

2017-09-14 Thread Ahmad Fatoum
There is "Import from Hexdump" in the File menu, which can prefix headers, create a pcap and open it in Wireshark. It's also usable from the command line with the text2pcap utility. I also had success with Net::PcapWriter from CPAN in the past. Regards, Ahmad > On 14Sep 2017, at 13:28, Jack

Re: [Wireshark-dev] checkapi prefs

2017-08-08 Thread Ahmad Fatoum
prefs_register_*_preference populates a variable with a user-supplied value. And having more than one preference populate the same variable is usually not what you want. But the actual definitions of the function do just that: They use the same variable name and similar types for the variable. I

[Wireshark-dev] Edit rights to the Wireshark Wiki

2017-06-02 Thread Ahmad Fatoum
Hello, Please add Wiki user AhmadFatoum to EditorGroup. I want to update Protocols/epl documentation with the newly accepted preferences. Thanks Ahmad signature.asc Description: Message signed with OpenPGP ___ Sent via:

Re: [Wireshark-dev] Specifying dissectors declaratively

2017-04-20 Thread Ahmad Fatoum
different commands, with multiple versions for each command depending on protocol version) > - Just use Kaitai syntax but rewrite the parser as a c-library to include > with wireshark I'll consider going this route. Thanks for your input. Regards, Ahmad > > > On Wed, Apr 19, 2017 at 11:

[Wireshark-dev] Specifying dissectors declaratively

2017-04-19 Thread Ahmad Fatoum
Hello everyone, I want to update a game protocol dissector I wrote, and would love to be able to rewrite all those game commands in a declarative manner. What I've found so far: • ASN.1: asn2wrs, part of Wireshark and supports packed encoding rules (PER), but I believe it's not possible to

Re: [Wireshark-dev] Debugging an assertion failure

2017-04-14 Thread Ahmad Fatoum
t of stdlib. > > Best regards…Paul > > From: wireshark-dev-boun...@wireshark.org > <mailto:wireshark-dev-boun...@wireshark.org> > [mailto:wireshark-dev-boun...@wireshark.org > <mailto:wireshark-dev-boun...@wireshark.org>] On Behalf Of Ahmad Fatoum > Sent: 14 Apri

Re: [Wireshark-dev] Debugging an assertion failure

2017-04-14 Thread Ahmad Fatoum
Hello Paul, You could always put a breakpoint on abort(). There is surely some way to configure VS2013 to catch it, but this might be the wrong place to ask about that. Best regards, Ahmad > On 14Apr 2017, at 12:41, Paul Offord wrote: > > Hi, > > I need some

Re: [Wireshark-dev] Adding libxml2 as optional Wireshark dependency

2017-04-05 Thread Ahmad Fatoum
> On 5 April 2017 at 15:30, Ahmad Fatoum <ah...@a3f.at> wrote: > >> I can't comment on the Windows binary distribution issue but Pascal's >> suggestion of using SUSE's sounds promising. I will attempt building on >> Windows and comment on the Gerrit issue later today. >

Re: [Wireshark-dev] Adding libxml2 as optional Wireshark dependency

2017-04-05 Thread Ahmad Fatoum
On 5 April 2017 at 14:11, Ahmad Fatoum <ah...@a3f.at> wrote: > >> Hello everyone, >> >> I was advised on Gerrit to post this issue here as to garner wider input. >> >> This concerns proposed Change-Id I13c0a2f408fb5c21bad7ab3d7971e >> 0fa8ed7d783 [1] int

[Wireshark-dev] Adding libxml2 as optional Wireshark dependency

2017-04-05 Thread Ahmad Fatoum
idea to have this as optional dependency as Glib's GMarkup may be inadequate or inconvenient for parsing actual XML. Looking forward to your feedback. Best regards, Ahmad Fatoum [1] https://code.wireshark.org/review/#/c/20912

Re: [Wireshark-dev] XML library for use in dissector

2017-01-30 Thread Ahmad Fatoum
Hello Peter, As OEMs can (and do) provide their own device profiles, restricting loading to compile-time would be too big a limitation. For now, I went the plugin route and edited the build files to include libxml2. Kind regards Ahmad Fatoum On Mon, Jan 30, 2017 at 1:00 PM, <wireshark-

[Wireshark-dev] XML library for use in dissector

2017-01-28 Thread Ahmad Fatoum
depends on lex(1), but I wouldn't want to reinvent the wheel and rather use some out-of-the-box parser. So what's the stance on dissectors pulling in dependencies like libxml? Any other suggestions? With kind regards Ahmad Fatoum ps: Out of curiosity, is there a particular reason e.g. PROFINET