Re: [Wireshark-dev] [Wireshark-commits] rev 23643: /trunk//trunk/epan/dissectors/: packet-tpncp.c /trunk/epan/:Makefile.am Makefile.nmake asm_utils.c asm_utils.hasm_utils_win32_x86.asm proto.c /trunk/

2007-11-28 Thread Didier
ldbot now. BTW g_tree_new_full is GTK2 only. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Startup speed up - remove dissectors?!

2007-11-22 Thread Didier
nder 1 seconds even on a slow box (a 7 years old 500 Mhz G4). So maybe lazy init these functions would be enough? Enforcing name there would be easy. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Startup speed up - assembler usage

2007-11-21 Thread Didier
28,459 3,6 586208 _g_tree_lookup (libglib-2.0-0.dll) Why did _g_tree_insert speed up from 1582,290 to 371,999? Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-20 Thread Didier
[UTF-8?]On Tue, 20 Nov 2007 11:42:12 +0100, Stig Bjørlykke wrote > 2007/11/20, Didier <[EMAIL PROTECTED]>: > > Can you share a small capture? > > http://wiki.wireshark.org/SampleCaptures?action=AttachFile&do=get&target=dmp-examples.pcap.gz > > Add port 2420

Re: [Wireshark-dev] Problems when changing a dissector preference

2007-11-19 Thread Didier
is called I don't see how flags.visited could be false. cf file.c rescan_packets() Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Optimization patches - GUI

2007-11-16 Thread Didier
side effect of fixing http://bugs.wireshark.org/bugzilla/show_bug.cgi?id=1876 Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] lenght

2007-11-14 Thread Didier
); offset +=len; or len +1, but you get the idea. >   > { &hf_data_nbyte, >    { "DATA",  "lon.datum", >    FT_BYTES, BASE_HEX, NULL, 0,  >    "DATA", HFILL } >   } > Didier ___

Re: [Wireshark-dev] Is there a good way of handling "per pdu" info ?

2007-11-13 Thread Didier
DU you should always get the same number - however > it is not unique to the session, only the tvb. To make it unique I > add the seq field of the tcpinfo structure. The structure pointer is > present in the pinfo->private_data for tcp dissectors, so I

Re: [Wireshark-dev] Small performance improvements to packet-http.c

2007-11-07 Thread Didier
t_method = "POST" conv_data->request_method ="POST" And you can precompute (headers[i].namelen - 1) BTW if you're in optimization mood you can play with http://wiki.wireshark.org/Development/Optimization I'm not sure it compiles for Window though. Didier __

Re: [Wireshark-dev] About a faster wireshark

2007-10-10 Thread Didier
On Wed, 10 Oct 2007 15:56:53 -0700, Guy Harris wrote > On Oct 7, 2007, at 5:04 PM, Didier wrote: > > > Is it ok if I upload the diff (~ 250 KB) in the wiki? > > From looking at the version you uploaded as an attachment to > > http://wiki.wireshark.org/Developm

Re: [Wireshark-dev] About a faster wireshark

2007-10-10 Thread Didier
On Tue, 09 Oct 2007 08:08:29 +0200, Jaap Keuter wrote > > > > When trying to attach a one line patch. > Hmm, better follow the suggestion of Anders and post it on the Wiki. Done at http://wiki.wireshark.org/Development/Optimization, currently only the patch, writing some stuff ab

Re: [Wireshark-dev] About a faster wireshark

2007-10-08 Thread Didier
.org/bugzilla/attachment.cgi undef error - Undefined subroutine Fh::slice at data/template/template/en/default/global/hidden-fields.html.tmpl line 58 When trying to attach a one line patch. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

[Wireshark-dev] About a faster wireshark

2007-10-07 Thread Didier
d 40 times faster. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Alternative to USBPcap and Possibility of

2007-10-02 Thread Didier
ignificant modifications of [your] own". However, I don't know > what additional restrictions that'd put on, say, somebody re- > packaging WinPcap. Or you can ask Benoit, I know him and I don't see how it could be an issue. Didier __

Re: [Wireshark-dev] Single TCP segment having multiple PDUs not working

2007-09-27 Thread Didier
On Thu, 27 Sep 2007 13:13:17 -0700, Zongjun wrote > On 9/27/07, Zongjun <[EMAIL PROTECTED]> wrote:Hey Didier, > > You mean like > >     gint  offset_thisRound = 0; // of course, outside if(tree)block. > >   if (tree) { >     myproto_item = proto_tree_add

Re: [Wireshark-dev] Single TCP segment having multiple PDUs not working

2007-09-27 Thread Didier
Hi On Thu, 27 Sep 2007 12:02:32 -0700, Zongjun wrote > Hey guys, > > According to my capture, I don't have situations where ONE PDU spans over > multiple TCP segment. In stead, mine is the other round: Single segment > having multiple PDUs. > > But using the folling code, what I observed is wi

Re: [Wireshark-dev] Single TCP segment having multiple PDUs not working

2007-09-27 Thread Didier
Hi On Thu, 27 Sep 2007 12:02:32 -0700, Zongjun wrote > Hey guys, > > According to my capture, I don't have situations where ONE PDU spans over > multiple TCP segment. In stead, mine is the other round: Single segment > having multiple PDUs. > > But using the folling code, what I observed is wi

Re: [Wireshark-dev] Memory leak

2007-08-28 Thread Didier
ny times does not show any growth in > > memory usage for Wireshark. If what you're saying is true then I should see > > /huge/ memory leak each time the file is reloaded, non? Yes you should. Which glib version are you using? Here I'm seeing a 1MB growth for a 20 000 packe

[Wireshark-dev] svn 21618 HTTP is not decoded at all.

2007-07-30 Thread Didier
Hi Sorry but I can't use bugzilla. https (bug 192) it's revision 21618 the culprit. pref reinit callbacks are only called if prefs are changed or aren't the default so sometime http dissector doesn't register itself. Didier ___ W

Re: [Wireshark-dev] Memory leak

2007-07-22 Thread Didier
On Fri, 20 Jul 2007 03:11:20 +0200, Didier wrote > On Thu, 19 Jul 2007 14:16:49 -0400, Jeff Morriss wrote > > Didier wrote: > > [That's not to say I don't see memory usage growing when I reload a > > capture file, but I'm not convinced this is the source.] &g

Re: [Wireshark-dev] Memory leak

2007-07-19 Thread Didier
On Thu, 19 Jul 2007 14:16:49 -0400, Jeff Morriss wrote > Didier wrote: > > Hi, > > > > 1) It seems that since some glib 2.0 version g_mem_chunk_destroy doesn't > > free > > The docs certainly seem to indicate that the memory should actually > be freed:

[Wireshark-dev] Memory leak

2007-07-14 Thread Didier
f place it g_malloc address space but many don't free it. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] TCP Reassembly issues

2007-07-08 Thread Didier
(?) is true increment your global counter and store it in the se_tree. 4) now you can use se_tree_lookup32_le for finding the sequence number of a packet. 5) use fragment_add_seq_check as you already do with this sequence number. Didier === modified file 'epan/dissectors/packet-dnp.c' -

[Wireshark-dev] [PATCH] compilation errors if configure -without -disable-warnings-as-errors

2007-06-11 Thread didier
-iuup.c I haven't tested this one, no capture. Didier Index: gtk/column_prefs.c === --- gtk/column_prefs.c (révision 22073) +++ gtk/column_prefs.c (copie de travail) @@ -47,9 +47,9 @@ Gdk

Re: [Wireshark-dev] [PATCH] wireshark doesn't compile if configure --with-plugins=no

2007-06-11 Thread didier
Hi, Le dimanche 10 juin 2007 à 17:44 +0200, Luis EG Ontanon a écrit : > Can you test the attached patch --with-plugins=no instead It seems to work. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mail

[Wireshark-dev] [PATCH] wireshark doesn't compile if configure --with-plugins=no

2007-06-10 Thread didier
Hi, I'm not sure it's the right way to do it though. Didier Index: editcap.c === --- editcap.c (révision 22041) +++ editcap.c (copie de travail) @@ -388,8 +388,10 @@ g_free(init_progfile_dir_error);

Re: [Wireshark-dev] Different tshark output between P4 and Itanium for NFS trace

2007-05-24 Thread didier
e on the P4 you have tcp checksum disabled and not on the Itanium, tcp dissector doesn't reassemble packet with bad checksum. Or it's a bug in checksum code/Itanium compiler. Didier > On the first machine, a P4, the command I run is: > > wireshark $ ./tshark -R nfs

Re: [Wireshark-dev] about configure --enable-warnings-as-errors

2007-05-21 Thread didier
On lun, 2007-05-21 at 14:54 -0700, Stephen Fisher wrote: > On Mon, May 21, 2007 at 11:38:27PM +0200, didier wrote: > > > I'm trying to compile wireshark svn HEAD and I have warning, so error > > like > > > > warning: comparison is always false due to limit

[Wireshark-dev] about configure --enable-warnings-as-errors

2007-05-21 Thread didier
bugs? Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] AppleTalk fix?

2006-11-16 Thread didier
for anomalies, > This was one of them. Maybe I can pick up some more information when I get > on site. > > What does ATALK_PS80211 2D-3 for anyway? Is it a device or AP? No idea. Didier ___ Wireshark-dev mailing list Wireshark-dev@wires

Re: [Wireshark-dev] AppleTalk fix?

2006-11-16 Thread didier
1 byte + 4 bytes, follow by the zone name. What is it? A Zyxel NAS or router? If ATALK_PS8011 2D-3 is really your zone name it could be a bug in the router. Didier > Thanx, > Jaap > > On Thu, 16 Nov 2006, didier wrote: > > > Hi, > > Le jeudi 16 novembre 2006 à

Re: [Wireshark-dev] AppleTalk fix?

2006-11-16 Thread didier
ee, hf_zip_zero_value, tvb, offset, 2, > FALSE); > + offset += 2; >proto_tree_add_item(zip_tree, hf_zip_zero_value, tvb, offset, 4, > FALSE); >offset += 4; >proto_tree_add_item(zip_tree, hf_zip_zone_name, tvb, offset, 1,FALSE); > >

[Wireshark-dev] [PATCH] small patch to Makefile.am for compiling current SVN outside the source tree

2006-11-14 Thread didier
Hi, idl2wrs.sh is a generated file. Didier Index: Makefile.am === --- Makefile.am (révision 19890) +++ Makefile.am (copie de travail) @@ -71,7 +71,7 @@ EXTRA_SCRIPTS = idl2wrs idl2wrs: tools/idl2wrs.sh Makefile - cp $(srcdir

Re: [Wireshark-dev] Possible bug with check_col?

2006-09-28 Thread didier
seems to fail to do the same thing in the http dissector: > > if (check_col (pinfo->cinfo, COL_PROTOCOL)) > col_set_str (pinfo->cinfo, COL_PROTOCOL, "ABBRV"); > > if (check_col (pinfo->cinfo, COL_INFO)) > col_set_str (pinfo->cinfo, COL_INFO, "Some

Re: [Wireshark-dev] Mac-OS buildbot produces bugzilla entries that I cannot verify

2006-08-27 Thread didier
08-27-19853.pcap frame 281 packet-image-png.c:line 274 g_assert(len<10); tries to decode after png IEND tag or something like that. Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] Anyone of the developers going to support Win98 (and alike) any further? Otherwise we should "officially" drop support of it!

2006-08-27 Thread didier
> maintain the gtk1 code we very likely will remove it in the not too far > future. Guess I can do it, I need gtk1, gtk2 is way too slow and all my changes are for gtk1 so I will have a working gtk1 backport anyway. I can't guarantee a daily update but a monthly one is doable. Could put spee

Re: [Wireshark-dev] Mac-OS buildbot produces bugzilla entries that I cannot verify

2006-08-27 Thread didier
From the error it looks like a bug in png dissector (yesterday stuff). Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] wiretap: New MPEG file format

2006-08-25 Thread didier
rred to a plugin? MPEG2? a plugin is fine for this one... Didier ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://www.wireshark.org/mailman/listinfo/wireshark-dev

Re: [Wireshark-dev] [Bug 1001] free() invalid pointer in dissect_802_3 at packet-ieee8023.c:71

2006-07-26 Thread didier
setup. >From the code it doesn't seems to be a faulty call to free. void except_free(void *ptr) { if (ptr) get_dealloc()(ptr); } in epan/except.c should fixed it. Didier. ___ Wireshark-dev mailing list Wireshark-dev@wireshark.org http://w

<    1   2