Re: [Wireshark-dev] Testing Someone Else's Merge Request

2021-09-27 Thread Dr. Matthias St. Pierre
The main GitLab repository (assuming it’s called ‘origin’) automatically maintains references to the head of the pull requests and their merge commits with the target branch: refs/merge-requests//head refs/merge-requests//merge So instead of looking up the owner and the branch name for merge

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-19 Thread Dr. Matthias St. Pierre
mmits/master?search=LIBGCRYPT_AEAD This since my dev env has not yet seen the light of RHEL8 //Joakim On Mon, 12 Jul 2021 at 19:43, Dr. Matthias St. Pierre mailto:matthias.st.pie...@ncp-e.com>> wrote: > The minimum version being stuck at 1.5.0 is, I believe, almost entirely due >

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread Dr. Matthias St. Pierre
> The minimum version being stuck at 1.5.0 is, I believe, almost entirely due > to RHEL/CentOS 7 being stuck at 1.5.3 > (https://gitlab.com/wireshark/wireshark/-/wikis/Development/Support_library_version_tracking#libgcrypt) > It's a widely used enough distribution, still scheduled for 3 more

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread Dr. Matthias St. Pierre
> If some changes were done to fix the compilation, it means that some people > still use a libgcrypt version older than 1.6.0. > And as seen in our CMakeLists.txt file, the minimum version required for now > is 1.5.0. I understand your reluctancy to upgrade the requirements, but don’t you

[Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread Dr. Matthias St. Pierre
Hi all, in wsgcrypt.h the libgcrypt version is checked to ensure that it supports AEAD ciphers: #if GCRYPT_VERSION_NUMBER >= 0x010600 /* 1.6.0 */ /* Whether to provide support for authentication in addition to decryption. */ #define HAVE_LIBGCRYPT_AEAD #endif

Re: [Wireshark-dev] Replacing wmem_packet_scope() with pinfo->pool?

2021-07-12 Thread Dr. Matthias St. Pierre
ocumented in README.wmem > but still error prone). ... > -Original Message- > From: Wireshark-dev On Behalf Of Dr. > Matthias St. Pierre > Sent: Monday, July 12, 2021 6:38 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] Replacing wmem_p

Re: [Wireshark-dev] Replacing wmem_packet_scope() with pinfo->pool?

2021-07-12 Thread Dr. Matthias St. Pierre
Hi Evan and Pascal, > > At a first glance, we already have pinfo->pool which maintains the > > lifetime of the packet_info object. As far as I can reason, this is > > almost/effectively the same as the existing wmem_packet_scope - it > > gets cleaned up later in the dissection flow, but there's

[Wireshark-dev] Wiki editor permission request

2021-06-22 Thread Dr. Matthias St. Pierre
]: https://gitlab.com/wireshark/wireshark/-/merge_requests/3444 [SampleCaptures]: https://gitlab.com/wireshark/wireshark/-/wikis/SampleCaptures Dr. Matthias St. Pierre Senior Software Engineer matthias.st.pie...@ncp-e.com Phone: +49 911 9968-0 www.ncp-e.com Headquarters Germany: NCP engineering