Re: [Wireshark-dev] buildbot failure in Wireshark (development) on Visual-Studio-Code-Analysis

2011-03-28 Thread Ed Beroset
Chris Maynard wrote: Stephen Fishersteve@... writes: packet-vnc.c(1970) : warning C4018: '' : signed/unsigned mismatch Any ideas? I added a cast that fixes it. I'm not 100% sure why the warning, but I think it might be because the multiplication operation promotes the guint8's to int's.

Re: [Wireshark-dev] libwireshark.lib is missing some proto_registrar_* methods

2011-02-11 Thread Ed Beroset
Andreas wrote: Am 11.02.2011 00:06, schrieb Guy Harris: They weren't omitted on purpose. They were probably omitted because they were added by a UN*X user; by default, UN*X dynamic shared libraries export every non-static symbol, unlike Windows DLLs. I think this is a strong argument to

Re: [Wireshark-dev] Updates to Wireshark Windows Makefiles (SVN #35747)

2011-02-02 Thread Ed Beroset
Jaap Keuter wrote: Are these changes compatible with *all* Windows Compiler / SDK combinations we support (http://www.wireshark.org/docs/wsdg_html_chunked/ChToolsMSChain.html)? I can't verify that Bill's changes are compatible with *all* combinations, but I can verify that I encountered no

Re: [Wireshark-dev] Utility to convert -V text files to pcap??

2011-01-26 Thread Ed Beroset
Christopher Maynard wrote: Alex Lindberg alindber@... writes: Has anyone created a utility to convert the output of tshark -V to pcap files? I think text2pcap is the logical utility to do this. Unfortunately, it doesn't work if the summary information is present, but if you can strip out

Re: [Wireshark-dev] proto_tree_add_bits_ret_val() BUG

2011-01-07 Thread Ed Beroset
George Deprez wrote: *proto_tree_add_bits_ret_val*() displays incorrect values when num_bits is 32 If I ask for 16 bits and adjust the offset by 16 and ask for 16 more I get the correct bits. If I ask for 64 bits from the base offset I get the correct bits. But if I ask for 32 bits from the same

[Wireshark-dev] inclusion of bug 5531?

2011-01-07 Thread Ed Beroset
I know the target release is Monday, 10 Jan 2011, so I'm guessing it may be too late for the inclusion of the patch I submitted with bug 5531. When's the next release? Ed ___ Sent via:Wireshark-dev mailing list

[Wireshark-dev] ASN.1 dissector makefiles under Windows

2011-01-04 Thread Ed Beroset
I notice that when I modify an ASN.1 dissector source code file, that it fails to cause the Windows makefile to rerun asn2wrs. Is there a reason for this? Is there a reason I shouldn't attempt to address this and submit a patch? In searching around, I haven't found any other references to

Re: [Wireshark-dev] Question about tcp window scaling value

2011-01-02 Thread Ed Beroset
Douglas Wood wrote: In Wireshark 1.4.2, export to PDML from tshark sometimes results in a different value for tcp window size compared to doing the same export from the Wireshark GUI. The different value reflects multiplying the tcp window value with the current window scaling size for

Re: [Wireshark-dev] bitmask handling in wireshark

2010-12-28 Thread Ed Beroset
Andrei Emeltchenko wrote: I want to check what is the best way to convert code below to value_string proto_tree_add_text(tree, tvb, offset, 1, %s%s%s%s, (buf 0x80)? 16kHz

Re: [Wireshark-dev] bitmask handling in wireshark

2010-12-28 Thread Ed Beroset
Andreas wrote: So far I've seen only lots of boolean values. You might want to take a look at proto_tree_add_bitmask(). See doc/README.developer, which describes it and illustrates its use by taking an example from the SCSI dissector. Where can I get a sample capture file to see how this

[Wireshark-dev] problem with gtk/rtp_player.c

2010-12-28 Thread Ed Beroset
Under Windows, the recent changes made to gtk/rtp_player.c cause the 2008 version of VC++ to die with a warning that assigning a double to time_t could cause a loss of precision. I changed it by adding an explicit cast to guint64. This is the old problem with doing math on time -- time_t is an

Re: [Wireshark-dev] problem with gtk/rtp_player.c

2010-12-28 Thread Ed Beroset
Stephen Fisher wrote: Thanks. I've committed SVN revision 35293 which removes the call to nstime_to_secs() entirely - since the code only needs one second precision as it is, I'm using the secs portion (time_t) of the nstime structure directly now. All of my compilers are now happy with that

Re: [Wireshark-dev] Problem Compiling Wireshark under Win32

2010-10-20 Thread Ed Beroset
Fox-Moore Ben wrote: I had a vcredist_x86.exe is missing error which I fixed by download vcredist_x86.exe and putting it in C:\wireshark-win32-libs, however I now get another error: tools/win32-setup.sh: line 10: sed: command not found Here's the problem. If you look at tools/win32-setup.sh

Re: [Wireshark-dev] Usage of MS protocol documentation in Wireshark

2010-09-07 Thread Ed Beroset
-Original Message- From: Eloy Paris pe...@chapus.net Sent: Sep 7, 2010 3:11 PM To: wireshark-dev@wireshark.org Subject: Re: [Wireshark-dev] Usage of MS protocol documentation in Wireshark On 09/07/2010 02:20 PM, Stephen Fisher wrote: [...] Microsoft folks would probably find it

[Wireshark-dev] type punning error in packet-gtpv2.c

2010-07-06 Thread Ed Beroset
I just updated and attempted to build Wireshark on a 32-bit Linux box using gcc 4.1.2 and I find that I get an error in the epan/dissectors/packet-gtpv2.c file: packet-gtpv2.c: In function 'proto_register_gtpv2': packet-gtpv2.c:2136: warning: dereferencing type-punned pointer will break

Re: [Wireshark-dev] Creating a Wireshark installer with my dissector in it

2010-06-11 Thread Ed Beroset
Brian Oleksa olek...@darkcornersoftware.com wrote: When I create my installer...my plugin is included...so everything installs and looks right. But when I go to start up wireshark, I get the following error: C:\Program Files\Wireshark\wireshark.exe I infer from this that we're talking about

Re: [Wireshark-dev] Printing?

2010-04-14 Thread Ed Beroset
Shawn Mayer wrote: Do I have to use something other than printf to print from Wireshark? I have the console set to always open, but still am not seeing anything. It works just fine under Linux, so I assume you must be on a Windows machine. Try this:

Re: [Wireshark-dev] basic question

2010-03-29 Thread Ed Beroset
But what if I just wanted to make this dissector available as decode as and not by the port it broadcasts on..?? [...] Just wanted to see what the best thing to do is here. I was just simply going to pick a port that it would never be on...such as 1. You don't want to do that unless port

Re: [Wireshark-dev] INTERLINK dissector plugin added

2010-03-16 Thread Ed Beroset
Aniruddha A aniruddh...@gmail.com wrote: How to decide whether a dissector has to be a plugin or a build-in ? Is it based on the code size ? I have also created a plugin (based on a protocol which is in draft state in IETF) and the code size is small, I was about to raise patch request on

[Wireshark-dev] minor correction to Developer's Guide

2010-03-16 Thread Ed Beroset
I was looking at the Developer's Guide today in section 9.4.2. How to reassemble split TCP Packets and I think I spotted an omission, but I wanted to check with others to make sure it's not my error. The section is here: http://www.wireshark.org/docs/wsdg_html/#TcpDissectPdus The correction

[Wireshark-dev] support for INSTANCE OF in ASN.1

2010-03-13 Thread Ed Beroset
I've been working on a dissector which uses ASN.1 and for the moment I am using type EXTERNAL, but I would prefer to define my own CLASS and use INSTANCE OF instead. In looking through all existing ASN.1 dissectors, it seems that INSTANCE OF seems only to be supported when it's INSTANCE OF

Re: [Wireshark-dev] plugin made from asn.1 generated sources

2010-03-04 Thread Ed Beroset
Petr Kovář wrote: Hello, I've tried to use C sources generated after building the asn.1-based dissector to create own dll for this protocol. Do you mean this? http://wiki.wireshark.org/ASN1_plugin I prepared Makefiles and other needed files, built the dll succesfully, but after

Re: [Wireshark-dev] plugin made from asn.1 generated sources

2010-03-04 Thread Ed Beroset
Petr Kovář wrote: OK, I've send you the Makefile.nmake and few questions from my corporate e-mail. Thanks. I have it now and will work on it as soon as I get to my Windows machine. Ed ___ Sent via:Wireshark-dev

Re: [Wireshark-dev] RTP Muxing with compressed header

2010-02-17 Thread Ed Beroset
This is the error... sour...@debian:~/wireshark-1.3.1/epan/dissectors$ make Makefile:: *** commands commence before first target. Stop. That's a classic symptom of having a tab character in front of a non-command line. Make sure there are no tabs on any of the empty lines, e.g. line 6656

Re: [Wireshark-dev] ASN1-based dissector as plugin

2010-02-08 Thread Ed Beroset
: Hi, Additions to the Wiki on how to build asn2wrs generated plugins or dissectors are most welcome :-) Regards Anders -Ursprungligt meddelande- Från: wireshark-dev-boun...@wireshark.org [mailto:wireshark-dev-boun...@wireshark.org] För Ed Beroset Skickat: den 7 februari 2010 19:31

[Wireshark-dev] ASN1-based dissector as plugin

2010-02-07 Thread Ed Beroset
I've been working on an ASN.1-based dissector lately and got impatient with the slow modify-compile-test cycling, so I have changed it to be an ASN.1-based plugin dissector. I am thinking this technique might be of general use to those building such dissectors, so perhaps a simple sample

[Wireshark-dev] Couldn't unpack C:\WIRESH~1/zlib123ws.zip -- with solution

2010-02-01 Thread Ed Beroset
whether such a change is worth making in the main line build. Ed Beroset ___ Sent via:Wireshark-dev mailing list wireshark-dev@wireshark.org Archives:http://www.wireshark.org/lists/wireshark-dev Unsubscribe: https

<    1   2