Re: [Wireshark-dev] Support Opus in WireShark

2020-01-21 Thread Jiří Novák
Dear Peter, > I have Uploaded lots of RTP captures in various formats to > https://wiki.wireshark.org/SampleCaptures#SIP_and_RTP > Note that while Opus supports multiple settings, there is only one fixed > setting there. I'm aware of such samples, but they are too simple from my point of view. iL

Re: [Wireshark-dev] Support Opus in WireShark

2020-01-20 Thread Jiří Novák
Dear Roland, > I can provide some examples if needed, of exactly that. Either multiple > OPUS streams, or traces which contain opus and G.711 in the same > conversation. Just tell me, if you need a new bug-entry created or have > an existing one to attach to. It would be nice if you can create it

Re: [Wireshark-dev] Support Opus in WireShark

2020-01-20 Thread Jiří Novák
Dear Ryan, > Using C++ default parameter because I want to use Opus FEC.  When a RTP > packet lost, I need to use the next packet’s data to recovery the lost > data. But the decoder module only have data ,can’t get the neighbor > packet’s information. So I modified  the rtp_audio_stream.cpp to pla

Re: [Wireshark-dev] Support Opus in WireShark

2020-01-19 Thread Jiří Novák
Hi Ryan, I'm just finishing adding ilbc codec do Wireshark. You can check https://code.wireshark.org/review/#/c/35686/ to see what to change/add. > Here is the change: > > 1、Change a function with C++ default parameters > > Origin version: size_t convert_payload_to_samples(uns

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2020-01-07 Thread Jiří Novák
Hi Pascal, > Where can we find a sample capture for testing? Could you create an > enhancement bug with the capture attached and referenced by the changeset? see bug 16314. It will be referred in next patch comment... Best regards,

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2020-01-07 Thread Jiří Novák
Hello, I posted patch with iLBC for review: https://code.wireshark.org/review/#/c/35686/ I made my best with updating tools/*setup* files, but I have no way how to test them. I kindly ask you for help: - update Windows setup files - update MacOS macos-setup.sh - test other Unix like non Redh

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-29 Thread Jiří Novák
Hi, > For Ubuntu there is tools/debian-setup.sh that installs optional > packages (as this). > I suggest you to test your change at least on this platform since it's > the most common. OK. I will try. > Did you make your change compilable without that library? You need some > preprocessor ifdefs

Re: [Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-12-28 Thread Jiří Novák
Hello, I finished iLBC codec support and it works fine for decoding and audio saving. The only issue is that I'm able to build and test it on Linux only. It depends on iLBC lib from https://github.com/TimothyGu/libilbc. It is package ilbc/ilbc-devel on Fedora (ilbc-1.1.1-16.fc30.x86_64/ilbc-de

Re: [Wireshark-dev] G729 Wiki page

2019-12-27 Thread Jiří Novák
Dear Graham and Jaap, >> On 17 Nov 2019, at 21:15, Jiří Novák wrote: >> >> Dear Graham, >> >>> Can you update the Wiki page when that occurs? >> >> I do my best. >> BTW what do you expect to read on page about G.729? >> I imagine (in p

[Wireshark-dev] Became member of EditorGroup on Wiki

2019-12-19 Thread Jiří Novák
Hello, I'm kindly asking for adding me to EditorGroup. I would like to update page about Decoding of G.729 (https://wiki.wireshark.org/HowToDecodeG729). My Wiki username is JiriNovak. Thank you, J

Re: [Wireshark-dev] G729 Wiki page

2019-11-17 Thread Jiří Novák
Dear Graham, > Can you update the Wiki page when that occurs? I do my best. BTW what do you expect to read on page about G.729? I imagine (in points): - G.729 is now supported by Wireshark - RTP player allows to play it - Save as .au saves it too Old procedure described on the page works too wit

[Wireshark-dev] How to add ilbc library to wireshark CMake?

2019-11-16 Thread Jiří Novák
Hi, I would like to write decoder for RTP with iLBC payload. I plan to use ilbc library (https://github.com/TimothyGu/libilbc). I copied detection commands from another library to CMakeFile and I created/adapted cmake/modules/FindILBC.cmake too. When I run cmake, it do not try to detect iLBC l

Re: [Wireshark-dev] G729 Wiki page

2019-11-16 Thread Jiří Novák
Hi, > We have G.729 decode in the player, but can’t save media in RTP streams > other than G.711A/μ. > There are probably easier ways to do this now since the page was written.  > A rework of the decoding pipeline in Wireshark, so that both player and > file saving could use them would be best, bu