Re: [Wireshark-dev] Suppress [TCP segment of a reassembled PDU] in COL_INFO

2019-02-11 Thread david_aggeler
> -Original Message- > From: Wireshark-dev On Behalf > Of Guy Harris > Sent: Sunday, February 10, 2019 8:58 PM > To: Developer support list for Wireshark > Subject: Re: [Wireshark-dev] Suppress [TCP segment of a reassembled PDU] > in COL_INFO > > On Feb 10, 2019, at 11:44 AM, > wrote:

[Wireshark-dev] Suppress [TCP segment of a reassembled PDU] in COL_INFO

2019-02-10 Thread david_aggeler
I'm cleaning up the re-assembly in the DICOM decoder (I haven't touched it for years, so it was overdue) DICOM data elements are usually pretty big, and I need more than TCP level re-assembly. To have COL_INFO focus on what is relevant for DICOM, I'd like to suppress the postfix of "[TCP s

Re: [Wireshark-dev] Cannot find krb5.h

2019-02-07 Thread david_aggeler
Pascal, Graham, Thanks. That fixed it. It contained the wrong pointers. (still to kfw-3-2-2-x64-ws) My (wrong) assumption was, that following would take care of all of the dependency management. cmake -G "Visual Studio 15 2017 Win64" C:\Development\current\wireshark This is what I

[Wireshark-dev] Cannot find krb5.h

2019-02-07 Thread david_aggeler
I've updated my machine to VS2017, Latest, Qt, Git, Python, .. And I got rid of cygwin and vs2015 The setup should match the instruction, but apparently not quite. (win10, x64) Right now I fail to build latest master (a clean build does not help, deleting all libs neither) "C:\Developme

Re: [Wireshark-dev] Push failed after amend (Change 27518)

2018-06-11 Thread david_aggeler
Hi Pascal, I don’t think I have a clue what I’m doing. I think I finally managed to squash the two commits under one change ID. I was not doing the ‘interactive’ part correctly. I’ve now sent it to Gerrit. It looks ok to me. Regards David From: Wireshark-dev [mailto:wireshark-de

Re: [Wireshark-dev] Push failed after amend (Change 27518)

2018-06-11 Thread david_aggeler
Hi Pascal, Dario, I did a git rebase -I HEAD~2 (any a few others). That seems to work, but not the subsequent push. I’ve attached a log if that helps. Regards David From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Pascal Quantin Sent: Monday, June 11,

Re: [Wireshark-dev] Push failed after amend (Change 27518)

2018-06-11 Thread david_aggeler
Thanks. I now tried --force-with-lease and --force. Neither of them worked. Regards David -Original Message- From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Ahmad Fatoum Sent: Monday, June 11, 2018 9:33 AM To: Developer support list for Wireshark Subject

[Wireshark-dev] Push failed after amend (Change 27518)

2018-06-11 Thread david_aggeler
I still have to learn a lot. I've got a pending review, so I've updated my code, amended as I thought I needed to, and tried to push once more (as I did last time except the last push did not have the author populated). However I get an error: == remote: Processing changes: refs: 1, don

[Wireshark-dev] Bug-13388 - TCP level reassembly bug in 2.x ??

2018-03-27 Thread david_aggeler
I stepped through a DICOM capture multiple times, and the result is a little surprising. I've attached an analysis document to the bug and the minimal .pcapng to reproduce. To me, it looks like the re-assembly does not work anymore, when the TCP traffic has missing frames and retransmits.

[Wireshark-dev] Submit code .... from Windows OS

2018-03-05 Thread david_aggeler
How difficult can life be? Or my super bumpy road to a check-in, which caused a lot of frustration on the way. This is intended for possible improvements of the developer guides. Sometimes it helps to get feedback from someone with little perception and little previous knowledge on the topics

Re: [Wireshark-dev] Can't start 2.5: Err Duplicate protocol name "DOCSIS Vendor Specific Encodings"

2018-02-20 Thread david_aggeler
Thanks. That solved it. Regards David From: Wireshark-dev [mailto:wireshark-dev-boun...@wireshark.org] On Behalf Of Anders Broman Sent: Tuesday, February 20, 2018 4:49 PM To: Developer support list for Wireshark Subject: Re: [Wireshark-dev] Can't start 2.5: Err Duplicate protocol name

[Wireshark-dev] Can't start 2.5: Err Duplicate protocol name "DOCSIS Vendor Specific Encodings"

2018-02-20 Thread david_aggeler
I'm trying to build & run 2.5. After I pulled the latest code last Friday I can't start it anymore. I get: "Err Duplicate protocol name "DOCSIS Vendor Specific Encodings"! This might be caused by an inappropriate plugin or a development error. Press any key to exit" On the same machine I bui

[Wireshark-dev] Wireshark 1.1.0 does not start on Clean XP

2008-09-23 Thread david_aggeler
I hardly dare to ask. Am I the only one, who has difficulties to start wireshark dev 1.1 (http://www.wireshark.org/download/win32/wireshark-win32-1.1.0.exe)? I get 'Application failed to start because the application configuration is incorrect' I tried it on a system which had many wireshark

Re: [Wireshark-dev] packet-dcm.c:960: warning: pointer type mismatch in conditional expression (Jeff Morriss)

2008-07-25 Thread david_aggeler
Thanks for all the check-in work and sorry for some of the headache. I will follow up on the issues left and supply a patch promptly. Since the static definition will grow soon (+100kB), is there a recommended way outside the main .c file or should I merge before submitting the patch? A few thi

[Wireshark-dev] DISSECTOR_ASSERT vs. expert_add_info vs. MALFORMED packets

2008-06-10 Thread david_aggeler
In order to better help the end user reading captures, I'm trying to set hints, when decoding problems arise, due to packet data. My first attempt was using DISSECTOR_ASSERT(), but this causes a 'bug in dissector'. After reading a thread the dev-archive, this is apparently by design, but about