Re: [Wireshark-dev] #ifdef mess

2016-04-02 Thread Jaap Keuter
On 30-03-16 00:48, Joerg Mayer wrote: > On Tue, Mar 29, 2016 at 03:34:38PM +0100, João Valverde wrote: >> On 28-03-2016 23:30, Joerg Mayer wrote: >>> I've been meaning to write this mail for some years now but finally got >>> around to it. >>> >>> Earlier today I committed 30900b443b85a7e760d703ca

Re: [Wireshark-dev] #ifdef mess

2016-03-31 Thread Guy Harris
On Mar 31, 2016, at 12:09 AM, Alexis La Goutte wrote: > You can set also > g_string_append_printf(str, "without libz"); ...which would duplicate what's in the "Compiled with" list. That could be considered a bug (redundancy) or a feature (making it clear in both cases that there's no libz).

Re: [Wireshark-dev] #ifdef mess

2016-03-31 Thread Alexis La Goutte
On Tue, Mar 29, 2016 at 3:48 AM, Guy Harris wrote: > On Mar 28, 2016, at 3:30 PM, Joerg Mayer wrote: > > > Earlier today I committed 30900b443b85a7e760d703ca3d6efe61df4fe623, > which I'm > > incredibly unproud of because of readablity: > > > > static void > > -get_reordercap_runtime_info(GString

Re: [Wireshark-dev] #ifdef mess

2016-03-29 Thread João Valverde
On 29-03-2016 23:48, Joerg Mayer wrote: On Tue, Mar 29, 2016 at 03:34:38PM +0100, João Valverde wrote: On 28-03-2016 23:30, Joerg Mayer wrote: I've been meaning to write this mail for some years now but finally got around to it. Earlier today I committed 30900b443b85a7e760d703ca3d6efe61df4f

Re: [Wireshark-dev] #ifdef mess

2016-03-29 Thread Joerg Mayer
On Tue, Mar 29, 2016 at 03:34:38PM +0100, João Valverde wrote: > On 28-03-2016 23:30, Joerg Mayer wrote: > >I've been meaning to write this mail for some years now but finally got > >around to it. > > > >Earlier today I committed 30900b443b85a7e760d703ca3d6efe61df4fe623, which I'm > >incredibly un

Re: [Wireshark-dev] #ifdef mess

2016-03-29 Thread João Valverde
On 28-03-2016 23:30, Joerg Mayer wrote: Hello list, I've been meaning to write this mail for some years now but finally got around to it. Earlier today I committed 30900b443b85a7e760d703ca3d6efe61df4fe623, which I'm incredibly unproud of because of readablity: static void -get_reordercap_

Re: [Wireshark-dev] #ifdef mess

2016-03-29 Thread Dario Lombardo
On Tue, Mar 29, 2016 at 3:48 AM, Guy Harris wrote: > > which is a bit of a greasy hack - appending an empty string to str, just > so it's marked as used - but I suspect the extra CPU time spent doing that, > on platforms unlucky enough not to have zlib, will be lost in the noise. > I would not g

Re: [Wireshark-dev] #ifdef mess

2016-03-28 Thread Guy Harris
On Mar 28, 2016, at 3:30 PM, Joerg Mayer wrote: > Earlier today I committed 30900b443b85a7e760d703ca3d6efe61df4fe623, which I'm > incredibly unproud of because of readablity: > > static void > -get_reordercap_runtime_info(GString *str _U_) > +get_reordercap_runtime_info( > +#if defined(HAVE_LIBZ

[Wireshark-dev] #ifdef mess

2016-03-28 Thread Joerg Mayer
Hello list, I've been meaning to write this mail for some years now but finally got around to it. Earlier today I committed 30900b443b85a7e760d703ca3d6efe61df4fe623, which I'm incredibly unproud of because of readablity: static void -get_reordercap_runtime_info(GString *str _U_) +get_reorderca