-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Never mind,
I have misunderstood your e-mail. You made modifications, not requests
:). I have found rev21390 and looked at it. Looks good :) Thanks.
Regards,
Matthijs
Matthijs Mekking wrote:
> Ok, found some time to work at SHIM6 Wireshark, but I
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Ok, found some time to work at SHIM6 Wireshark, but I'm not that
familiar with the revisions system. Some questions:
> checked in as rev21390 with the following modifications :
Where can I find this?
> - use distinct subtree idx for each subtree,
Hi,
checked in as rev21390 with the following modifications :
- use of proto_tree_add_item whenever possible (addition of several
hf_items),
- use distinct subtree idx for each subtree,
- addition of some subtrees,
- split shim_opts in several functions,
- accurate incrementation of offs
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Hello,
> - in hf_register_info, there are two items of the same name :
> hf_ipv6_shim6_opt_len
This is fixed in the source and in the patch.
> - you should create an helper function to add hf_ipv6_shim6_ct to the tree.
I know, but at the moment I d
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I did indeed. I fixed the patch.
Regards,
Matthijs
Sebastien Tandel wrote:
> Hi,
> your patch is malformed line 63. You've probably deleted some hf_items
> or some comments directly in the patch but that must be reflected in the
> "accounting numb
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
I did indeed! I deleted a line that didn't matter, but screwed up the
accounting numbers apparently. It is now fixed.
Regards,
Matthijs
Sebastien Tandel wrote:
> Hi,
> your patch is malformed line 63. You've probably deleted some hf_items
> or som
Hi,
some quick comments :
- in hf_register_info, there are two items of the same name :
hf_ipv6_shim6_opt_len
- you should create an helper function to add hf_ipv6_shim6_ct to the tree.
- instead of dissect_shim_ip_addr, use
proto_tree_add_item/proto_tree_add_ipv6. The type of the item is then
FT
Hi,
your patch is malformed line 63. You've probably deleted some hf_items
or some comments directly in the patch but that must be reflected in the
"accounting numbers" of the patch format ;)
Regards,
Sebastien Tandel
Matthijs Mekking wrote:
> Thanks for the advice. I have attached a new patch
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Thanks for the advice. I have attached a new patch, were you can apply
shim6 elements as filter easier.
more info at www.pletterpet.nl/shim6/
Regards,
Matthijs Mekking
[EMAIL PROTECTED]
NLNetLabs Amsterdam / Radboud University Nijmegen
Sebastien Ta
