Re: [Wireshark-dev] [Patch] Fix for bug #1163: "Dissector bug. ISO8073COTP protocol."

2006-11-10 Thread Stephen Fisher
Please apply the attached patch which is a new more accurate fix for bug #1163. Thanks to Graeme Lunt for pointing out that the first patch broke a different capture with legitimate SES data in it. My patch also corrects the check for number of bytes existing from 4 to 2 as the minimum lengt

Re: [Wireshark-dev] [Patch] Fix for bug #1163: "Dissector bug. ISO8073COTP protocol."

2006-11-08 Thread Graeme Lunt
Steve, > > This patch (r19733) breaks the dissection of X.400 and X.500 > > protocols, and probably other things besides. I think that the > > heuristic is incorrect. > > Oops, sorry about that. Do you know where I can get a copy of the > standard so I can fix the heuristic in a better way? No p

Re: [Wireshark-dev] [Patch] Fix for bug #1163: "Dissector bug. ISO8073COTP protocol."

2006-11-06 Thread Stephen Fisher
On Mon, Nov 06, 2006 at 06:35:25PM +0100, Graeme Lunt wrote: > This patch (r19733) breaks the dissection of X.400 and X.500 > protocols, and probably other things besides. I think that the > heuristic is incorrect. Oops, sorry about that. Do you know where I can get a copy of the standard so

Re: [Wireshark-dev] [Patch] Fix for bug #1163: "Dissector bug. ISO8073COTP protocol."

2006-11-06 Thread Graeme Lunt
Steve, > Attached is a patch to fix bug #1163: "Dissector bug. ISO8073 COTP > protocol." The SES dissector was incorrectly believing it had PDUs > within the COTP PDUs. I added an additional heuristic check > to see if > the length of the SES PDU is 0, then return false since it > can't be