Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-10-09 Thread Ulf Lamping
Joerg Mayer wrote: > On Mon, Oct 09, 2006 at 01:13:16AM +0200, Ulf Lamping wrote: > >> The direction is to use dumpcap in tshark as well. The direction is >> therefore to use as much of the capture_loop code in tshark as >> reasonably possible. >> > > Is anyone going to actually do that?

Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-10-09 Thread Richard van der Hoff
Ulf Lamping wrote: > ... and now it's checked in! Excellent, thanks Ulf! > BTW: The mkfifo command isn't available on Win32 (even on cygwin), so I > made this test configurable in config.sh. Ah. Good thinking. Perhaps this should be something like which 'mkfifo' >/dev/null && TEST_FIFO=1 so a

Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-10-09 Thread Joerg Mayer
On Mon, Oct 09, 2006 at 01:13:16AM +0200, Ulf Lamping wrote: > The direction is to use dumpcap in tshark as well. The direction is > therefore to use as much of the capture_loop code in tshark as > reasonably possible. Is anyone going to actually do that? It's been on the agenda for quite a whil

Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-10-08 Thread Ulf Lamping
Richard van der Hoff wrote: > Any thoughts on this? Ulf, in particular? At the very least, a > clarification of the direction this code is supposed to be going would > be appreciated. > > To summarise the story so far: > > - capture from a fifo doesn't work for tshark > - I proposed a patch to ma

Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-10-06 Thread Richard van der Hoff
Any thoughts on this? Ulf, in particular? At the very least, a clarification of the direction this code is supposed to be going would be appreciated. To summarise the story so far: - capture from a fifo doesn't work for tshark - I proposed a patch to make tshark use capture_loop_dispatch rather

Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-09-25 Thread Richard van der Hoff
Ulf Lamping wrote: > Richard van der Hoff wrote: >> Richard van der Hoff wrote: >>> [tshark from a fifo] >>> Ulf - I notice you made the relevant change here (r16787) - is there >>> any reason why tshark shouldn't use capture_loop_dispatch to do its >>> processing, rather than attempting to use c

Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-09-21 Thread Ulf Lamping
Richard van der Hoff wrote: > Richard van der Hoff wrote: >> [tshark from a fifo] >> Ulf - I notice you made the relevant change here (r16787) - is there >> any reason why tshark shouldn't use capture_loop_dispatch to do its >> processing, rather than attempting to use cap_pipe_dispatch or >> pc

Re: [Wireshark-dev] [Patch] Re: capture from a fifo

2006-07-26 Thread Richard van der Hoff
Richard van der Hoff wrote: > Richard van der Hoff wrote: >> [tshark from a fifo] >> Ulf - I notice you made the relevant change here (r16787) - is there >> any reason why tshark shouldn't use capture_loop_dispatch to do its >> processing, rather than attempting to use cap_pipe_dispatch or >> pc

[Wireshark-dev] [Patch] Re: capture from a fifo

2006-07-26 Thread Richard van der Hoff
Richard van der Hoff wrote: [tshark from a fifo] Ulf - I notice you made the relevant change here (r16787) - is there any reason why tshark shouldn't use capture_loop_dispatch to do its processing, rather than attempting to use cap_pipe_dispatch or pcap_dispatch directly? well, there didn't