Re: [Wireshark-dev] [Patch] gtk/file_dlg_win32.c

2010-11-22 Thread Gisle Vanem
"Bill Meier" wrote: > Without knowing the code, but given that print_update_dynamic() appears > to be only used in file_dlg_win32.c I'd be inclined to remove the > declaration from the .h file > > Any reason not to ? That would be the best, sure. --gv

Re: [Wireshark-dev] [Patch] gtk/file_dlg_win32.c

2010-11-22 Thread Bill Meier
On 11/22/2010 1:41 PM, Gisle Vanem wrote: > print_update_dynamic() isn't defined 'static' in file_dlg_win32.h. > Hence: > > --- gtk\file_dlg_win32.cSun Nov 21 04:04:45 2010 > +++ gtk\file_dlg_win32.c Mon Nov 22 13:54:53 2010 > @@ -886,7 +886,7 @@ > print_update_dynamic(dlg_hwnd, a

[Wireshark-dev] [Patch] gtk/file_dlg_win32.c

2010-11-22 Thread Gisle Vanem
print_update_dynamic() isn't defined 'static' in file_dlg_win32.h. Hence: --- gtk\file_dlg_win32.cSun Nov 21 04:04:45 2010 +++ gtk\file_dlg_win32.c Mon Nov 22 13:54:53 2010 @@ -886,7 +886,7 @@ print_update_dynamic(dlg_hwnd, args); } -static void +void print_update_dynamic(HWND