Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Jeff Morriss
On 08/01/14 14:04, Evan Huus wrote: On Fri, Aug 1, 2014 at 1:58 PM, Jeff Morriss mailto:jeff.morriss...@gmail.com>> wrote: On 08/01/14 13:54, Guy Harris wrote: On Aug 1, 2014, at 2:00 AM, Peter Wu mailto:pe...@lekensteyn.nl>> wrote: On Thursday 31 July 2014 16:40:53 Gu

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Evan Huus
On Fri, Aug 1, 2014 at 1:58 PM, Jeff Morriss wrote: > On 08/01/14 13:54, Guy Harris wrote: > >> >> On Aug 1, 2014, at 2:00 AM, Peter Wu wrote: >> >> On Thursday 31 July 2014 16:40:53 Guy Harris wrote: >>> On Jul 31, 2014, at 3:11 PM, Peter Wu wrote: >>> [..] >>> Oh my, that file

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Jeff Morriss
On 08/01/14 13:54, Guy Harris wrote: On Aug 1, 2014, at 2:00 AM, Peter Wu wrote: On Thursday 31 July 2014 16:40:53 Guy Harris wrote: On Jul 31, 2014, at 3:11 PM, Peter Wu wrote: [..] Oh my, that filesystem.c code is really ugly and relying on a lot of assumptions. Why does it need to dist

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Guy Harris
On Aug 1, 2014, at 2:00 AM, Peter Wu wrote: > On Thursday 31 July 2014 16:40:53 Guy Harris wrote: >> On Jul 31, 2014, at 3:11 PM, Peter Wu wrote: > [..] >>> Oh my, that filesystem.c code is really ugly and relying on a lot of >>> assumptions. Why does it need to distinguish build dirs from oth

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Evan Huus
> On Aug 1, 2014, at 5:12, Peter Wu wrote: > >> On Thursday 31 July 2014 20:04:52 Evan Huus wrote: >> FWIW this issue also makes it impossible to run parts of the test suite >> from an out-of-tree build, which can be problematic. > > Which part exactly? I can run most of the test-suite with an

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Peter Wu
On Thursday 31 July 2014 20:04:52 Evan Huus wrote: > FWIW this issue also makes it impossible to run parts of the test suite > from an out-of-tree build, which can be problematic. Which part exactly? I can run most of the test-suite with an OOT build using: WS_BIN_PATH=/tmp/wsbuild/run ./test.sh

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-08-01 Thread Peter Wu
On Thursday 31 July 2014 16:40:53 Guy Harris wrote: > On Jul 31, 2014, at 3:11 PM, Peter Wu wrote: [..] > > Oh my, that filesystem.c code is really ugly and relying on a lot of > > assumptions. Why does it need to distinguish build dirs from other dirs in > > the first place? > > So that you can

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-07-31 Thread Evan Huus
FWIW this issue also makes it impossible to run parts of the test suite from an out-of-tree build, which can be problematic. On Thu, Jul 31, 2014 at 4:56 PM, Wireshark code review < code-review-do-not-re...@wireshark.org> wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-07-31 Thread Guy Harris
On Jul 31, 2014, at 3:11 PM, Peter Wu wrote: > On Thursday 31 July 2014 17:11:59 Evan Huus wrote: >> This issue has been bugging me for a while, but I also haven't been able to >> come up with a satisfactory solution. > > Oh my, that filesystem.c code is really ugly and relying on a lot of > a

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-07-31 Thread Peter Wu
On Thursday 31 July 2014 17:11:59 Evan Huus wrote: > This issue has been bugging me for a while, but I also haven't been able to > come up with a satisfactory solution. Oh my, that filesystem.c code is really ugly and relying on a lot of assumptions. Why does it need to distinguish build dirs fro

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-07-31 Thread Joerg Mayer
On Thu, Jul 31, 2014 at 05:11:59PM -0400, Evan Huus wrote: > This issue has been bugging me for a while, but I also haven't been able to > come up with a satisfactory solution. I hope to look into this soon ('ish) Ciao Jörg -- Joerg Mayer We are s

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-07-31 Thread Joerg Mayer
On Thu, Jul 31, 2014 at 08:56:31PM +, Wireshark code review wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=43a81b61395358d93a3f859e9058dfd7ecc39a7e > Submitter: Guy Harris (g...@alum.mit.edu) > Changed: branch: master > Repository: wireshark > > Commits: >

Re: [Wireshark-dev] [Wireshark-commits] master 43a81b6: Add some information on running from the build directory.

2014-07-31 Thread Evan Huus
This issue has been bugging me for a while, but I also haven't been able to come up with a satisfactory solution. On Thu, Jul 31, 2014 at 4:56 PM, Wireshark code review < code-review-do-not-re...@wireshark.org> wrote: > URL: > https://code.wireshark.org/review/gitweb?p=wireshark.git;a=commit;h=4