Re: [Wireshark-dev] [Wireshark-commits] rev 19777: /trunk/ /trunk/: capture-pcap-util.c capture_loop.c capture_opts.c dumpcap.c

Ulf Lamping wrote: > What are the reasons of the following changes in capture_loop.c: I've backed those out, for the reasons noted; the right way to fix null-pointer dereferences in routines not defined to accept null pointers is not to add checks to those routines, it's to avoid passing those

Re: [Wireshark-dev] [Wireshark-commits] rev 19777: /trunk/ /trunk/: capture-pcap-util.c capture_loop.c capture_opts.c dumpcap.c

On Mon, Nov 06, 2006 at 11:30:12PM +0100, Ulf Lamping wrote: > These places look bogus and should be reverted, unless there are good > reasons that I don't see ... You know the code much better than I do, so feel free to revert that stuff! Basically the only thing I tried to make sure was that th

Re: [Wireshark-dev] [Wireshark-commits] rev 19777: /trunk/ /trunk/: capture-pcap-util.c capture_loop.c capture_opts.c dumpcap.c

[EMAIL PROTECTED] wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=19777 > > User: jmayer > Date: 2006/11/02 09:45 AM > > Log: > Frederic Heem: > Fix some memleaks and overflows. > > I haven't committed the changes that are not bug fixes. > > Directory: /trunk/ > Ch