Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-11 Thread Joerg Mayer
On Sun, Oct 11, 2009 at 04:52:12PM +0200, Kovarththanan Rajaratnam wrote: > Have you thought about how we should handle the autogenerated > dissectors? I'm looking at this right now and I'm not quite sure how to > do this in a clean fashion. Any ideas? Which autogenerated dissectors are you talk

Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-11 Thread Kovarththanan Rajaratnam
Hey, Joerg Mayer wrote: > On Sat, Oct 10, 2009 at 03:37:20PM +0200, Kovarththanan Rajaratnam wrote: > OK, the (to me :-) convincing arguments were: More than double the amount > of disk space needed during build (less important) and the dissectors were > linked into the binaries statically instead

Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-11 Thread Joerg Mayer
On Sat, Oct 10, 2009 at 03:37:20PM +0200, Kovarththanan Rajaratnam wrote: > > On Sat, Oct 10, 2009 at 11:19:46AM +0200, Kovarththanan Rajaratnam wrote: > >>> What's the idea of crating the subdir CMakefiles and the static libs? > >>> I was happy to get rid of them as they add an unnecessary linking

Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-10 Thread Kovarththanan Rajaratnam
Joerg Mayer wrote: > On Sat, Oct 10, 2009 at 11:19:46AM +0200, Kovarththanan Rajaratnam wrote: >>> What's the idea of crating the subdir CMakefiles and the static libs? >>> I was happy to get rid of them as they add an unnecessary linking step. >>> Also, are you sure that linking a static lib into

Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-10 Thread Joerg Mayer
On Sat, Oct 10, 2009 at 11:19:46AM +0200, Kovarththanan Rajaratnam wrote: > > What's the idea of crating the subdir CMakefiles and the static libs? > > I was happy to get rid of them as they add an unnecessary linking step. > > Also, are you sure that linking a static lib into a dynamic one is OK?

Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-10 Thread Guy Harris
On Oct 10, 2009, at 1:35 AM, Joerg Mayer wrote: > Also, are you sure that linking a static lib into a dynamic one is OK? I think that, on most UN*Xes, at least, building a dynamic library is similar to building an executable image - object files are linked in, and object files in archive lib

Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-10 Thread Kovarththanan Rajaratnam
Joerg Mayer wrote: > On Fri, Oct 09, 2009 at 06:22:25PM +, k...@wireshark.org wrote: >> http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=30439 >> >> User: krj >> Date: 2009/10/09 11:22 AM >> >> Log: >> Add epan/crc/CMakeLists.txt which creates a static crc library >> >> Directo

Re: [Wireshark-dev] [Wireshark-commits] rev 30439: /trunk/epan/ /trunk/epan/crc/: CMakeLists.txt /trunk/epan/: CMakeLists.txt

2009-10-10 Thread Joerg Mayer
On Fri, Oct 09, 2009 at 06:22:25PM +, k...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=30439 > > User: krj > Date: 2009/10/09 11:22 AM > > Log: > Add epan/crc/CMakeLists.txt which creates a static crc library > > Directory: /trunk/epan/crc/ > Ch