Re: [Wireshark-dev] [Wireshark-commits] rev 40877: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dns.c

2012-02-09 Thread Jeff Morriss
Joerg Mayer wrote: On Wed, Feb 08, 2012 at 09:16:48AM -0500, Jeff Morriss wrote: Joerg Mayer wrote: [...] So more than half of all the stuff is added by using proto_tree_add_text. As long as the ratio is that way, people are likely to continue using it inside this dissector. Any volunteer(s) to

Re: [Wireshark-dev] [Wireshark-commits] rev 40877: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dns.c

2012-02-08 Thread Alexis La Goutte
On Wed, Feb 8, 2012 at 3:16 PM, Jeff Morriss wrote: > Joerg Mayer wrote: > [...] > > So more than half of all the stuff is added by using proto_tree_add_text. >> As long as the ratio is that way, people are likely to continue using it >> inside this dissector. >> Any volunteer(s) to get this down

Re: [Wireshark-dev] [Wireshark-commits] rev 40877: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dns.c

2012-02-08 Thread Joerg Mayer
On Wed, Feb 08, 2012 at 09:16:48AM -0500, Jeff Morriss wrote: > Joerg Mayer wrote: > [...] >> So more than half of all the stuff is added by using proto_tree_add_text. >> As long as the ratio is that way, people are likely to continue using it >> inside this dissector. >> Any volunteer(s) to get th

Re: [Wireshark-dev] [Wireshark-commits] rev 40877: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dns.c

2012-02-08 Thread Jeff Morriss
Joerg Mayer wrote: [...] So more than half of all the stuff is added by using proto_tree_add_text. As long as the ratio is that way, people are likely to continue using it inside this dissector. Any volunteer(s) to get this down to some sane level by replacing it by proto_tree_add_item and adding

Re: [Wireshark-dev] [Wireshark-commits] rev 40877: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dns.c

2012-02-06 Thread Alexis La Goutte
Hi, On Tue, Feb 7, 2012 at 8:20 AM, Joerg Mayer wrote: > On Mon, Feb 06, 2012 at 04:36:23PM +, alagou...@wireshark.org wrote: > > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40877 > > > > From https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6704 > > DNS KEY RDATA c

Re: [Wireshark-dev] [Wireshark-commits] rev 40877: /trunk/epan/dissectors/ /trunk/epan/dissectors/: packet-dns.c

2012-02-06 Thread Joerg Mayer
On Mon, Feb 06, 2012 at 04:36:23PM +, alagou...@wireshark.org wrote: > http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=rev&revision=40877 > > From https://bugs.wireshark.org/bugzilla/show_bug.cgi?id=6704 > DNS KEY RDATA contains an extra "Key id" field > > Set Key Id is a generated it