Re: [Wireshark-dev] [Wireshark-commits] rev 47188: /trunk/ui/gtk/ /trunk/ui/gtk/: main.c

2013-01-21 Thread Dirk Jagdmann
the logical and is the very same in both revisions. But what makes this code confusing is the use of prefs.capture_device in one place and then prefs_p-capture_device in another. Maybe what you really want is if ((global_capture_opts.num_selected == 0) (prefs.capture_device != NULL)

Re: [Wireshark-dev] [Wireshark-commits] rev 47188: /trunk/ui/gtk/ /trunk/ui/gtk/: main.c

2013-01-21 Thread Graham Bloice
On 21 January 2013 17:27, Dirk Jagdmann d...@cubic.org wrote: the logical and is the very same in both revisions. But what makes this code confusing is the use of prefs.capture_device in one place and then prefs_p-capture_device in another. Maybe what you really want is if

Re: [Wireshark-dev] [Wireshark-commits] rev 47188: /trunk/ui/gtk/ /trunk/ui/gtk/: main.c

2013-01-20 Thread Guy Harris
On Jan 20, 2013, at 1:45 PM, j...@wireshark.org wrote: http://anonsvn.wireshark.org/viewvc/viewvc.cgi?view=revrevision=47188 User: jake Date: 2013/01/20 01:45 PM Log: Fix for CID 715142. Be aware that the short-circuit evaluation only applies to the first operand of a logical AND

Re: [Wireshark-dev] [Wireshark-commits] rev 47188: /trunk/ui/gtk/ /trunk/ui/gtk/: main.c

2013-01-20 Thread Jaap Keuter
Hi, I think I have been staring at line 2895 too long. Since I didn't have Coverity at my disposal this weekend I tried to take a stab at it, but couldn't verify it. It looks like a strange construction anyway. prefs_p = read_configuration_files (gdp_path, dp_path); is what makes it work, but