Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-22 Thread ronnie sahlberg
What you want is a plugin dissector. Look in the plugins directory for examples on how these work. This will result in a so/dll that you can distribute independently of wireshark. There is one caveat though. Plugins rarely work across different versions of wireshark due to api/abi changes. So you

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Martin Sustrik
Hi, GPL is ok. The only concern is that I don't like an idea of publishing the thing to the public before I have it reviewed by people from AMQP working group. Something like: send them so/dll, collect the comments, incorporate them into the product, submit it to Wireshark. If that's not possi

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Jaap Keuter
Hi, I don't understand. Do you want to share the object/DLL, or the complete WS source code, or create a patch? Or are you worried about distribution in the GPL sense? Thanx, Jaap On Thu, 22 Mar 2007, Martin Sustrik wrote: > Hi, > > The question I've actually wanted to ask was: "Is there a way

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Martin Sustrik
Hi, The question I've actually wanted to ask was: "Is there a way to distribute plugin dissectors separately from the Wireshark codebase?" The idea being that we review the plugin internally in AMQP working group before submitting it to you. Thanks. Martin ronnie sahlberg wrote: > For inclusio

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread ronnie sahlberg
For inclusion into mainline wireshark, please send the patch to the list for revies (unless it is very large in case a url is better) also please provide a few example captures that we can use to test the dissector with. On 3/21/07, Martin Sustrik <[EMAIL PROTECTED]> wrote: > Hi all, > > I've w

Re: [Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Jaap Keuter
Hi, Send it to list (if not too big) or open a bugzilla item for it. We'll have a look. If it doesn't break stuff, it should be fine. Have a look in the developer guide and Wiki about submitting patches. Thanx, Jaap On Wed, 21 Mar 2007, Martin Sustrik wrote: > Hi all, > > I've written dissector

[Wireshark-dev] AMQP dissector - alpha version

2007-03-21 Thread Martin Sustrik
Hi all, I've written dissector for AMQP protocol (www.amqp.org). It's in alpha version and I would like to distribute it among AMQP working group members to get comments/suggestions. Do you think it is appropriate to incorporate alpha version into Wireshark codebase? Or is there some other pr