Re: [Wireshark-dev] Actualize kafka dissector

2016-11-15 Thread Martin Mathieson
ireshark does have a ptvcursor API that can save you some of the "standard" >>> function parameters, but based on your example, I don't think it'll help >>> that much. >>> >>> >>> >>> -Original Message- >>> From: Dmitry Lazur

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-15 Thread Jaap Keuter
> On 15 Nov 2016, at 18:05, Dmitry Lazurkin wrote: > > > How to test kafka dissector? Catch real kafka session? Randpkt? Unit-tests? > Test by collecting real kafka sessions and work with fuzz-test.sh Thanks, Jaap

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-15 Thread Dmitry Lazurkin
an save you some of the "standard" >> function parameters, but based on your example, I don't think it'll help >> that much. >> >> >> >> -Original Message- >> From: Dmitry Lazurkin <dila...@gmail.com> >> To: Developer support li

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-15 Thread Martin Mathieson
r example, I don't think it'll help > that much. > > > > -Original Message- > From: Dmitry Lazurkin <dila...@gmail.com> > To: Developer support list for Wireshark <wireshark-dev@wireshark.org> > Sent: Mon, Nov 14, 2016 6:04 pm > Subject: Re: [Wireshark-

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-14 Thread Dmitry Lazurkin
Second question about using "API version" value in dissect functions. This value may change parsing of packet. For now it passed as argument to some dissect functions. But for now it used only in root dissect function of request/response type (not passed to nested functions). I have next

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-14 Thread Jaap Keuter
On 14-11-16 21:50, Dmitry Lazurkin wrote: >> Sure you may. > Thanks. > > Ok, i have some questions. > > First questions about supported and unsupported packet versions. > Kafka packets have "API Version" field. I will try to show problem with > example. > Latest version of kafka server supports

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-14 Thread Dmitry Lazurkin
Sure you may. Thanks. Ok, i have some questions. First questions about supported and unsupported packet versions. Kafka packets have "API Version" field. I will try to show problem with example. Latest version of kafka server supports Produce Request/Response of version 0, 1, 2. Dissector

Re: [Wireshark-dev] Actualize kafka dissector

2016-11-13 Thread Jaap Keuter
On 11-11-16 22:13, Dmitry Lazurkin wrote: > Hello. > > I try to investigate kafka. For now kafka dissector supports only main > requests/responses and does not support it actual versions. I want to > actualize > dissector. May i do this task? > Sure you may. I would suggest first creating a

[Wireshark-dev] Actualize kafka dissector

2016-11-11 Thread Dmitry Lazurkin
Hello. I try to investigate kafka. For now kafka dissector supports only main requests/responses and does not support it actual versions. I want to actualize dissector. May i do this task? ___ Sent via:Wireshark-dev