Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-19 Thread Dr. Matthias St. Pierre
upport list for Wireshark mailto:wireshark-dev@wireshark.org>> Subject: Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed? Hi, yep, RHEL7 is still widely used, sadly :/ I have been correcting this ifdef a couple of times now.. https://gitlab.com/wireshark/wireshark/-/co

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-18 Thread Joakim
Hi, yep, RHEL7 is still widely used, sadly :/ I have been correcting this ifdef a couple of times now.. https://gitlab.com/wireshark/wireshark/-/commits/master?search=LIBGCRYPT_AEAD This since my dev env has not yet seen the light of RHEL8 //Joakim On Mon, 12 Jul 2021 at 19:43, Dr. Matthias St.

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread Dr. Matthias St. Pierre
> The minimum version being stuck at 1.5.0 is, I believe, almost entirely due > to RHEL/CentOS 7 being stuck at 1.5.3 > (https://gitlab.com/wireshark/wireshark/-/wikis/Development/Support_library_version_tracking#libgcrypt) > It's a widely used enough distribution, still scheduled for 3 more yea

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread Dr. Matthias St. Pierre
> If some changes were done to fix the compilation, it means that some people > still use a libgcrypt version older than 1.6.0. > And as seen in our CMakeLists.txt file, the minimum version required for now > is 1.5.0. I understand your reluctancy to upgrade the requirements, but don’t you think

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread John Thacker
On Tue, Jul 13, 2021 at 2:26 AM Pascal Quantin wrote: > Hi Matthias, > > Le lun. 12 juil. 2021 à 21:22, Dr. Matthias St. Pierre < > matthias.st.pie...@ncp-e.com> a écrit : > >> Hi all, >> >> in wsgcrypt.h the libgcrypt version is checked to ensure that it supports >> AEAD ciphers: >> >> #

Re: [Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread Pascal Quantin
Hi Matthias, Le lun. 12 juil. 2021 à 21:22, Dr. Matthias St. Pierre < matthias.st.pie...@ncp-e.com> a écrit : > Hi all, > > in wsgcrypt.h the libgcrypt version is checked to ensure that it supports > AEAD ciphers: > > #if GCRYPT_VERSION_NUMBER >= 0x010600 /* 1.6.0 */ > /* Whether

[Wireshark-dev] Can the legacy HAVE_LIBGCRYPT_AEAD check be removed?

2021-07-12 Thread Dr. Matthias St. Pierre
Hi all, in wsgcrypt.h the libgcrypt version is checked to ensure that it supports AEAD ciphers: #if GCRYPT_VERSION_NUMBER >= 0x010600 /* 1.6.0 */ /* Whether to provide support for authentication in addition to decryption. */ #define HAVE_LIBGCRYPT_AEAD #endif