Re: [Wireshark-dev] Current 'pre-commit' issues

2014-08-06 Thread Alexis La Goutte
On Tue, Jul 22, 2014 at 10:10 PM, Jeff Morriss jeff.morriss...@gmail.com wrote: On 07/11/14 12:42, Bill Meier wrote: I've been working with the current 'pre-commit' and have noticed the following issues: [...] 1. For the above reasons, I propose that pre-commit only do checkAPIs,

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-22 Thread Jeff Morriss
On 07/11/14 12:42, Bill Meier wrote: I've been working with the current 'pre-commit' and have noticed the following issues: [...] 1. For the above reasons, I propose that pre-commit only do checkAPIs, checkhf and fix-encoding-args for dissector files (to be determined in a rather ugly

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-13 Thread Alexis La Goutte
Hi Bill, On Fri, Jul 11, 2014 at 6:42 PM, Bill Meier wme...@newsguy.com wrote: I've been working with the current 'pre-commit' and have noticed the following issues: at origin, pre-commit script is personnal script to easy launch some check tools ;-) and there is a lot of issue... 1. Using

[Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Bill Meier
I've been working with the current 'pre-commit' and have noticed the following issues: 1. Using the current pre-commit which calls checkAPIs, etc, it doesn't seem possible to make changes to certain files (e.g., wsgetopt.c) and submit them to Gerrit. - The files fail checkAPIs.pl

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wme...@newsguy.com wrote: I've been working with the current 'pre-commit' and have noticed the following issues: 1. Using the current pre-commit which calls checkAPIs, etc, it doesn't seem possible to make changes to certain files (e.g.,

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Evan Huus
On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wme...@newsguy.com wrote: I've been working with the current 'pre-commit' and have noticed the following issues: 1. Using the current pre-commit which calls checkAPIs, etc, it doesn't seem possible to make changes to certain files (e.g.,

Re: [Wireshark-dev] Current 'pre-commit' issues

2014-07-11 Thread Bill Meier
On 7/11/2014 3:09 PM, Evan Huus wrote: On Fri, Jul 11, 2014 at 12:42 PM, Bill Meier wme...@newsguy.com When you try and push a change to gerrit without a Commit-ID, the error message it returns includes the Commit-ID it's expecting, so you can manually git commit --amend and paste that into the