Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-26 Thread Graham Bloice
FWIW, git review worked for me on Windows, however I can't remember if I branched my repo myself or added the branch name to the git review command. I think it was the former. I also used the open stack Gerrit Workflow ( https://wiki.openstack.org/wiki/Gerrit_Workflow) as a guide, I think we need

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 03:02:24PM -0800, Gerald Combs wrote: > You should be able to run something like > > ssh code.wireshark.org gerrit review --submit --code-review +2 \ > > > although I haven't tried it myself. OK, a few attempts later I've done this successfully with the following com

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Gerald Combs
On 2/25/14 2:42 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote: >> It sets up so that "git review" does the correct push, as well as >> setting the gerrit topic to the current branch name (if different from >> "master") and a few other conveniences. So there's no

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 5:42 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote: >> It sets up so that "git review" does the correct push, as well as >> setting the gerrit topic to the current branch name (if different from >> "master") and a few other conveniences.

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 05:01:55PM -0500, Evan Huus wrote: > It sets up so that "git review" does the correct push, as well as > setting the gerrit topic to the current branch name (if different from > "master") and a few other conveniences. So there's no particular > reason to set up git push. Thi

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 02:26:52PM -0800, Gerald Combs wrote: > On 2/25/14 10:39 AM, Joerg Mayer wrote: > > > > Once I've finished cloning the repo (somehow it's not my day: git clone > > is an atomic operation and I'm behind an unstable Wireless connection), > > how do I proceed? Is there a wiki p

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Gerald Combs
On 2/25/14 10:39 AM, Joerg Mayer wrote: > > Once I've finished cloning the repo (somehow it's not my day: git clone > is an atomic operation and I'm behind an unstable Wireless connection), > how do I proceed? Is there a wiki page that I can follow to set all > the required and recommented git vari

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Hadriel Kaplan
On Feb 25, 2014, at 4:57 PM, Joerg Mayer wrote: > I just did that, and received the following message during push: > jmayer@egg:~/work/wireshark/git/ui/qt(master)> git push I believe you're supposed to do 'git review branchname', which does the 'git push' for you and probably appends the "bran

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Pascal Quantin
2014-02-25 22:57 GMT+01:00 Joerg Mayer : > On Tue, Feb 25, 2014 at 01:48:22PM -0500, Evan Huus wrote: > > On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: > > > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: > > >> I haven't found anything obvious in the server logs that would e

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 4:57 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 01:48:22PM -0500, Evan Huus wrote: >> On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: >> > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: >> >> I haven't found anything obvious in the server logs that

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 01:48:22PM -0500, Evan Huus wrote: > On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: > > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: > >> I haven't found anything obvious in the server logs that would explain > >> the error, unfortunately. > >> > >> Si

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 1:39 PM, Joerg Mayer wrote: > On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: >> I haven't found anything obvious in the server logs that would explain >> the error, unfortunately. >> >> Since you were able to add your SSH key, does >> >> ssh your.usern...@cod

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Feb 25, 2014 at 10:09:43AM -0800, Gerald Combs wrote: > I haven't found anything obvious in the server logs that would explain > the error, unfortunately. > > Since you were able to add your SSH key, does > > ssh your.usern...@code.wireshark.org:29418 gerrit --help I had to use ssh jma..

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Gerald Combs
On 2/25/14 9:20 AM, Evan Huus wrote: > On Tue, Feb 25, 2014 at 12:13 PM, Joerg Mayer wrote: >> On Tue, Jan 28, 2014 at 02:51:19PM +0100, Joerg Mayer wrote: >>> On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: It is in the upper right corner. The links are pretty small. You

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Evan Huus
On Tue, Feb 25, 2014 at 12:13 PM, Joerg Mayer wrote: > On Tue, Jan 28, 2014 at 02:51:19PM +0100, Joerg Mayer wrote: >> On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: >> > It is in the upper right corner. >> > The links are pretty small. You are not the first who missed them. :-) >>

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-02-25 Thread Joerg Mayer
On Tue, Jan 28, 2014 at 02:51:19PM +0100, Joerg Mayer wrote: > On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: > > It is in the upper right corner. > > The links are pretty small. You are not the first who missed them. :-) > > Can you please provide the URL? If the URL is > https://

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-30 Thread Bálint Réczey
2014-01-30 Gerald Combs : > On 1/28/14 5:57 AM, Bálint Réczey wrote: >> Hi, >> >> 2014-01-28 Joerg Mayer : >>> On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: It is in the upper right corner. The links are pretty small. You are not the first who missed them. :-) >>> >>> Can

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-29 Thread Hadriel Kaplan
Is anyone else having problems with git pushing and the Change-Id? I’ve successfully used it once for pushing, after figuring out to download the commit-msg hook and re-doing my commit. But trying to push two other commits keeps getting the dreaded "ERROR: missing Change-Id in commit message fo

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Bálint Réczey
Hi, 2014-01-28 Joerg Mayer : > On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: >> It is in the upper right corner. >> The links are pretty small. You are not the first who missed them. :-) > > Can you please provide the URL? If the URL is > https://code.wireshark.org/review/login/re

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Joerg Mayer
On Tue, Jan 28, 2014 at 01:14:50PM +0100, Bálint Réczey wrote: > It is in the upper right corner. > The links are pretty small. You are not the first who missed them. :-) Can you please provide the URL? If the URL is https://code.wireshark.org/review/login/register/q/status:open,n,z then I've foun

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Bálint Réczey
Hi Jörg, It is in the upper right corner. The links are pretty small. You are not the first who missed them. :-) Cheers, Balint 2014-01-28 Joerg Mayer : > Looks like I'm blind. Where do I create the account? > > Thanks > Jörg > > On Tue, Jan 14, 2014 at 09:28:08PM -0500, Evan Huus wrote: >>

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-28 Thread Joerg Mayer
Looks like I'm blind. Where do I create the account? Thanks Jörg On Tue, Jan 14, 2014 at 09:28:08PM -0500, Evan Huus wrote: > I have created an account and added an SSH key, but I am getting > "Permission denied (publickey)" when trying to clone. Is it working > for anyone else? > > On Tue,

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-22 Thread Gerald Combs
On 1/14/14 1:50 PM, Gerald Combs wrote: > When should we schedule flag day? Is two weeks from now (Jan 28) too > soon? I don't want to stretch the migration out too long but I also want > to give everyone time to get set up and settled in. No one has objected so far so I'm still planning on migra

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-15 Thread Gerald Combs
On 1/15/14 3:58 AM, Bálint Réczey wrote: > Hi Evan, > > 2014/1/15 Evan Huus : >> I have created an account and added an SSH key, but I am getting >> "Permission denied (publickey)" when trying to clone. Is it working >> for anyone else? > After I set my username, it worked fine. Maybe you missed i

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-15 Thread Evan Huus
Thanks Balint, username was the problem. I swear I'd set one when I first created the account but I guess not. Cheers, Evan On Wed, Jan 15, 2014 at 6:58 AM, Bálint Réczey wrote: > Hi Evan, > > 2014/1/15 Evan Huus : >> I have created an account and added an SSH key, but I am getting >> "Permissio

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-15 Thread Bálint Réczey
Hi Evan, 2014/1/15 Evan Huus : > I have created an account and added an SSH key, but I am getting > "Permission denied (publickey)" when trying to clone. Is it working > for anyone else? After I set my username, it worked fine. Maybe you missed it like me for the first time. :-) > > On Tue, Jan 1

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-14 Thread Lori Jakab
On 01/15/2014 04:28 AM, Evan Huus wrote: > I have created an account and added an SSH key, but I am getting > "Permission denied (publickey)" when trying to clone. Is it working > for anyone else? I just checked the SSH and HTTPS methods with username and they both worked for me. -Lori > > On Tu

Re: [Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-14 Thread Evan Huus
I have created an account and added an SSH key, but I am getting "Permission denied (publickey)" when trying to clone. Is it working for anyone else? On Tue, Jan 14, 2014 at 4:50 PM, Gerald Combs wrote: > The live Gerrit site is up and running at > https://code.wireshark.org/review. At this point

[Wireshark-dev] Git+gerrit status update - 2014-01-14

2014-01-14 Thread Gerald Combs
The live Gerrit site is up and running at https://code.wireshark.org/review. At this point you should be able to do the following: - Create an account[1]. This includes adding SSH keys, adding OpenID identities, and setting an HTTP password. - Clone the repository anonymously or using your ID: