Re: [Wireshark-dev] Problem writing a file dissector for vwr capture files

2015-09-02 Thread Michal Labedzki
I have a plan to improve support of file-dissectors. Next step for me is change "Open" option to support both Capture (high priority) and Files-formats. Nothing new here, just add files support as captures are supported right now, something like Type in Open dialogs contains "All, All captures file

Re: [Wireshark-dev] Problem writing a file dissector for vwr capture files

2015-08-30 Thread Hadriel Kaplan
When you say "properly", you mean like so it can be submitted into master? I think the *right* thing is a much bigger change, and involves creating wiretype subtypes for each file-format reader type. But in the meantime you could wrap all your code in #ifdef so it's not normally compiled in, but wh

Re: [Wireshark-dev] Problem writing a file dissector for vwr capture files

2015-08-30 Thread Joerg Mayer
On Sun, Aug 30, 2015 at 07:53:09AM -0400, Hadriel Kaplan wrote: > Did you add the magic info into the magic_files array in > wiretap/mime_file.c? It looks like it's necessary. Ah, that was the part I was missing. Thanks! Of course now that I did look at it, it doesn't help me because the file for

Re: [Wireshark-dev] Problem writing a file dissector for vwr capture files

2015-08-30 Thread Hadriel Kaplan
Did you add the magic info into the magic_files array in wiretap/mime_file.c? It looks like it's necessary. -hadriel On Sun, Aug 30, 2015 at 4:22 AM, Joerg Mayer wrote: > Hello, > > I'm trying to write a file dissector for the IxVeriWave (.vwr) capture files > (without loosing the ability to ope

[Wireshark-dev] Problem writing a file dissector for vwr capture files

2015-08-30 Thread Joerg Mayer
Hello, I'm trying to write a file dissector for the IxVeriWave (.vwr) capture files (without loosing the ability to open said capture files normally of course) and am failing: Running "tshark -X 'read_format:MIME Files Format' -V -r testfile.vwr" (or the equivalent steps in wireshark) results in