Re: [Wireshark-dev] Should I add new commits to address review comments?

2017-07-11 Thread Pascal Quantin
Hi Richard, 2017-07-11 18:10 GMT+02:00 Richard Sharpe : > Hi folks, > > Last time I made a change I created a new commit based on review > comments and then squashed the two commits, but that caused issues. > > Is it better to simply submit the new commit or do I need to ensure I > keep the origi

Re: [Wireshark-dev] Should I add new commits to address review comments?

2017-07-11 Thread Graham Bloice
On 11 July 2017 at 17:10, Richard Sharpe wrote: > Hi folks, > > Last time I made a change I created a new commit based on review > comments and then squashed the two commits, but that caused issues. > > Is it better to simply submit the new commit or do I need to ensure I > keep the original chan

[Wireshark-dev] Should I add new commits to address review comments?

2017-07-11 Thread Richard Sharpe
Hi folks, Last time I made a change I created a new commit based on review comments and then squashed the two commits, but that caused issues. Is it better to simply submit the new commit or do I need to ensure I keep the original change-id in the commit? -- Regards, Richard Sharpe (何以解憂?唯有杜康。-