Re: [Wireshark-dev] Wierd code in m2m plugin

2007-07-30 Thread Jeff Morriss
Jaap Keuter wrote: > so this has no place in production code. Shouldn't we rip it out? +1 for that idea. :-) > Jeff Morriss wrote: >> Jaap Keuter wrote: >>> Hi, >>> >>> Can anyone tell me why this hideous hack is in the m2m plugin? >> My reading of it is that someone was re-using (in his/her

Re: [Wireshark-dev] Wierd code in m2m plugin

2007-07-27 Thread Jaap Keuter
so this has no place in production code. Shouldn't we rip it out? Thanx, Jaap Jeff Morriss wrote: > Jaap Keuter wrote: >> Hi, >> >> Can anyone tell me why this hideous hack is in the m2m plugin? > > My reading of it is that someone was re-using (in his/her personal build > of Wireshark) on

Re: [Wireshark-dev] Wierd code in m2m plugin

2007-07-27 Thread Jeff Morriss
Jaap Keuter wrote: > Hi, > > Can anyone tell me why this hideous hack is in the m2m plugin? My reading of it is that someone was re-using (in his/her personal build of Wireshark) one of the COL_* for a "Frame" column but didn't want the value put in the "FW-1 monitor if/direction" column in the

[Wireshark-dev] Wierd code in m2m plugin

2007-07-27 Thread Jaap Keuter
Hi, Can anyone tell me why this hideous hack is in the m2m plugin? > case TLV_FRAME_NUM: > /* get the frame number */ > g_frame_number = tvb_get_ntoh24( tvb, > offset ); >