Re: [Wireshark-dev] packet-camel possibly incorrect code ....

2010-01-26 Thread Anders Broman
-dev] packet-camel possibly incorrect code While fixing various gcc -Wshadow warnings I came across something which seems incorrect in packet-camel-template.c in dissect-camel_arg() (and in dissect_camel_res()). Specifically: the local variable 'opcode' seems to be set but is never us

[Wireshark-dev] packet-camel possibly incorrect code ....

2010-01-25 Thread Bill Meier
While fixing various gcc -Wshadow warnings I came across something which seems incorrect in packet-camel-template.c in dissect-camel_arg() (and in dissect_camel_res()). Specifically: the local variable 'opcode' seems to be set but is never used. There is a global variable 'opcode' so I'm suspect