[Wireshark-dev] svn r29431 doesn't look right to me.

2009-08-16 Thread didier
Hi, I'm not sure because I don't have EtherCAT captures but in plugins/ethercat/packet-ecatmb.c for example - FT_UINT8, 16, NULL, 0x0, NULL, 0x000F, 0, 0, NULL, NULL } + FT_UINT8, 16, NULL, 0x0, NULL, HFILL } Wasn't 0x000F in bitshift field a bug and the right patch something

Re: [Wireshark-dev] svn r29431 doesn't look right to me.

2009-08-16 Thread Kovarththanan Rajaratnam
Hey, Good catch. I only noticed that setting the last 5 members would have no effect so I simply replaced them with HFILL. This also looks suspicious: - FT_UINT8, 16, NULL, 0x0, NULL, 0x000F, 0, 0, NULL, NULL } + FT_UINT8, 16, NULL, 0x0F, NULL, HFILL } The base is specified as