[Wireshark-dev] text2pcap regression starting from revision 38679

2011-08-25 Thread Pascal Quantin
Hi all, since the commit for bug 1723 (done in revision 38679), I'm facing issues with text2pcap for really small packet dumps. Let's take this simple file example: 30 00 20 By executing the following command line: text2pcap.exe -q -l 162 temp.txt temp.pcap I get the following binary pcap

Re: [Wireshark-dev] text2pcap regression starting from revision 38679

2011-08-26 Thread Pascal Quantin
Hi 2011/8/25 Pascal Quantin > Hi all, > > since the commit for bug 1723 (done in revision 38679), I'm facing issues > with text2pcap for really small packet dumps. > > Let's take this simple file example: > 30 00 20 > > By executing the following command line: > text2pcap.exe -q -l 162 temp

Re: [Wireshark-dev] text2pcap regression starting from revision 38679

2011-08-26 Thread Jeff Morriss
Pascal Quantin wrote: I started looking at the code change done by Chris Maynard and it fails with my sample because it tries to compare the not present ASCII string with the HEX string (so as to avoid taking a beginning of the ASCII string as part of the HEX string, as explained in bug 1723)

Re: [Wireshark-dev] text2pcap regression starting from revision 38679

2011-08-26 Thread Chris Maynard
Pascal Quantin writes: > Hi all,since the commit for bug 1723 (done in revision 38679), I'm facing issues with text2pcap for really small packet dumps. > > I guess this is unexpected behavior and should be considered as a bug. Do you agree ? I do and have reopened bug 1723 as a result. Hopeful

Re: [Wireshark-dev] text2pcap regression starting from revision 38679

2011-08-29 Thread Pascal Quantin
Hi, 2011/8/26 Chris Maynard > Pascal Quantin writes: > > > Hi all,since the commit for bug 1723 (done in revision 38679), I'm facing > issues with text2pcap for really small packet dumps. > > > > I guess this is unexpected behavior and should be considered as a bug. Do > you > agree ? > > I do