Re: [Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-13 Thread Mikael Kanstrup
On Tue, Aug 11, 2020, 06:08 chuck c wrote: > There seems to be an extra call to dissect_dcm_tag() in Wireshark before > sop_class_uid and sop_instance_uid are needed in > dcm_export_create_object(). > > In tshark they are null so fail the test of containing data and > boilerplate values are put i

Re: [Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-10 Thread chuck c
There seems to be an extra call to dissect_dcm_tag() in Wireshark before sop_class_uid and sop_instance_uid are needed in dcm_export_create_object(). In tshark they are null so fail the test of containing data and boilerplate values are put in. This started with a question about number of exporte

Re: [Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-10 Thread chuck c
I think I muddied that waters asking about two-pass and export objects. The tshark export (with or without -2) works in versions 2.6 and 3.0. Something changed in 3.2 such that wireshark produces a good file and the tshark export doesn't match. Pretty much in over my head as to whether to look in

Re: [Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-10 Thread Guy Harris
On Aug 10, 2020, at 6:00 PM, John Thacker wrote: > On Mon, Aug 10, 2020 at 5:32 PM chuck c wrote: >> tshark --export-objects dicom is behaving differently than exporting Dicom >> objects in Wireshark. >> >> Is the "-2" option assumed to be set, observed if set or not used at all for >> export

Re: [Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-10 Thread chuck c
Thanks for the insight. Probably too early to label this a bug, but definitely a change in behavior. "Works" (may be in the eye of the beholder) in 2.6 and 3.0. Output changed in 3.1 and 3.2. On Mon, Aug 10, 2020 at 8:01 PM John Thacker wrote: > On Mon, Aug 10, 2020 at 5:32 PM chuck c wrote: >

Re: [Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-10 Thread John Thacker
On Mon, Aug 10, 2020 at 5:32 PM chuck c wrote: > tshark --export-objects dicom is behaving differently than exporting > Dicom objects in Wireshark. > > Is the "-2" option assumed to be set, observed if set or not used at all > for exporting objects with tshark? > Having implemented Export Object

[Wireshark-dev] tshark --export-objects : -2 assumed or required for two-pass ?

2020-08-10 Thread chuck c
tshark --export-objects dicom is behaving differently than exporting Dicom objects in Wireshark. Is the "-2" option assumed to be set, observed if set or not used at all for exporting objects with tshark? I think a two-pass is needed to set the is_storage flag properly which is used below: i