Re: [Wireshark-dev] ATM over Ethernet

2012-11-07 Thread Alex Bennée
On 6 November 2012 20:26, Jakub Zawadzki darkjames...@darkjames.pl wrote: Hi, On Mon, Nov 05, 2012 at 12:14:31PM +, Alex Bennee wrote: We use a fairly simple ATM over Ethernet encapsulation for linking old ATM based circuits with modern Ethernet based hardware. Googling for 0x8884 I has

Re: [Wireshark-dev] ATM over Ethernet

2012-11-06 Thread Alex Bennée
On 6 November 2012 10:13, Alex Bennée kernel-hac...@bennee.com wrote: On 5 November 2012 18:53, Guy Harris g...@alum.mit.edu wrote: On Nov 5, 2012, at 4:14 AM, Alex Bennee kernel-hac...@bennee.com wrote: No, you need to implement a dissector for your ATM-over-Ethernet encapsulation that

Re: [Wireshark-dev] ATM over Ethernet

2012-11-06 Thread Guy Harris
On Nov 6, 2012, at 9:47 AM, Alex Bennée kernel-hac...@bennee.com wrote: Ahh it makes more sense now. I've attached the re-worked patch which adds an explicit atmoe dissector which seems to work. Looks good. I'd use tvb_reported_length() rather than tvb_length() when calculating the number

Re: [Wireshark-dev] ATM over Ethernet

2012-11-06 Thread Evan Huus
On Tue, Nov 6, 2012 at 12:47 PM, Alex Bennée kernel-hac...@bennee.comwrote: On 6 November 2012 10:13, Alex Bennée kernel-hac...@bennee.com wrote: On 5 November 2012 18:53, Guy Harris g...@alum.mit.edu wrote: On Nov 5, 2012, at 4:14 AM, Alex Bennee kernel-hac...@bennee.com wrote: No, you

Re: [Wireshark-dev] ATM over Ethernet

2012-11-06 Thread Anders Broman
Evan Huus skrev 2012-11-06 19:48: On Tue, Nov 6, 2012 at 12:47 PM, Alex Bennée kernel-hac...@bennee.com mailto:kernel-hac...@bennee.com wrote: On 6 November 2012 10:13, Alex Bennée kernel-hac...@bennee.com mailto:kernel-hac...@bennee.com wrote: On 5 November 2012 18:53, Guy Harris

Re: [Wireshark-dev] ATM over Ethernet

2012-11-06 Thread Jakub Zawadzki
Hi, On Mon, Nov 05, 2012 at 12:14:31PM +, Alex Bennee wrote: We use a fairly simple ATM over Ethernet encapsulation for linking old ATM based circuits with modern Ethernet based hardware. Googling for 0x8884 I has found that it's already defined as ETH_P_ATMFATE (full name: Frame-based ATM

[Wireshark-dev] ATM over Ethernet

2012-11-05 Thread Alex Bennee
Hi, We use a fairly simple ATM over Ethernet encapsulation for linking old ATM based circuits with modern Ethernet based hardware. I was able to enable the packet-atm.c to decde these frames very easily (see attached) but I was looking for pointers for the next bit. Currently I can't see a way