Thanks, Indeed there was a problem with that line, and with the others. It looks like WIX does not know how to look into a merge module created with InstallShield to see what is in there so the custom action always failed. I had to point the custom action to a binary file that is created at compile time by WIX and use a standard custom action. The code gets a little weird but it works without any problems.
-----Original Message----- From: Rob Mensching [mailto:r...@robmensching.com] Sent: Thursday, December 03, 2009 7:28 AM To: General discussion for Windows Installer XML toolset. Subject: [SPAM] - Re: [WiX-users] Custom Action From Merge Module - Email found in subject Hmm, this line is very confusing to me: <CustomAction Id="Run_CustomAction.DDD8E6B5_8ADA_481F_B19D_55E2FFFAE621" Property="CustomAction.DDD8E6B5_8ADA_481F_B19D_55E2FFFAE621" Error="Merge Module Custom Action Failed" Return="check"/> I don't know what that would do. Maybe it will try to set the value of a Property to nothing or maybe it'll show an Error message. I'm a little surprised it compiles. I'm so confused I'm not sure what to suggest. On Fri, Nov 20, 2009 at 8:36 AM, Adrian Faciu <adrian.fa...@iqstorm.com>wrote: > Hi and thanks for reading this, > > I have a Merge Module, developed with InstallShiled, which i include > in my WIX project. The merge module has a custom action that calls a > function from a certain C# library, included in the merge module, to > add some entries to the registry. The problem is that in the log i can > see the custom action being executed but i'm pretty sure that the > function is not called since nothing happens. > > The log sais just that: > Action ended 18:02:11: > Run_CustomAction.DDD8E6B5_8ADA_481F_B19D_55E2FFFAE621. Return value 1. > and no other adition info. > > I found no official info about how to use custom actions from within > merge module. > > Here's a piece from my code: > <CustomAction Id="Run_CustomAction.DDD8E6B5_8ADA_481F_B19D_55E2FFFAE621" > Property="CustomAction.DDD8E6B5_8ADA_481F_B19D_55E2FFFAE621" > Error="Merge Module Custom Action Failed" Return="check"/> > > <InstallExecuteSequence> > > <Custom > Action="Run_CustomAction.DDD8E6B5_8ADA_481F_B19D_55E2FFFAE621" > After="RegisterProduct" Overridable="no"/> > > </InstallExecuteSequence> > > Where CustomAction is the name of the custom action and > DDD8E6B5_8ADA_481F_B19D_55E2FFFAE621 is the GUID of the merge module > that i'm using. > I really hope that someone could help me since i'm just beginning to > work with WIX. > > Thanks, > > Adrian Faciu > <http://www.iqstorm.com/> > > ---------------------------------------------------------------------- > -------- Let Crystal Reports handle the reporting - Free Crystal > Reports 2008 30-Day trial. Simplify your report design, integration > and deployment - and focus on what you do best, core application > coding. Discover what's new with Crystal Reports now. > http://p.sf.net/sfu/bobj-july > _______________________________________________ > WiX-users mailing list > WiX-users@lists.sourceforge.net > https://lists.sourceforge.net/lists/listinfo/wix-users > > -- virtually, Rob Mensching - http://RobMensching.com LLC ------------------------------------------------------------------------ ------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users orge.net/lists/listinfo/wix-users ------------------------------------------------------------------------------ Join us December 9, 2009 for the Red Hat Virtual Experience, a free event focused on virtualization and cloud computing. Attend in-depth sessions from your desk. Your couch. Anywhere. http://p.sf.net/sfu/redhat-sfdev2dev _______________________________________________ WiX-users mailing list WiX-users@lists.sourceforge.net https://lists.sourceforge.net/lists/listinfo/wix-users