Re: Patch: Partial support for partial struts

2012-10-31 Thread BALATON Zoltan
On Wed, 31 Oct 2012, Carlos R. Mafra wrote: My first impression is that wArrangeIcons() should be called when appicons are removed (because they can leave a hole). But when they are created, why do we care? Aren't they simply supposed to be appended (eg to the right) of the existing appicons?

[PATCH 1/9] Removed dup code at get_default_image

2012-10-31 Thread kix
From: Rodolfo García Peñas (kix) k...@kix.es This patch removes the code dup at get_default_image. Now, this function calls get_rimage_from_file() --- src/icon.c | 16 +--- 1 file changed, 5 insertions(+), 11 deletions(-) diff --git a/src/icon.c b/src/icon.c index b4ccfc5..da93679

[PATCH 3/9] wIconChangeImageFile removed dup code

2012-10-31 Thread kix
From: Rodolfo García Peñas (kix) k...@kix.es This patch removes the dup code with get_rimage_from_file. --- src/icon.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/src/icon.c b/src/icon.c index 94d9567..0b95df2 100644 --- a/src/icon.c +++ b/src/icon.c

[PATCH 2/9] wIconChangeImageFile don't update without file

2012-10-31 Thread kix
From: Rodolfo García Peñas (kix) k...@kix.es The function wIconChangeImageFile mustn't update the icon if no file is set. This is a bug. To reproduce it: 1. Right click on dock icon. Select Settings 2. Erase the Icon Image contents (set empty) 3. Click OK - Exit, no changes... no? 4. Right

[PATCH 6/9] CachedPixmaps added as pixmap folder

2012-10-31 Thread kix
From: Rodolfo García Peñas (kix) k...@kix.es The CachedPixmap folder is added to the icon list. This is because if one icon is created, but the user change it and set other icon, the first icon cannot be selected anymore using the settings window. The user needs modify the configuration files by

[PATCH 5/9] wIconChangeImageFile non negated value

2012-10-31 Thread kix
From: Rodolfo García Peñas (kix) k...@kix.es The flag (declared as int, not Bool) error was negated in the return sentences because is set to 1 when error. Is better set a positive flag, like ok_flag (declared as Boolean, like the function returned value) and set to False when error is found. The

[PATCH 7/9] getSize returns XGetGeometry exit

2012-10-31 Thread kix
From: Rodolfo García Peñas (kix) k...@kix.es The function getSize now returns the returned value by XGetGeometry. The function now is not INLINE. --- src/icon.c |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/icon.c b/src/icon.c index cb69b00..448332a 100644 ---

Re: Help with Atom (window/icon titles)

2012-10-31 Thread Rodolfo García Peñas
On Thu, 01 Nov 2012, Rodolfo kix Garcia escribió: Hi, I need help with Atoms. Now the windows are using wNETWMGetWindowName(Window*) to set the window title (see window.c), but Icons are using wNETWMGetIconName(Window*) to set the icon title. Yes, icon titles are different between the