Re: wmaker advancements and enhancements [was: Replace and be replaced]

On Sun, 01 Sep 2013, Carlos R. Mafra escribió: > On Sun, 1 Sep 2013 at 21:56:40 +0200, Yaroslav Fedevych wrote: > > On Sun, 2013-09-01 at 20:54 +0100, Carlos R. Mafra wrote: > > > On Sun, 1 Sep 2013 at 21:23:02 +0200, Yaroslav Fedevych wrote: > > > > On Sun, 2013-09-01 at 19:22 +0100, Carlos R.

Re: wmaker advancements and enhancements [was: Replace and be replaced]

On Sun, 01 Sep 2013, Yaroslav Fedevych escribió: > On Sun, 2013-09-01 at 13:54 +0200, Paul Seelig wrote: > > The other thing is that WINGs theming is severely limited, if not even > > simply broken when trying to integrate it with applications using other > > widget sets like gtk+ and qt. The latt

[PATCH 20/22] Removed unused WScreen variable in wIsADrawer

From: "Rodolfo García Peñas (kix)" The function wIsADrawer() doesn't use the argument WScreen, so can be removed. --- src/dock.c | 10 +- src/dock.h |2 +- src/dockedapp.c |2 +- 3 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/dock.c b/src/dock.c in

[PATCH 03/22] Removed optimize_for_speed flag

From: "Rodolfo García Peñas (kix)" The optimize_for_speed was used to set the Alpha channel for jpeg. The alpha channel for jpeg should be used always. The current CPUs/GPUs can do it without problems and this is an old behaviour. --- wrlib/context.c |8 wrlib/jpeg.c| 28 +

[PATCH 21/22] Variable clip_icon moved to wks_nfo

From: "Rodolfo García Peñas (kix)" The variable clip_icon, that contains the Clip appicon is moved to the global workspace properties. Now the screen is not needed to know the clip_icon. --- src/balloon.c |4 ++-- src/defaults.c |2 +- src/dock.c | 48 -

[PATCH 10/22] removeAppIconFor helper WAppIcon variable

From: "Rodolfo García Peñas (kix)" The variable aicon is used to have shorter lines. This patch also removes an extra curly bracket. --- src/appicon.c | 49 +++-- 1 file changed, 27 insertions(+), 22 deletions(-) diff --git a/src/appicon.c b/src/ap

[PATCH 08/22] wIconChangeImageFile returns rigth values

From: "Rodolfo García Peñas (kix)" The function wIconChangeImageFile now returns True when finish ok and the function can change the icon image. If something fails, then returns False. --- src/appicon.c |2 +- src/dockedapp.c |2 +- src/icon.c | 33 +++--

[PATCH 16/22] Variable workspace_menu moved to wks_nfo

From: "Rodolfo García Peñas (kix)" The variable workspace_menu, that contains the workspace_menu is moved to the global workspace properties. Now the screen is not needed to know the workspace_menu. This variable is moved to the wks_nfo struct because is related to the workspace system, and not

[PATCH 19/22] AppIcon list moved out of WScreen

From: "Rodolfo García Peñas (kix)" The appicon list is moved out of WScreen. The reason is because the appicon list is used to create and remove icons (appicons, dock, clip,...) on the screen, but these icons are not associated with the WScreen. These icons are associated with the Workspace. If

[PATCH 09/22] Removed function get_rimage_from_file

From: "Rodolfo García Peñas (kix)" This patch removes the function get_rimage_from_file. The code of this function is moved to the functions where is called. I removed the function because the code inside make things dup, like if variables are NULL, warning messages,... Function get_default_ima

[PATCH 02/22] gif.c code style

From: "Rodolfo García Peñas (kix)" This patch removes some extra curly brackets, some empty lines, extra spaces,... This patch is not removing the goto calls. I am not sure if the code is better without gotos. --- wrlib/gif.c | 51 ++- 1 file ch

[PATCH 04/22] Removed context argument in jpeg files

From: "Rodolfo García Peñas (kix)" The context argumetn is now not used, so can be removed. --- wrlib/imgformat.h |2 +- wrlib/jpeg.c |2 +- wrlib/load.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/wrlib/imgformat.h b/wrlib/imgformat.h index c7e402

[PATCH 06/22] wApplicationExtractDirPackIcon doesn't use WScreen

From: "Rodolfo García Peñas (kix)" The function wApplicationExtractDirPackIcon now doesn't need the argument WScreen, so can be removed. --- src/appicon.c |2 +- src/appicon.h |2 +- src/wdefaults.c |2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/src/appicon

[PATCH 05/22] supports_tiff moved to wPreferences

From: "Rodolfo García Peñas (kix)" The flag "supports_tiff" doesn't belong to the wScreen, because all screens has (or not) the same value. If wmaker supports (or not) tiff files is global to all wmaker, not to the screens. --- src/WindowMaker.h |1 + src/appicon.c |2 +- src/screen.

[PATCH 13/22] Variable last_workspace moved to wks_nfo

From: "Rodolfo García Peñas (kix)" The variable last_workspace, that contains the last used workspace is moved to the global workspace properties. Now the screen is not needed to know the workspace_count. The variable name is changed to last_used_workspace because this variable name is also in

[PATCH 07/22] get_icon_filename doesn't use WScreen

From: "Rodolfo García Peñas (kix)" The function get_icon_filename now doesn't need the argument WScreen, so can be removed. --- src/defaults.h |2 +- src/dialog.c|2 +- src/icon.c |2 +- src/wdefaults.c |6 +++--- 4 files changed, 6 insertions(+), 6 deletions(-) diff -

[PATCH 14/22] Variable current_workspace moved to wks_nfo

From: "Rodolfo García Peñas (kix)" The variable current_workspace, that contains the last used workspace is moved to the global workspace properties. Now the screen is not needed to know the workspace_count. --- src/actions.c | 41 + src/appicon.c

[PATCH 11/22] New struct wks_nfo

From: "Rodolfo García Peñas (kix)" The new struct wks_nfo includes the global information for the workspaces. All information related with the workspaces should be included here. The first variable moved is workspace_name_font, included in this patch. This variable was included in the screen inf

[PATCH 15/22] Variable workspaces moved to wks_nfo

From: "Rodolfo García Peñas (kix)" The variable workspaces, that contains the list of workspaces is moved to the global workspace properties. Now the screen is not needed to know the workspaces. The function getWindowState() doesn't need the WScreen argument. --- src/appicon.c| 14 +-

[PATCH 17/22] Clip, Dock and Drawers menu moved to wks_info

From: "Rodolfo García Peñas (kix)" The clip, dock, workspaces and drawers menus are common for all workspaces, so they should be included in the wks_info struct. --- src/defaults.c | 12 ++-- src/dock.c | 51 ++- src/screen.h|

[PATCH 18/22] Removed WScreen args not used

From: "Rodolfo García Peñas (kix)" The WScreen arguments in the functions wWorkspaceMenuUpdate() and makeMakeShortcutMenu() is not used now, so can be removed. --- src/defaults.c |4 ++-- src/dock.c |2 +- src/rootmenu.c |2 +- src/winmenu.c | 19 ++- src/w

[PATCH 12/22] Variable workspace_count moved to wks_nfo

From: "Rodolfo García Peñas (kix)" The variable workspace_count, that contains the number of workspaces is moved to the global workspace properties. Now the screen is not needed to know the workspace_count. --- src/appicon.c|7 +++--- src/dock.c | 17 +++--- src/event.c

[PATCH 01/22] ppm.c code style

From: "Rodolfo García Peñas (kix)" This patch removes some extra curly brackets, some empty lines, extra spaces,... This source file had some empty if blocks. Now are removed. This patch also changes some preprocessor macros for C code. --- wrlib/ppm.c | 130 ++

[PATCH 22/22] wClipIconPaint appicon argument removed

From: "Rodolfo García Peñas (kix)" Because the wClipIconPaint() function is specific to paint the clip, it knows where is the clip (wks_nfo.clip_icon), so the argument is not needed. --- src/defaults.c |2 +- src/dock.c | 13 +++-- src/dock.h |2 +- src/dockedapp.c |

Re: wmaker advancements and enhancements [was: Replace and be replaced]

On Thu, 05 Sep 2013, Rodolfo kix Garcia escribió: > On Sun, 01 Sep 2013, Yaroslav Fedevych escribió: > > > On Sun, 2013-09-01 at 13:54 +0200, Paul Seelig wrote: > > > The other thing is that WINGs theming is severely limited, if not even > > > simply broken when trying to integrate it with applic