Re: Window Maker 0.95.6 - Maximize Regression - solved

2014-09-22 Thread David Maciejak
On Tue, Sep 23, 2014 at 6:11 AM, Carlos R. Mafra wrote: > On Tue, 23 Sep 2014 at 0:04:07 +0200, Amadeusz Sławiński wrote: >> On Mon, 22 Sep 2014 22:55:12 +0100 >> "Carlos R. Mafra" wrote: >> >> > On Mon, 22 Sep 2014 at 23:15:28 +0200, Johann Haarhoff wrote: >> > > >> > > B.T.W I have applied Ama

Re: Window Maker 0.95.6 - Maximize Regression - solved

2014-09-22 Thread Amadeusz Sławiński
On Mon, 22 Sep 2014 23:11:41 +0100 "Carlos R. Mafra" wrote: > On Tue, 23 Sep 2014 at 0:04:07 +0200, Amadeusz Sławiński wrote: > > On Mon, 22 Sep 2014 22:55:12 +0100 > > "Carlos R. Mafra" wrote: > > > > > On Mon, 22 Sep 2014 at 23:15:28 +0200, Johann Haarhoff wrote: > > > > > > > > B.T.W I hav

Re: Window Maker 0.95.6 - Maximize Regression - solved

2014-09-22 Thread Carlos R. Mafra
On Tue, 23 Sep 2014 at 0:04:07 +0200, Amadeusz Sławiński wrote: > On Mon, 22 Sep 2014 22:55:12 +0100 > "Carlos R. Mafra" wrote: > > > On Mon, 22 Sep 2014 at 23:15:28 +0200, Johann Haarhoff wrote: > > > > > > B.T.W I have applied Amadeusz Sławiński's patch from 22/09/2014 > > > 16:53, and everyt

Re: Window Maker 0.95.6 - Maximize Regression - solved

2014-09-22 Thread Amadeusz Sławiński
On Mon, 22 Sep 2014 22:55:12 +0100 "Carlos R. Mafra" wrote: > On Mon, 22 Sep 2014 at 23:15:28 +0200, Johann Haarhoff wrote: > > > > B.T.W I have applied Amadeusz Sławiński's patch from 22/09/2014 > > 16:53, and everything behaves as I expect. > > I'm glad you mentioned the patch, because I have

Re: Window Maker 0.95.6 - Maximize Regression - solved

2014-09-22 Thread Carlos R. Mafra
On Mon, 22 Sep 2014 at 23:15:28 +0200, Johann Haarhoff wrote: > > B.T.W I have applied Amadeusz Sławiński's patch from 22/09/2014 16:53, > and everything behaves as I expect. I'm glad you mentioned the patch, because I haven't seen it. It's not in my wmaker folder nor in the spam, it fell into a

Re: Window Maker 0.95.6 - Maximize Regression - solved

2014-09-22 Thread Johann Haarhoff
Hi I think I have found the issue - it has to do with this commit commit 930e59dd3142a4ceba46826183e13d67b420e3de Author: Iain Patterson Date: Fri Oct 26 11:40:55 2012 -0700 Partially support _NET_WM_STRUT_PARTIAL. I run gkrellm and didn't realize that it was set to be a dock (s

Re: [PATCH v3] NEWS: Add note about window snapping.

2014-09-22 Thread Torrance, Douglas
On 09/22/2014 12:29 PM, Haroldo Gambini Santos wrote: > Hi Doug, > > Great Feature ! > > Just one comment which I think that it can be improved: > > Apparently right now it just does windo snapping in the right/left > sides. It would be great if top/bottom maximization could be done > too. In pa

Re: [PATCH v3] NEWS: Add note about window snapping.

2014-09-22 Thread Haroldo Gambini Santos
Hi Doug, Great Feature ! Just one comment which I think that it can be improved: Apparently right now it just does windo snapping in the right/left sides. It would be great if top/bottom maximization could be done too. In particular, since my current monitor is huge, I would also love havi

[PATCH] fix maximize when dock is set 'on top' and it should be covered

2014-09-22 Thread Amadeusz Sławiński
Window Maker was not correctly maximizing windows in some cases "... do not cover dock" enabled with "Dock postion": Normal - maximizes ok Auto raise & lower - maximizes ok Keep on Top- maximizes ok "... do not cover dock" disabled with "Dock postion": Normal - max

Re: Window Maker 0.95.6 - Maximize Regression

2014-09-22 Thread Amadeusz Sławiński
On Mon, 22 Sep 2014 20:49:22 +0800 David Maciejak wrote: > On Sun, Sep 21, 2014 at 6:37 PM, Johann Haarhoff > wrote: > >>> In 0.95.6, it does not calculate the horizontal dimension for > >>> maximizing correctly (see the interference between the dock and > >>> the window in the attached "maximiz

Re: Window Maker 0.95.6 - Maximize Regression

2014-09-22 Thread Carlos R. Mafra
On Mon, 22 Sep 2014 at 20:49:22 +0800, David Maciejak wrote: > On Sun, Sep 21, 2014 at 6:37 PM, Johann Haarhoff > wrote: > >>> In 0.95.6, it does not calculate the horizontal dimension for > >>> maximizing correctly (see the interference between the dock and the > >>> window in the attached "maxi

Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.

2014-09-22 Thread Torrance, Douglas
On 09/22/2014 04:13 AM, Iain Patterson wrote: > Sounds good. We'd need to change the option heading. How about: > > "Dragging a maximized window:" > - "Like other windows" > - "Window's unmaximized geometry will be restored" > - "Window will be considered unmaximized" > - "W

Re: Window Maker 0.95.6 - Maximize Regression

2014-09-22 Thread David Maciejak
On Sun, Sep 21, 2014 at 6:37 PM, Johann Haarhoff wrote: >>> In 0.95.6, it does not calculate the horizontal dimension for >>> maximizing correctly (see the interference between the dock and the >>> window in the attached "maximizebug.png") >> >> I can confirm that with those settings firefox is ma

[repo.or.cz] wmaker-crm.git branch next updated: wmaker-0.95.6-23-gff54edb2

2014-09-22 Thread crmafra
This is an automated email from the git hooks/post-receive script. It was generated because a ref change was pushed to the repository containing the project wmaker-crm.git. The branch, next has been updated via ff54edb25ac4bfaca64981c3c1cf7a336a31fd2f (commit) from a761d7b2cd683e905

Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.

2014-09-22 Thread Yury Tarasievich
On 09/22/2014 12:13 PM, Iain Patterson wrote: ... Sounds good. We'd need to change the option heading. How about: "Dragging a maximized window:" - "Like other windows" ... This one, how about "window changes position (normal behaviour)"? Yury -- To unsubscribe, send mail t

Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.

2014-09-22 Thread Iain Patterson
Quoth Yury Tarasievich, Well, to me the "ideal" name of the option is the end result of its activation. So, respectively, "window will be considered unmaximised" and "window will not move". Sounds good. We'd need to change the option heading. How about: "Dragging a maximized window:"

Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.

2014-09-22 Thread Yury Tarasievich
On 09/22/2014 11:38 AM, Iain Patterson wrote: ... Perhaps "is prevented" would be better. "Forbidden" implies you're being naughty if you do rather than you literally can't. Well, to me the "ideal" name of the option is the end result of its activation. So, respectively, "window will be co

Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.

2014-09-22 Thread Iain Patterson
Quoth Yury Tarasievich, Why not name the 3rd option "becomes unmaximised (status/flag changed only)"? That makes sense to us developers but to an end user with no interest in this mailing list it would probably be confusing. "What status/flag does it speak of?" our hypothetical end user w

Re: [PATCH v3] NEWS: Add note about window snapping.

2014-09-22 Thread Yury Tarasievich
On 09/22/2014 10:20 AM, Iain Patterson wrote: ... Windows gives a visual hint when a window is going to snap and resize. One could argue that the hint is subtle and too slow to appear but it is there. MS developers may shoehorn their captive audience into all kinds of behaviour and get aw

Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.

2014-09-22 Thread Yury Tarasievich
On 09/22/2014 10:16 AM, Iain Patterson wrote: ... Having thought some more about it I propose that in WPrefs the setting be shown as a heading "Moving a maximized window" followed by a dropdown with three settings: "behaves normally" (current default), "restores original size" (shrink on move)

Re: [PATCH v3] NEWS: Add note about window snapping.

2014-09-22 Thread Iain Patterson
Quoth Yury Tarasievich, First, you get your window size changed *unexpectedly*. Who pays to attention to those "end boxes", really? Should one treat the half-visible "end boxes" as something, examining which is obligatory for the successful operation completion? Those boxes are just (useful) hin

Re: [PATCH 1/4] wmaker: Clear maximized flag of a maximized window when moved.

2014-09-22 Thread Iain Patterson
Quoth Yury Tarasievich, I foresee folks developing certain subconscious fear of moving the Wmaker's windows in general - what if it'll change its size? I can see the reasoning behind it and I think that Doug's suggestion of having all three possibilities is the way forward. I'd always pref