Hi,
IMO, the patch is not using the code style.
Cheers,
kix
On 04/12/2014 9:10, David Maciejak wrote:
> This patch is adding the core code needed to run the workspace pager.
>
> ---
> src/Makefile.am | 4 +-
> src/event.c | 5 +
> src/misc.c | 2 +-
> src/workspace.c | 6 +
>
Hi,
I think is better increase the REVISION number instead of the WINGS_CURRENT
when we are *adding* new functions. The new revision has backward compatibility
with previous versions of wmaker, so IMO is better hold the library version
number. We should avoid remove functions, because other app
From: Christophe CURIS
As pointed by Clang, the declaration of array was using the GNU old syntax,
not the standard C.
---
WPrefs.app/Appearance.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/WPrefs.app/Appearance.c b/WPrefs.app/Appearance.c
index 9e0e8a6..c8c
From: Christophe CURIS
The code is making use of a few of the libm functions, but it looks like
gcc adds automatically the libm dependency (either by trying to be smart or
as an inherited dependency?).
Apparently, when compiling with clang-3.5 the function 'round' still needs
the use of math lib
From: Christophe CURIS
We have a few directories with source codes that we tell configure to
prepare, but we do not actually want them built during normal operations
(tests and examples only).
However, there are some special targets brought by automake which still
need to see them, so this patch
From: Christophe CURIS
There are a few cases in which nested functions are an helpful way to write
code, as this is explained in 'script/nested-func-to-macro.sh'. However,
some compiler do not support them (like clang), so this patch proposes an
elegant solution, where developers can get the bene
From: Christophe CURIS
Hi Carlos,
This is the second try for the 2 patches sent last week following your
feedback, with a little bit more...
- patch 1 still fixes CLang compilation, but now in a way that keeps
us the good part on our side, I tried to place all the relevant info at
the right pl
