Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-17 Thread SJS
begin quoting Rodolfo kix Garcia as of Mon, Jan 16, 2012 at 09:04:45AM +0100: On 16/01/12 08:31, Rodolfo kix Garcia wrote: [chop] snprintf(buffer, DOCK_NAME_LEN -1, _(Type the name for workspace %i:), wks_no + 1); buffer[DOCK_NAME_LEN -1] = '/0'; Can help too. Surely \0 is meant and

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-17 Thread Carlos R. Mafra
On Mon, 16 Jan 2012 at 17:48:41 +, SJS wrote: And stylistically, I assert that it's clearer to write buffer[DOCK_NAME_LEN - 1] than buffer[DOCK_NAME_LEN -1] ...but that's just a pet peeve of mine, since I read -1 as being one less than zero, so -1 might as well be 5, or

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-17 Thread Rodolfo kix Garcia
On 17/01/12 18:45, Carlos R. Mafra wrote: On Mon, 16 Jan 2012 at 17:48:41 +, SJS wrote: And stylistically, I assert that it's clearer to write buffer[DOCK_NAME_LEN - 1] than buffer[DOCK_NAME_LEN -1] ...but that's just a pet peeve of mine, since I read -1 as being one less

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-17 Thread Carlos R. Mafra
On Tue, 17 Jan 2012 at 19:01:52 +0100, Rodolfo kix Garcia wrote: Ok, ok, is wrong, but... who make patches, make mistakes :-) Right, but that particular bit was clearly written directly in the email and everyone can filter this kind of irrelevant lapse. The important thing is to discuss. Your

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-16 Thread Rodolfo kix Garcia
On 16/01/12 08:31, Rodolfo kix Garcia wrote: On 16/01/12 06:56, Carlos R. Mafra wrote: On Tue, 10 Jan 2012 at 0:34:53 +0100, Rodolfo kix Garcia wrote: Why we can change the name using right click on the Clip. Why? because the clip is using the functions of WINGs. Can we change the menu

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-16 Thread Rodolfo kix Garcia
On Mon, 16 Jan 2012 12:51:50 +, Carlos R. Mafra wrote: On Mon, 16 Jan 2012 at 8:31:33 +0100, Rodolfo kix Garcia wrote: [snip] + char buffer[128]; I don't like this things, I prefer char buffer[DOCK_NAME_LEN] and set DOCK_NAME_LEN in dock.h Probably we should find if

Re: Bug#304480: wmaker: Can't enter non english letters in dialog boxes

2012-01-15 Thread Carlos R. Mafra
On Tue, 10 Jan 2012 at 0:34:53 +0100, Rodolfo kix Garcia wrote: Why we can change the name using right click on the Clip. Why? because the clip is using the functions of WINGs. Can we change the menu functions to WINGs?... probably yes, but I don't know. Probably the full code of menu