A couple of minor warnings from simple cppcheck of 2.2.1 -- neither of which
should be problematic since they are error conditions.There are, of course, a
lot more warnings with cppcheck --enable=all -- some of which look important.
de Mike W9MDB
getfile.cpp -- resource leak on fp not being closed // read header if
(fread(&desc, sizeof desc, 1, fp) < 1) return; // RIFF if (fread(type,
sizeof type, 1, fp) < 1) return; // WAVE
wsprd.c -- resource leak on buf2
buf2 = calloc(npoints,sizeof(short int)); nr=fread(buf2,2,22,fp);
//Read and ignore header nr=fread(buf2,2,npoints,fp); //Read raw data
fclose(fp); if( nr == 0 ) { fprintf(stderr, "No data in file '%s'\n",
ptr_to_infile); return 1; }
Just to show some of the warnings from --enable=all -- these 3 lines are using
string comparison against a char array instead of a C++ string so the
comparison operator for that isn't boolean.
1529:widgets/mainwindow.cpp:3104:45: warning: Comparison of a boolean
expression with an integer other than 0 or 1.
[compareBoolExpressionWithInt]1532:widgets/mainwindow.cpp:4641:60: warning:
Comparison of a boolean expression with an integer other than 0 or 1.
[compareBoolExpressionWithInt]1815:widgets/plotter.cpp:241:30: warning:
Comparison of a boolean expression with an integer other than 0 or 1.
[compareBoolExpressionWithInt]
_______________________________________________
wsjt-devel mailing list
wsjt-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/wsjt-devel
