Re: [wsjt-devel] WSPRD Directory Check Missing

2020-12-03 Thread Bill Somerville
On 02/12/2020 21:55, Rud Merriam wrote: Also, in 'readc2file' the variable definition 'char* c2file[15];' should not be pointer. It should be ' char c2file[15];'. In the later 'fread' it should be passed as an address:     nr = fread( &c2file, sizeof(char), 14, fp); The original is a pointe

Re: [wsjt-devel] WSPRD Directory Check Missing

2020-12-03 Thread Bill Somerville
On 02/12/2020 20:27, Rud Merriam wrote: I'm doing a deep look at wsprd to learn about the DSP process. In my testing I found that the directory path of the -a option is not checking if the directory exists. If the directory does not exist the program continues but silently fails to create the

Re: [wsjt-devel] WSPRD Directory Check Missing

2020-12-03 Thread Roeland Jansen
I back Rud on this: the issue though is that if something else (for whatever reason) calls wsprd, imho it should be better to handle this to be on the safe side? R. On Wed, Dec 2, 2020 at 11:05 PM Bill Somerville wrote: > On 02/12/2020 21:55, Rud Merriam wrote: > > Hi Bill, > > I realize that

Re: [wsjt-devel] WSPRD Directory Check Missing

2020-12-02 Thread Bill Somerville
On 02/12/2020 21:55, Rud Merriam wrote: Hi Bill, I realize that is the default. But if they pass in a directory there is no check if the directory exists. There should be a error in that case. One reason I'm mentioning this is I'm not sure how much wsprd code is carried over to other wjst

Re: [wsjt-devel] WSPRD Directory Check Missing

2020-12-02 Thread Rud Merriam
Hi Bill, I realize that is the default. But if they pass in a directory there is no check if the directory exists. There should be a error in that case. One reason I'm mentioning this is I'm not sure how much wsprd code is carried over to other wjst code where it could be a bigger issue. --

Re: [wsjt-devel] WSPRD Directory Check Missing

2020-12-02 Thread Bill Somerville
On 02/12/2020 20:27, Rud Merriam wrote: I'm doing a deep look at wsprd to learn about the DSP process. In my testing I found that the directory path of the -a option is not checking if the directory exists. If the directory does not exist the program continues but silently fails to create the

[wsjt-devel] WSPRD Directory Check Missing

2020-12-02 Thread Rud Merriam
I'm doing a deep look at wsprd to learn about the DSP process. In my testing I found that the directory path of the -a option is not checking if the directory exists. If the directory does not exist the program continues but silently fails to create the files that would go into the directory. I