Re: [wtp-dev] extending the jsp editor

2009-12-07 Thread Andrew Eisenberg
I tried to update the grammar for jsp (not gsp) to work with jflex 1.4.3 and hit a bit of a wall. I documented everything I've done so far here: https://bugs.eclipse.org/bugs/show_bug.cgi?id=296976 On Sun, Dec 6, 2009 at 4:44 PM, Nitin Dahyabhai wrote: > Andrew Eisenberg wrote: >> >> Well, I m

Re: [wtp-dev] extending the jsp editor

2009-12-06 Thread Nitin Dahyabhai
Andrew Eisenberg wrote: Well, I made some changes to the grammar and the skeleton file, and ran the tests. Unfortunately, the changes I made will not allow the new grammar to be compiled using the old version of jflex. Also, I have 8 tests failing. I can create a bug report and attach the new

Re: [wtp-dev] extending the jsp editor

2009-12-04 Thread Andrew Eisenberg
Well, I made some changes to the grammar and the skeleton file, and ran the tests. Unfortunately, the changes I made will not allow the new grammar to be compiled using the old version of jflex. Also, I have 8 tests failing. I can create a bug report and attach the new grammar file. On Fri, Dec

Re: [wtp-dev] extending the jsp editor

2009-12-04 Thread Nitin Dahyabhai
Andrew, They're in org.eclipse.jst.jsp.core.tests.source.JSPTokenizerTest and org.eclipse.jst.jsp.ui.tests.other.ScannerUnitTests in the org.eclipse.jst.jsp.core.tests and org.eclipse.jst.jsp.ui.tests plug-ins, respectively. :pserver:anonym...@dev.eclipse.org:/cvsroot/webtools -> sourceediting/

Re: [wtp-dev] extending the jsp editor

2009-12-04 Thread Andrew Eisenberg
Sure. That's something that I can help out with. I'll try a few things and see if I can get things working. Where are the test cases located? It looks like the naming scheme has changed. And so, the skeleton.sse file is out of date. On Fri, Dec 4, 2009 at 12:01 PM, Nitin Dahyabhai wrote: > A

Re: [wtp-dev] extending the jsp editor

2009-12-04 Thread Nitin Dahyabhai
Andrew, The archive of versions on SourceForge likely ends at 1.3.0 because 1.2.x predates its existence as a SourceForge project. We've not made it a priority to update that tokenizer's specification to be compatible with newer versions of JFlex, since as you saw it makes use of a number of i

[wtp-dev] extending the jsp editor

2009-12-04 Thread Andrew Eisenberg
Hi all, I am trying to extend the existing jsp editor so that it can be used for gsp's (grails server pages). I have been moderately successful so far. However, at this point, I need to make a small change to the grammar so that text inside of { } characters is seen as an escape to the underlyin