[x265] [PATCH] common: add CHECKED_MALLOC macro that logs malloc failures and jumps to fail label

2013-09-19 Thread Gopu Govindaswamy
# HG changeset patch # User Gopu Govindaswamy # Date 1379659509 -19800 # Node ID 03195b8c3267dee542fe12886617902b7333a202 # Parent 20d8fa0541d8cf77d52106c08022ae97f3ff5de8 common: add CHECKED_MALLOC macro that logs malloc failures and jumps to fail label diff -r 20d8fa0541d8 -r 03195b8c3267 sou

Re: [x265] [PATCH] CHECKED_MALLOC : Added X265_log if Malloc failed Report the ERROR Log message

2013-09-19 Thread Steve Borho
On Fri, Sep 20, 2013 at 1:21 AM, Gopu Govindaswamy < g...@multicorewareinc.com> wrote: > # HG changeset patch > # User Gopu Govindaswamy > # Date 1379658081 -19800 > # Node ID 8831d644fa9bb931ef52db7dd8c90e08786b36fe > # Parent 99a33fc4356a7daf3b09cd5e99687fa00e23051d > CHECKED_MALLOC : Added X2

[x265] [PATCH] CHECKED_MALLOC : Added X265_log if Malloc failed Report the ERROR Log message

2013-09-19 Thread Gopu Govindaswamy
# HG changeset patch # User Gopu Govindaswamy # Date 1379658081 -19800 # Node ID 8831d644fa9bb931ef52db7dd8c90e08786b36fe # Parent 99a33fc4356a7daf3b09cd5e99687fa00e23051d CHECKED_MALLOC : Added X265_log if Malloc failed Report the ERROR Log message diff -r 99a33fc4356a -r 8831d644fa9b source/co

[x265] [PATCH] CHECKED_MALLOC: MALLOC returned pointer validation Macro

2013-09-19 Thread Gopu Govindaswamy
# HG changeset patch # User Gopu Govindaswamy # Date 1379656736 -19800 # Node ID 99a33fc4356a7daf3b09cd5e99687fa00e23051d # Parent 20d8fa0541d8cf77d52106c08022ae97f3ff5de8 CHECKED_MALLOC: MALLOC returned pointer validation Macro diff -r 20d8fa0541d8 -r 99a33fc4356a source/common/common.h --- a/s

Re: [x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread Deepthi Devaki Akkoorath
On Thu, Sep 19, 2013 at 5:29 PM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 9/19/2013 10:42 AM, deepthidev...@multicorewareinc.com wrote: > > # HG changeset patch > > # User Deepthi Devaki > > # Date 1379582068 -19800 > > # Node ID ff0875e85a0b5a5486537036152d228cc0ded15b > > # Pa

[x265] [PATCH 4 of 4] cmake: use explicit file list for HM TLibCommon files

2013-09-19 Thread Steve Borho
# HG changeset patch # User Steve Borho # Date 1379639858 18000 # Thu Sep 19 20:17:38 2013 -0500 # Node ID 6aea8272dcd811a7e8179dc1728325381ccd79cf # Parent bd1d4bdc996e761d1cb7ac8ccbbdac9179cb7f1c cmake: use explicit file list for HM TLibCommon files diff -r bd1d4bdc996e -r 6aea8272dcd8 so

[x265] [PATCH 3 of 4] cmake: use explicit file list for HM TLibEncoder files

2013-09-19 Thread Steve Borho
# HG changeset patch # User Steve Borho # Date 1379638890 18000 # Thu Sep 19 20:01:30 2013 -0500 # Node ID bd1d4bdc996e761d1cb7ac8ccbbdac9179cb7f1c # Parent 00429bb81ef7e17247cb2d9f6b5470a7c536a9cd cmake: use explicit file list for HM TLibEncoder files This prevents issues when HM files are

[x265] [PATCH 2 of 4] common: white-space logging nit

2013-09-19 Thread Steve Borho
# HG changeset patch # User Steve Borho # Date 1379638429 18000 # Thu Sep 19 19:53:49 2013 -0500 # Node ID 00429bb81ef7e17247cb2d9f6b5470a7c536a9cd # Parent 233046035a5f678d0cfe79e52215d38502d5cd35 common: white-space logging nit diff -r 233046035a5f -r 00429bb81ef7 source/common/common.cpp

[x265] [PATCH 1 of 4] common: improve logging string for lookahead configuration - conveys more info

2013-09-19 Thread Steve Borho
# HG changeset patch # User Steve Borho # Date 1379638315 18000 # Thu Sep 19 19:51:55 2013 -0500 # Node ID 233046035a5f678d0cfe79e52215d38502d5cd35 # Parent 5c6c9c095cb8d1e0754a7a895e10d5174b7df4e2 common: improve logging string for lookahead configuration - conveys more info diff -r 5c6c9c

[x265] [PATCH 0 of 4 ] minor improvements to logging and cmake scripts

2013-09-19 Thread Steve Borho
only changes log output and makes builds more robust ___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel

Re: [x265] Collaboration with topic branches

2013-09-19 Thread Rafaël Carré
Le 19/09/2013 20:55, SF Markus Elfring a écrit : >> Some of that is for aesthetics, named branches live forever. > > I find it easier to follow parallel software developments with topic branches. > http://mercurial.selenic.com/wiki/NamedBranches > > Would you like to close any branch in the futur

[x265] [PATCH] slicetype: respect --bframes count when --b-adapt is 0

2013-09-19 Thread Steve Borho
# HG changeset patch # User Steve Borho # Date 1379622846 18000 # Thu Sep 19 15:34:06 2013 -0500 # Branch stable # Node ID 2ba6ec553f218d2b06ad803b87d6ec751fd639f7 # Parent 4c97a202510373b4df6573456ec7f7888c216063 slicetype: respect --bframes count when --b-adapt is 0 --b-adapt 0 --bframes

Re: [x265] [PATCH 0 of 2 ] bug fixes in ABR for adaptation with frame parallelism enabled.

2013-09-19 Thread Steve Borho
I've queued this series locally, with some white space and var-name nits cleaned up. Will push this in a few hours if no-one objects, because I want to make an 0.4 tag today. On Thu, Sep 19, 2013 at 1:43 PM, wrote: > > ___ > x265-devel mailing list >

Re: [x265] Collaboration with topic branches

2013-09-19 Thread SF Markus Elfring
> Some of that is for aesthetics, named branches live forever. I find it easier to follow parallel software developments with topic branches. http://mercurial.selenic.com/wiki/NamedBranches Would you like to close any branch in the future? http://mercurial.selenic.com/wiki/PruningDeadBranches >

Re: [x265] [PATCH Only Review, don't merge] Assembly routine for filterHorizontal_p_p() for 4 tap filter

2013-09-19 Thread Jason Garrett-Glaser
> +%if ARCH_X86_64 == 0 > + > +SECTION_RODATA 32 > +tab_leftmask: dq 0x > +dq 0x00FF > +dq 0x > +dq 0x00FF > +dq 0x > +dq 0x00FF > +

[x265] [PATCH 0 of 2 ] bug fixes in ABR for adaptation with frame parallelism enabled.

2013-09-19 Thread aarthi
___ x265-devel mailing list x265-devel@videolan.org https://mailman.videolan.org/listinfo/x265-devel

[x265] [PATCH 2 of 2] tuned up ABR logic to better adapt for frame parallelism

2013-09-19 Thread aarthi
# HG changeset patch # User Aarthi Thirumalai # Date 1379615875 -19800 # Fri Sep 20 00:07:55 2013 +0530 # Node ID 6832513a6e480a7b167e15f51215ea86af87c5d4 # Parent e26b439a4031dd93f8aab60f0bdddc7f4a38ae2a tuned up ABR logic to better adapt for frame parallelism Rate control needs to be more

[x265] [PATCH 1 of 2] RateControl bug fixes for frame parallelism

2013-09-19 Thread aarthi
# HG changeset patch # User Aarthi Thirumalai # Date 1379614542 -19800 # Thu Sep 19 23:45:42 2013 +0530 # Node ID e26b439a4031dd93f8aab60f0bdddc7f4a38ae2a # Parent e51ecfcabcaa373ad95b8da781501ea4fec1d482 RateControl bug fixes for frame parallelism 1. Added lastRceq in ratecotrol structure a

Re: [x265] [PATCH] do not use std;:list for the class AccessUnit

2013-09-19 Thread Steve Borho
On Thu, Sep 19, 2013 at 3:01 AM, Gopu Govindaswamy < g...@multicorewareinc.com> wrote: > # HG changeset patch > # User Gopu Govindaswamy > # Date 1379577682 -19800 > # Node ID 92e1ac03b081eccd8bc797142cc22033c87d475d > # Parent 26d6f155f8df69147f40f4945d99c29a52988c56 > do not use std;:list for

Re: [x265] Collaboration with topic branches

2013-09-19 Thread Steve Borho
On Thu, Sep 19, 2013 at 4:08 AM, SF Markus Elfring < elfr...@users.sourceforge.net> wrote: > Hello, > > I have read a bit about a "default branch" (in the document section > "Release Management"). > https://bitbucket.org/**multicoreware/x265/wiki/** > Contribute#markdown-header-**release-managemen

Re: [x265] [PATCH] slicetype: fill in missing detail from slicetypeDecide()

2013-09-19 Thread Deepthi Nandakumar
Aah, ok. makes sense. On Thu, Sep 19, 2013 at 10:08 PM, Steve Borho wrote: > > > > On Thu, Sep 19, 2013 at 4:33 AM, Deepthi Nandakumar < > deep...@multicorewareinc.com> wrote: > >> >> >> On Thu, Sep 19, 2013 at 3:35 AM, Steve Borho wrote: >> >>> # HG changeset patch >>> # User Steve Borho >>>

Re: [x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread Steve Borho
On Thu, Sep 19, 2013 at 7:02 AM, Derek Buitenhuis < derek.buitenh...@gmail.com> wrote: > On 9/19/2013 10:16 AM, Min Chen wrote: > > +// Disabled because Frame Parallelism call processRowPost early, it is > broken data. > > +// OPT("sao-lcu-opt", > param->saoLcuBasedOptimization,required_argument,

Re: [x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread Steve Borho
On Thu, Sep 19, 2013 at 2:25 AM, Deepthi Devaki Akkoorath < deepthidev...@multicorewareinc.com> wrote: > > > > On Thu, Sep 19, 2013 at 12:19 PM, Deepthi Nandakumar < > deep...@multicorewareinc.com> wrote: > >> >> >> On Thu, Sep 19, 2013 at 11:55 AM, wrote: >> >>> # HG changeset patch >>> # User De

Re: [x265] [PATCH] types: use stdint.h data types for UChar, UShort, UInt64, Pel, TCoeff

2013-09-19 Thread Jean-Baptiste Kempf
On 19 Sep, Steve Borho wrote : > I was just trying to avoid the pain of doing a global string replacement > and fixing up all the white-space alignment nits it will cause. But it > seems I can't pull that fast one past you guys :) It's just that even VS has now all the right types since the last

Re: [x265] [PATCH] types: use stdint.h data types for UChar, UShort, UInt64, Pel, TCoeff

2013-09-19 Thread Steve Borho
On Thu, Sep 19, 2013 at 6:58 AM, Jean-Baptiste Kempf wrote: > On 19 Sep, Derek Buitenhuis wrote : > > On 9/19/2013 5:18 AM, Steve Borho wrote: > > > +typedef uint8_t UChar; > > > +typedef uint16_t UShort; > > > +typedef unsigned int UInt; > > > +typedef int64_t Int64; > > > +typedef

Re: [x265] [PATCH] slicetype: fill in missing detail from slicetypeDecide()

2013-09-19 Thread Steve Borho
On Thu, Sep 19, 2013 at 4:33 AM, Deepthi Nandakumar < deep...@multicorewareinc.com> wrote: > > > On Thu, Sep 19, 2013 at 3:35 AM, Steve Borho wrote: > >> # HG changeset patch >> # User Steve Borho >> # Date 1378869992 18000 >> # Tue Sep 10 22:26:32 2013 -0500 >> # Node ID a5810b7397ddec0bbe

Re: [x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread chen
my 2 reasons: 1. turn it on may not get improvement quality or bitrate, but we need disable other acceleration feature 2. Maintain a rarely used features to be increase the workload At 2013-09-19 20:02:07,"Derek Buitenhuis" wrote: >On 9/19/2013 10:16 AM, Min Chen wrote: >> +// Disabled because

Re: [x265] [PATCH 2 of 2] Control SAO and Deblock independence

2013-09-19 Thread chen
I check code again, no more reduce checks the SAO split into three parts, one run before deblock and another after, if we disable ao-lcu-opt, we have to bypass all of SAO operators on row level, we process sao after frame finished. At 2013-09-19 20:05:11,"Derek Buitenhuis" wrote: >On 9/19/201

[x265] [PATCH Only Review, don't merge] Assembly routine for filterHorizontal_p_p() for 4 tap filter

2013-09-19 Thread praveen
# HG changeset patch # User praveen Tiwari # Date 1379594773 -19800 # Node ID 4fd7a03bc60da3138a07ea232f4e30a45af0bd4c # Parent 26d6f155f8df69147f40f4945d99c29a52988c56 Assembly routine for filterHorizontal_p_p() for 4 tap filter diff -r 26d6f155f8df -r 4fd7a03bc60d source/common/x86/ipfilter8.as

Re: [x265] [PATCH 2 of 2] Control SAO and Deblock independence

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 1:05 PM, Derek Buitenhuis wrote: > Moreover, is there perhaps a better / core flexible way to do > this, other than littering the codebase with a bunch of checks > over and over again? Perhaps properly splitting them up, if it > is possible? Sorry, typo. s/core/more/ - Derek ___

Re: [x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 1:16 PM, chen wrote: > "SAO picture-based optimization" start SAO after frame finished, so we have > to wait frame encode finished and extend border again (deblock extend once > before). > > Now, we call processRowPost after deblock row finished, it send a event to > next frame, s

Re: [x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread chen
"SAO picture-based optimization" start SAO after frame finished, so we have to wait frame encode finished and extend border again (deblock extend once before). Now, we call processRowPost after deblock row finished, it send a event to next frame, so the next frame thread get wrong pixel. In a

Re: [x265] [PATCH 2 of 2] Control SAO and Deblock independence

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 10:16 AM, Min Chen wrote: > # HG changeset patch > # User Min Chen > # Date 1379582154 -28800 > # Node ID 9860ced6859d0779769c1e9369869dcb41bcd5b5 > # Parent 434dc0ee509734c1ee57a7650b2ba02b62c5d8c6 > Control SAO and Deblock independence s/independence/independently/ Moreover, is t

Re: [x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 10:16 AM, Min Chen wrote: > +// Disabled because Frame Parallelism call processRowPost early, it is > broken data. > +// OPT("sao-lcu-opt", param->saoLcuBasedOptimization,required_argument, > 0, "0: SAO picture-based optimization, 1: SAO LCU-based optimization ") ... Why not fix

Re: [x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 10:42 AM, deepthidev...@multicorewareinc.com wrote: > # HG changeset patch > # User Deepthi Devaki > # Date 1379582068 -19800 > # Node ID ff0875e85a0b5a5486537036152d228cc0ded15b > # Parent eea9154229a0aa91da16b1323d7999cfcb1cd0b7 > lookahead: fix crash for I frame cost estimation C

Re: [x265] [PATCH] types: use stdint.h data types for UChar, UShort, UInt64, Pel, TCoeff

2013-09-19 Thread Jean-Baptiste Kempf
On 19 Sep, Derek Buitenhuis wrote : > On 9/19/2013 5:18 AM, Steve Borho wrote: > > +typedef uint8_t UChar; > > +typedef uint16_t UShort; > > +typedef unsigned int UInt; > > +typedef int64_t Int64; > > +typedef uint64_t UInt64; > > This seems quite wrong, since they're not necessa

Re: [x265] [PATCH] types: use stdint.h data types for UChar, UShort, UInt64, Pel, TCoeff

2013-09-19 Thread Derek Buitenhuis
On 9/19/2013 5:18 AM, Steve Borho wrote: > +typedef uint8_t UChar; > +typedef uint16_t UShort; > +typedef unsigned int UInt; > +typedef int64_t Int64; > +typedef uint64_t UInt64; This seems quite wrong, since they're not necessarily analogous on all platforms... like short. Why

[x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread deepthidevaki
# HG changeset patch # User Deepthi Devaki # Date 1379582068 -19800 # Node ID ff0875e85a0b5a5486537036152d228cc0ded15b # Parent eea9154229a0aa91da16b1323d7999cfcb1cd0b7 lookahead: fix crash for I frame cost estimation diff -r eea9154229a0 -r ff0875e85a0b source/encoder/slicetype.cpp --- a/source

Re: [x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread Deepthi Nandakumar
Can you try sending this as a fresh patch to the mailing list? Does not apply cleanly to the parent node. On Thu, Sep 19, 2013 at 2:46 PM, Deepthi Devaki Akkoorath < deepthidev...@multicorewareinc.com> wrote: > # HG changeset patch > # User Deepthi Devaki > # Date 1379582068 -19800 > # Node ID

Re: [x265] [PATCH] slicetype: fill in missing detail from slicetypeDecide()

2013-09-19 Thread Deepthi Nandakumar
On Thu, Sep 19, 2013 at 3:35 AM, Steve Borho wrote: > # HG changeset patch > # User Steve Borho > # Date 1378869992 18000 > # Tue Sep 10 22:26:32 2013 -0500 > # Node ID a5810b7397ddec0bbec0e885bc5e7fd9bd5a7040 > # Parent 5bab261d0dd7ac68c4af3837853d48d56017d4d6 > slicetype: fill in missing

[x265] [PATCH 2 of 2] Control SAO and Deblock independence

2013-09-19 Thread Min Chen
# HG changeset patch # User Min Chen # Date 1379582154 -28800 # Node ID 9860ced6859d0779769c1e9369869dcb41bcd5b5 # Parent 434dc0ee509734c1ee57a7650b2ba02b62c5d8c6 Control SAO and Deblock independence diff -r 434dc0ee5097 -r 9860ced6859d source/encoder/framefilter.cpp --- a/source/encoder/framefi

Re: [x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread Deepthi Devaki Akkoorath
# HG changeset patch # User Deepthi Devaki # Date 1379582068 -19800 # Node ID d52de033d7dde00255e9d55ece138c33fd61 # Parent 26d6f155f8df69147f40f4945d99c29a52988c56 lookahead: fix crash for I frame cost estimation diff -r 26d6f155f8df -r d52de033d7dd source/encoder/slicetype.cpp --- a/source

[x265] [PATCH 1 of 2] Always active sao-lcu-opt because we broken it after Frame Parallelism

2013-09-19 Thread Min Chen
# HG changeset patch # User Min Chen # Date 1379582133 -28800 # Node ID 434dc0ee509734c1ee57a7650b2ba02b62c5d8c6 # Parent 26d6f155f8df69147f40f4945d99c29a52988c56 Always active sao-lcu-opt because we broken it after Frame Parallelism diff -r 26d6f155f8df -r 434dc0ee5097 source/x265opts.h --- a/s

[x265] Collaboration with topic branches

2013-09-19 Thread SF Markus Elfring
Hello, I have read a bit about a "default branch" (in the document section "Release Management"). https://bitbucket.org/multicoreware/x265/wiki/Contribute#markdown-header-release-management How do you think about to work also with topic branches? http://git-scm.com/book/en/Git-Branching-Branchi

Re: [x265] [PATCH 5 of 5] cli: report errors from registering signal handler

2013-09-19 Thread SF Markus Elfring
+cliopt.log(X265_LOG_ERROR, "Unable to register CTRL+C handler, error %d\n", errno); How do you think about to retrieve a message text for the passed error code? Would you like to call the function "strerror" there (and similar source code places)? http://pubs.opengroup.org/onlinepu

Re: [x265] [PATCH] do not use std;:list for the class AccessUnit

2013-09-19 Thread Deepthi Nandakumar
FrameEncoder and compressFrame needs to be refactored for mallocs and failures to be handled correctly. On Thu, Sep 19, 2013 at 1:31 PM, Gopu Govindaswamy < g...@multicorewareinc.com> wrote: > # HG changeset patch > # User Gopu Govindaswamy > # Date 1379577682 -19800 > # Node ID 92e1ac03b081ecc

[x265] [PATCH] do not use std;:list for the class AccessUnit

2013-09-19 Thread Gopu Govindaswamy
# HG changeset patch # User Gopu Govindaswamy # Date 1379577682 -19800 # Node ID 92e1ac03b081eccd8bc797142cc22033c87d475d # Parent 26d6f155f8df69147f40f4945d99c29a52988c56 do not use std;:list for the class AccessUnit Removed std::list from encoder and nalunits diff -r 26d6f155f8df -r 92e1ac03b

Re: [x265] [PATCH] lookahead: fix crash for I frame cost estimation

2013-09-19 Thread Deepthi Devaki Akkoorath
On Thu, Sep 19, 2013 at 12:19 PM, Deepthi Nandakumar < deep...@multicorewareinc.com> wrote: > > > On Thu, Sep 19, 2013 at 11:55 AM, wrote: > >> # HG changeset patch >> # User Deepthi Devaki >> # Date 1379571920 -19800 >> # Node ID 93d222ec321e5eed93dc8652dc9e5248d836c436 >> # Parent 26d6f155f8df