Re: [x265] [PATCH] silence MSVC warning C4334 and GCC warnings for '-std=gnu++11'

2017-04-20 Thread Pradeep Ramachandran
On Thu, Apr 20, 2017 at 1:00 PM, Mateusz Brzostek wrote: > This patch fixes issue #329 for MSVC > and if someone wants to compile with GCC for '-std=gnu++11' instead of > default gnu++98, there will be no > f:/x265p/source/common/ipfilter.cpp:212:36: warning: left shift of > negative value [-Wshi

[x265] [PATCH] CLI: small fixes for dhdr10

2017-04-20 Thread Mateusz Brzostek
There is missing enter in '--help' with dhdr10 (and it should be TOOLOPT instead of TOOLVAL). # HG changeset patch # User Ma0 # Date 1492724724 -7200 # Thu Apr 20 23:45:24 2017 +0200 # Node ID 36996838a99ff5fa75221fde6c3a91d1b108d9d2 # Parent 2c6e6c9c3da72aaddb33565d7031918fb5a37097 CLI: s

[x265] [PATCH] cmake: set '-std=gnu++11' for GCC if ENABLE_DYNAMIC_HDR10 is on

2017-04-20 Thread Mateusz Brzostek
Current code for HDR10 needs gnu++11 for GCC at least. This patch sets '-std=gnu++11' for GCC only if ENABLE_DYNAMIC_HDR10 is set. Please review. # HG changeset patch # User Ma0 # Date 1492721872 -7200 # Thu Apr 20 22:57:52 2017 +0200 # Node ID 4fb381f7332d4efac82b55bccbbf8de78c622110 # Pa

[x265] [PATCH] silence MSVC warning C4334 and GCC warnings for '-std=gnu++11'

2017-04-20 Thread Mateusz Brzostek
This patch fixes issue #329 for MSVC and if someone wants to compile with GCC for '-std=gnu++11' instead of default gnu++98, there will be no f:/x265p/source/common/ipfilter.cpp:212:36: warning: left shift of negative value [-Wshift-negative-value] int offset = -IF_INTERNAL_OFFS << shift;

Re: [x265] Dynamic HDR10 routines don't compile in GCC 6.3.0, missing C++11 compatibility

2017-04-20 Thread Mario *LigH* Rohkrämer
Here a longer excerpt of the result of the following call (building the 12-bit depth library for a 32-bit multilib EXE, the first part in my semi-automatical build script, test version with added dynamicHDR10 support): cmake -G "MSYS Makefiles" ../../../source -DWINXP_SUPPORT=ON -DEXPORT_

Re: [x265] Dynamic HDR10 routines don't compile in GCC 6.3.0, missing C++11 compatibility

2017-04-20 Thread Mario *LigH* Rohkrämer
What more than "GCC 6.3.0" do you need to know? My build environment is based on: http://xhmikosr.1f0.de/tools/msys/ with some customized scripts based on your build/msys shell scripts. Maybe I should clean and clone freshly, not to accidently miss any changes. Or did you not try to

Re: [x265] [PATCH] compilation fix in dhdr10

2017-04-20 Thread Pradeep Ramachandran
On Thu, Apr 20, 2017 at 5:47 AM, wrote: > # HG changeset patch > # User Bhavna Hariharan > # Date 1492676577 -19800 > # Thu Apr 20 13:52:57 2017 +0530 > # Branch stable > # Node ID 4396b679ffa6a77630fff7a99b7c21852ad23592 > # Parent 6dc49dcff6da50aab6e098f35194ea1c8098db2f > compilation fi

Re: [x265] Dynamic HDR10 routines don't compile in GCC 6.3.0, missing C++11 compatibility

2017-04-20 Thread Pradeep Ramachandran
What compiler are you trying with? We have seen some warnings, but most of them are harmless. I haven't seen any errors yet though. Pradeep. On Thu, Apr 20, 2017 at 1:06 AM, Mario *LigH* Rohkrämer wrote: > When I add "-DENABLE_DYNAMIC_HDR10=ON" to my cmake calls, a huge load of > warnings and er

[x265] [PATCH] compilation fix in dhdr10

2017-04-20 Thread bhavna
# HG changeset patch # User Bhavna Hariharan # Date 1492676577 -19800 # Thu Apr 20 13:52:57 2017 +0530 # Branch stable # Node ID 4396b679ffa6a77630fff7a99b7c21852ad23592 # Parent 6dc49dcff6da50aab6e098f35194ea1c8098db2f compilation fix in dhdr10 diff -r 6dc49dcff6da -r 4396b679ffa6 source/e

[x265] Dynamic HDR10 routines don't compile in GCC 6.3.0, missing C++11 compatibility

2017-04-20 Thread Mario *LigH* Rohkrämer
When I add "-DENABLE_DYNAMIC_HDR10=ON" to my cmake calls, a huge load of warnings and errors appears. Most are related to missing compatibility with C++11. Few examples: In file included from h:/MSYS-GCC630/home/Entwicklung/x265/source/dynamicHDR10/BasicStructures.cpp:26:0: h:/MSYS-GCC630

Re: [x265] [PATCH 3 of 5] sei clean up

2017-04-20 Thread Mario *LigH* Rohkrämer
h:/MSYS-GCC630/home/Entwicklung/x265/source/encoder/sei.cpp: In member function 'void x265::SEI::write(x265::Bitstream&, const x265::SPS&)': h:/MSYS-GCC630/home/Entwicklung/x265/source/encoder/sei.cpp:51:18: warning: declaration of 'type' shadows a previous local [-Wshadow] uint32_t t