Re: [x265] [PATCH] Backed out changeset: fef63866bb60

2019-05-29 Thread Vittorio Giovara
On Wed, May 29, 2019 at 12:10 AM Pradeep Ramachandran < prad...@multicorewareinc.com> wrote: > On Mon, Apr 1, 2019 at 11:06 PM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> >> >> On Wed, Mar 13, 2019 at 11:49 AM Vittorio Giovara

Re: [x265] [PATCH] Dolby Vision: Set crQpoffset to 3 by default for profile 5 regardless of noise

2019-04-30 Thread Vittorio Giovara
On Tue, Apr 30, 2019 at 12:45 AM wrote: > # HG changeset patch > # User Aruna Matheswaran > # Date 1556597470 -19800 > # Tue Apr 30 09:41:10 2019 +0530 > # Node ID feec4bdf98663ac4a2561b63e1ccec423c7d26a4 > # Parent bac0e1acb874213d4002f47ce88d6abe2475d957 > Dolby Vision: Set crQpoffset to

Re: [x265] [PATCH] Backed out changeset: fef63866bb60

2019-04-01 Thread Vittorio Giovara
On Wed, Mar 13, 2019 at 11:49 AM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > > > On Wed, Mar 13, 2019 at 10:41 AM Pradeep Ramachandran < > prad...@multicorewareinc.com> wrote: > >> On Tue, Mar 12, 2019 at 10:21 PM Vittorio Giovara <

Re: [x265] [PATCH] Backed out changeset: fef63866bb60

2019-03-13 Thread Vittorio Giovara
On Wed, Mar 13, 2019 at 10:41 AM Pradeep Ramachandran < prad...@multicorewareinc.com> wrote: > On Tue, Mar 12, 2019 at 10:21 PM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> >> >> On Tue, Mar 12, 2019 at 12:11 PM Aruna Matheswaran

Re: [x265] [PATCH] Backed out changeset: fef63866bb60

2019-03-12 Thread Vittorio Giovara
ave been more constructive and explained my points more politely. Regards Vittorio > Thanks, > Aruna > > > On Mon, Mar 11, 2019 at 7:40 PM Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> >> >> >> On Mon, Mar 11, 2019 at 3:48 AM Prad

Re: [x265] [PATCH] Backed out changeset: fef63866bb60

2019-03-11 Thread Vittorio Giovara
On Mon, Mar 11, 2019 at 3:48 AM Pradeep Ramachandran < prad...@multicorewareinc.com> wrote: > On Mon, Mar 11, 2019 at 9:17 AM Pradeep Ramachandran < > prad...@multicorewareinc.com> wrote: > >> On Sat, Mar 9, 2019 at 2:14 AM Vittorio Giovara < >&g

Re: [x265] [PATCH] Backed out changeset: fef63866bb60

2019-03-08 Thread Vittorio Giovara
Actually just noticed that his commit is already pushed in master, with a whole 15 hours of review time. Seriously guys, this is not the way to conduct open source development. Regards, Vittorio On Fri, Mar 8, 2019 at 3:44 PM Vittorio Giovara wrote: > > > On Fri, Mar 8, 2019 at

Re: [x265] [PATCH] Backed out changeset: fef63866bb60

2019-03-08 Thread Vittorio Giovara
On Fri, Mar 8, 2019 at 12:27 AM Pradeep Ramachandran < prad...@multicorewareinc.com> wrote: > # HG changeset patch > # User Pradeep Ramachandran > # Date 1552022473 -19800 > # Fri Mar 08 10:51:13 2019 +0530 > # Node ID 636258ebc7a90e0a35466e9b605ab335b9ce2194 > # Parent 0eccd62725b6a24ae27d

[x265] bool should *not* be in a header file

2019-03-05 Thread Vittorio Giovara
Any C program including x265.h will fail to build because of this line x265_zone *x265_zone_alloc(int zoneCount, bool isZoneFile); Example output from ffmpeg BEGIN /home/koda/tc/tmp/ffconf.JBakU0BM/test.c 1#include 2#include 3long check_x265_api_get(void) { return (long

Re: [x265] unsigned promotion prevents encoding frames with negative strides

2019-01-30 Thread Vittorio Giovara
), the negative stride is invalid >>> in encoder/decoder core. >>> To avoid these invalid input parameters, the x264 insert a middle-layer >>> that convert color space and images, but x265 doesn't it. >>> >>> Of course, crash is worst way to rep

Re: [x265] [PATCH] preset: Change param defaults for veryslow and slower preset

2019-01-02 Thread Vittorio Giovara
On Thu, Dec 27, 2018 at 7:50 AM wrote: > # HG changeset patch > # User Pooja Venkatesan > # Date 1545892012 -19800 > # Thu Dec 27 11:56:52 2018 +0530 > # Node ID 3955fddb29bcb342e4b51c57dd8dece92ad06889 > # Parent 1951152ff12db320a4b626e57ee1c870d84d7f14 > preset: Change param defaults for

Re: [x265] [PATCH 1 of 2] Add support for Dolby Vision profile 8.1

2018-12-18 Thread Vittorio Giovara
On Tue, Dec 18, 2018 at 11:42 AM Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > > > On Tue, Dec 18, 2018 at 3:07 AM Kirithika Kalirathnam < > kirith...@multicorewareinc.com> wrote: > >> # HG changeset patch >> # User kirithika >> # Date 15

Re: [x265] [PATCH 1 of 2] Add support for Dolby Vision profile 8.1

2018-12-18 Thread Vittorio Giovara
On Tue, Dec 18, 2018 at 3:07 AM Kirithika Kalirathnam < kirith...@multicorewareinc.com> wrote: > # HG changeset patch > # User kirithika > # Date 1544426306 -19800 > # Mon Dec 10 12:48:26 2018 +0530 > # Node ID 827668cf88a85f8d14b8943c53e3f4c87196e96d > # Parent 81373aab81dfe2e31a5ef353b107

Re: [x265] [PATCH] added support for Dolby Vision profile 5

2018-12-12 Thread Vittorio Giovara
On Wed, Dec 12, 2018 at 6:18 AM Kalyan Goswami wrote: > pushed > Hi, you pushed the wrong version with +CHECK((param->rc.vbvMaxBitrate < 0 && param->rc.vbvBufferSize < 0), "Dolby Vision requires VBV settings to enable HRD.\n"); Aruna said the right way was with `(param->rc.vbvMaxBitrate

Re: [x265] [PATCH] added support for Dolby Vision profile 5

2018-12-10 Thread Vittorio Giovara
On Mon, Dec 10, 2018 at 4:57 AM Aruna Matheswaran < ar...@multicorewareinc.com> wrote: > # HG changeset patch > # User Praveen Tiwari > # Date 1537854295 -19800 > # Tue Sep 25 11:14:55 2018 +0530 > # Node ID 89457c901a6c41f390aef970a2936e3a5650b4f1 > # Parent f74003e88622dafc62f6c3c50720872

Re: [x265] [PATCH] encoder: Do not include CLL SEI message if empty

2018-11-07 Thread Vittorio Giovara
anks for the patch, will run some basic test and push the patch. >> >> Regards, >> Praveen >> >> >> On Wed, Nov 7, 2018 at 12:35 AM Vittorio Giovara < >> vittorio.giov...@gmail.com> wrote: >> >>> >>> >>> On T

Re: [x265] [PATCH] encoder: Do not include CLL SEI message if empty

2018-11-06 Thread Vittorio Giovara
On Thu, Nov 1, 2018 at 5:34 PM Vittorio Giovara wrote: > Some devices render out-of-luminance pixels incorrectly otherwise. > > --- > source/encoder/encoder.cpp | 11 +++ > 1 file changed, 7 insertions(+), 4 deletions(-) > > diff -r fd517ae68f93 source/encoder/encod

[x265] [PATCH] encoder: Do not include CLL SEI message if empty

2018-11-01 Thread Vittorio Giovara
Some devices render out-of-luminance pixels incorrectly otherwise. --- source/encoder/encoder.cpp | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff -r fd517ae68f93 source/encoder/encoder.cpp --- a/source/encoder/encoder.cppTue Sep 25 16:02:31 2018 +0530 +++ b/source/enco

Re: [x265] [PATCH] Fix for build error in ffmpeg

2018-07-25 Thread Vittorio Giovara
On Wed, Jul 25, 2018 at 11:00 AM, wrote: > # HG changeset patch > # User Ashok Kumar Mishra > # Date 1532498266 -19800 > # Wed Jul 25 11:27:46 2018 +0530 > # Node ID 85c222dbd0d94568fd0e55af0bae5a4a2a8ae9da > # Parent c258d214c978a5c64ec8dd3986a3b3cc3d2381ac > Fix for build error in ffmpeg

Re: [x265] API or documentation problem for tiny images

2018-05-07 Thread Vittorio Giovara
On Tue, May 1, 2018 at 2:20 PM, Vittorio Giovara wrote: > > > On Fri, Apr 27, 2018 at 2:38 PM, Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> Hi, when encoding very small videos, less than 64x64 x265 throws an error. >> >> x265 [error]

Re: [x265] API or documentation problem for tiny images

2018-05-01 Thread Vittorio Giovara
On Fri, Apr 27, 2018 at 2:38 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > Hi, when encoding very small videos, less than 64x64 x265 throws an error. > > x265 [error]: Picture size must be at least one CTU > > however the documentation clearly states that any va

[x265] API or documentation problem for tiny images

2018-04-27 Thread Vittorio Giovara
Hi, when encoding very small videos, less than 64x64 x265 throws an error. x265 [error]: Picture size must be at least one CTU however the documentation clearly states that any valid size is supported /* Width (in pixels) of the source pictures. If this width is not an even * multiple o

Re: [x265] [PATCH] Support for HLG-graded content and pic_struct

2018-04-12 Thread Vittorio Giovara
On Thu, Apr 12, 2018 at 4:49 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > > > > On Thu, Apr 12, 2018 at 1:44 PM, wrote: > >> # HG changeset patch >> # User Ashok Kumar Mishra >> # Date 1523532439 -19800 >> #

Re: [x265] [PATCH] Support for HLG-graded content and pic_struct

2018-04-12 Thread Vittorio Giovara
On Thu, Apr 12, 2018 at 1:44 PM, wrote: > # HG changeset patch > # User Ashok Kumar Mishra > # Date 1523532439 -19800 > # Thu Apr 12 16:57:19 2018 +0530 > # Node ID ace55bce0e3c6e0beb52712fd71e01025bd73a22 > # Parent 04a337abd70de269cef7d9655365f3a3ebde02aa > Support for HLG-graded content

Re: [x265] [PATCH 000 of 307 ] AVX-512 implementataion in x265

2018-04-06 Thread Vittorio Giovara
just curious, what kind of general speed improvement does this give? I could have missed them in the series, but it would be nice to have some sort of benchmarks thanks Vittorio On Sat, Apr 7, 2018 at 4:29 AM, wrote: > This series of patches enables AVX-512 in x265. USe CLI option --asm > avx512

Re: [x265] [PATCH] SEI: fix build error

2018-03-23 Thread Vittorio Giovara
On Fri, Mar 23, 2018 at 6:23 AM, wrote: > # HG changeset patch > # User Ashok Kumar Mishra > # Date 1521800501 -19800 > # Fri Mar 23 15:51:41 2018 +0530 > # Node ID 0634c5a14899b2ed59ce133a35a0ff644887be85 > # Parent 5be53f09eee6ab28bd9dbb2c0ac447f50eb29655 > SEI: fix build error > > diff

Re: [x265] unsigned promotion prevents encoding frames with negative strides

2018-01-25 Thread Vittorio Giovara
olor space and images, but x265 doesn't it. > > Of course, crash is worst way to report invalid input parameters, we will > fix it soon. > > Thanks, > Min > > At 2018-01-18 00:24:19, "Vittorio Giovara" > wrote: > > Hi, > I'm developing an ap

Re: [x265] x265_encoder_reconfig and HDR metadata

2018-01-25 Thread Vittorio Giovara
On Thu, Jan 25, 2018 at 8:13 AM, Pradeep Ramachandran < prad...@multicorewareinc.com> wrote: > On Mon, Jan 22, 2018 at 7:12 AM, Vittorio Giovara < > vittorio.giov...@gmail.com> wrote: > >> >> >> On Wed, Jan 17, 2018 at 10:30 PM, Vittorio Giovara < >&

Re: [x265] x265_encoder_reconfig and HDR metadata

2018-01-22 Thread Vittorio Giovara
On Wed, Jan 17, 2018 at 10:30 PM, Vittorio Giovara < vittorio.giov...@gmail.com> wrote: > Hi, > is it possible to call x265_encoder_reconfig() after the encoder has been > opened? > > I tried doing so, setting masteringDisplayColorVolume and then > reconfiguring, but it

[x265] x265_encoder_reconfig and HDR metadata

2018-01-17 Thread Vittorio Giovara
Hi, is it possible to call x265_encoder_reconfig() after the encoder has been opened? I tried doing so, setting masteringDisplayColorVolume and then reconfiguring, but it does seem to be applied. The pipeline that I was expecting to be working is open decoder -> open encoder -> decode frame -> en

[x265] unsigned promotion prevents encoding frames with negative strides

2018-01-17 Thread Vittorio Giovara
Hi, I'm developing an app which flips a frame in this way frame->stride[0] *= -1; frame->stride[1] *= -1; frame->stride[2] *= -1; frame->data[0]= frame->data[1] + frame->stride[0]; frame->data[1]= frame->data[2] + frame->stride[1]; frame->data[2]= frame->data[2]

Re: [x265] [PATCH] cli: Accept new color primaries as per revised HEVC spec

2017-08-18 Thread Vittorio Giovara
Hello, with the standard expansions and several new options being added, I would like to propose a "de-facto" standard in option names to simplify integration and deploying of open source coding tools. Especially for well known options, such as color properties, there is little value in offering di