Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-11 Thread Deepthi Nandakumar
Sorry, in my zeal to push the Quant bug fix patch, I ended up pushing this test patch as well. The new (or rather X265_MALLOC) should be inside Frame::create(). On Tue, Aug 11, 2015 at 3:16 PM, wrote: > # HG changeset patch > # User Santhoshini Sekar > # Date 1438839704 -19800 > # Thu Aug

[x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-11 Thread santhoshini
# HG changeset patch # User Santhoshini Sekar # Date 1438839704 -19800 # Thu Aug 06 11:11:44 2015 +0530 # Node ID 8dcbdddb663d0d93ad32ac36c764146dcbd9e883 # Parent cbdefdfca87723342d21d90c41a93254553ed3d1 add API and implementation for Region of Interest(ROI) diff -r cbdefdfca877 -r 8dcbdddb

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-10 Thread Santhoshini Sekar
Ok, will modify the patch accordingly and send. On Tue, Aug 11, 2015 at 8:57 AM, Deepthi Nandakumar < deep...@multicorewareinc.com> wrote: > Thanks - this version is technically correct, can you send another patch > without the callback functions? > > On Fri, Aug 7, 2015 at 11:50 PM, Steve Borho

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-10 Thread Deepthi Nandakumar
Thanks - this version is technically correct, can you send another patch without the callback functions? On Fri, Aug 7, 2015 at 11:50 PM, Steve Borho wrote: > On 08/07, santhosh...@multicorewareinc.com wrote: > > # HG changeset patch > > # User Santhoshini Sekar > > # Date 1438839704 -19800 > >

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-07 Thread Steve Borho
On 08/07, santhosh...@multicorewareinc.com wrote: > # HG changeset patch > # User Santhoshini Sekar > # Date 1438839704 -19800 > # Thu Aug 06 11:11:44 2015 +0530 > # Node ID 450055cd2ef7e85ba8fff2d163161c0d0428b5fe > # Parent 9982ac741d1850d2b2451985feef5e0de0790794 > add API and implementati

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-07 Thread Steve Borho
On 08/07, Deepthi Nandakumar wrote: > Shall we copy quant offsets into inFrame within Encoder, so we dont need to > worry about the user-handled x265_picture instances? Of course, inFrame > will need to alloc/delete its own memory. > > x264 uses callback free function pointers for all its structur

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-06 Thread Deepthi Nandakumar
Shall we copy quant offsets into inFrame within Encoder, so we dont need to worry about the user-handled x265_picture instances? Of course, inFrame will need to alloc/delete its own memory. x264 uses callback free function pointers for all its structures (param, mb_info, quant_offsets) but we've n

[x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-06 Thread santhoshini
# HG changeset patch # User Santhoshini Sekar # Date 1438839704 -19800 # Thu Aug 06 11:11:44 2015 +0530 # Node ID 450055cd2ef7e85ba8fff2d163161c0d0428b5fe # Parent 9982ac741d1850d2b2451985feef5e0de0790794 add API and implementation for Region of Interest(ROI) diff -r 9982ac741d18 -r 450055cd

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-06 Thread Steve Borho
On 08/06, santhosh...@multicorewareinc.com wrote: > # HG changeset patch > # User Santhoshini Sekar > # Date 1438839704 -19800 > # Thu Aug 06 11:11:44 2015 +0530 > # Node ID fb00cab476a5d860e2fcddd51d764bdc3c8b96bc > # Parent 377a996a8d74110f838ff2e3cef1c42781d6d730 > add API and implementati

[x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-05 Thread santhoshini
# HG changeset patch # User Santhoshini Sekar # Date 1438839704 -19800 # Thu Aug 06 11:11:44 2015 +0530 # Node ID fb00cab476a5d860e2fcddd51d764bdc3c8b96bc # Parent 377a996a8d74110f838ff2e3cef1c42781d6d730 add API and implementation for Region of Interest(ROI) diff -r 377a996a8d74 -r fb00cab4

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-05 Thread Steve Borho
On 08/05, santhosh...@multicorewareinc.com wrote: > # HG changeset patch > # User Santhoshini Sekar > # Date 1438679012 -19800 > # Tue Aug 04 14:33:32 2015 +0530 > # Node ID 14abf498e49b0963fb1c0db19e39aa5de18560a5 > # Parent 3fa7f6838098854de79d3800b2d775dabaf45705 > add API and implementati

[x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-04 Thread santhoshini
# HG changeset patch # User Santhoshini Sekar # Date 1438679012 -19800 # Tue Aug 04 14:33:32 2015 +0530 # Node ID 14abf498e49b0963fb1c0db19e39aa5de18560a5 # Parent 3fa7f6838098854de79d3800b2d775dabaf45705 add API and implementation for Region of Interest(ROI) diff -r 3fa7f6838098 -r 14abf498

Re: [x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-04 Thread Steve Borho
On 08/04, santhosh...@multicorewareinc.com wrote: > # HG changeset patch > # User Santhoshini Sekar > # Date 1438679012 -19800 > # Tue Aug 04 14:33:32 2015 +0530 > # Node ID 1d61a8d12dc6bc446772817fcb90aab5b371b90e > # Parent d5278c76d341b3bac405938dbfb64cb7e2d9bce5 > add API and implementati

[x265] [PATCH] add API and implementation for Region of Interest(ROI)

2015-08-04 Thread santhoshini
# HG changeset patch # User Santhoshini Sekar # Date 1438679012 -19800 # Tue Aug 04 14:33:32 2015 +0530 # Node ID 1d61a8d12dc6bc446772817fcb90aab5b371b90e # Parent d5278c76d341b3bac405938dbfb64cb7e2d9bce5 add API and implementation for Region of Interest(ROI) diff -r d5278c76d341 -r 1d61a8d1