Re: [x265] [PATCH 01/12] AArch64: Fix costCoeffNxN test on Apple Silicon

2024-05-23 Thread Karam Singh
All the 12 patches of this series are pushed. Karam Singh Senior Software (Video Codec) Engineer MulticoreWare, India On Thu, May 9, 2024 at 7:31 PM Hari Limaye wrote: > Hi Santhoshini, > > Thank you for clarifying - I am attaching a patch file as requested. > > This patch file contains all

Re: [x265] [PATCH 01/12] AArch64: Fix costCoeffNxN test on Apple Silicon

2024-05-09 Thread Santhoshini Sekar
Hi Hari, Could you please share your 12 patches as a diff file attached to the email. This way we can apply the patches cleaner and push them. On Thu, May 9, 2024 at 2:27 PM Hari Limaye wrote: > Hi Karam, > > Thank you for reviewing this patch. Could you please clarify whether you > are

Re: [x265] [PATCH 01/12] AArch64: Fix costCoeffNxN test on Apple Silicon

2024-05-09 Thread Hari Limaye
Hi Karam, Thank you for reviewing this patch. Could you please clarify whether you are asking for the rest of this initial set of 12 patches, which are already on the mailing list, or for the optimisation patches that follow this initial set of changes? Thanks, Hari

Re: [x265] [PATCH 01/12] AArch64: Fix costCoeffNxN test on Apple Silicon

2024-05-09 Thread Karam Singh
Hello Hari, Thank you for fixing the AARCH64 build issues. Can you please attach all the patches? Thanks & Regards, Karam Singh Senior Software (Video Codec) Engineer MulticoreWare, India On Tue, May 7, 2024 at 8:53 AM chen wrote: > Hi Hari Limaye, > > > Thank you fix AARCH64 build

Re: [x265] [PATCH 01/12] AArch64: Fix costCoeffNxN test on Apple Silicon

2024-05-06 Thread chen
Hi Hari Limaye, Thank you fix AARCH64 build issues, these 12 patches looks good for me. Regards, Chen At 2024-05-03 05:19:36, "Hari Limaye" wrote: >The assembly routine x265_costCoeffNxN_neon is buggy and produces an >incorrect result on Apple Silicon, causing the pixel testbench to

Re: [x265] [PATCH 01/12] AArch64: Fix costCoeffNxN test on Apple Silicon

2024-05-03 Thread Pop, Sebastian
Ok. Thanks for the patch. Sebastian On 5/2/24, 4:23 PM, "x265-devel on behalf of Hari Limaye" mailto:x265-devel-boun...@videolan.org> on behalf of hari.lim...@arm.com > wrote: CAUTION: This email originated from outside of the organization. Do not click links or

[x265] [PATCH 01/12] AArch64: Fix costCoeffNxN test on Apple Silicon

2024-05-02 Thread Hari Limaye
The assembly routine x265_costCoeffNxN_neon is buggy and produces an incorrect result on Apple Silicon, causing the pixel testbench to fail on these platforms. x265_costCoeffNxN assumes that parameter `int subPosBase`, the second parameter of type `int` passed on the stack, is at position `sp +