Re: [x265] [PATCH 1 of 2] Add support for customizing logging

2018-03-19 Thread Derek Buitenhuis
On 3/18/2018 10:29 PM, Andrey Semashev wrote: > Normally, there is only one _application_. There may be multiple > _libraries_ using libx265 but none of them should be configuring its > logging, unless it is supposed to be the only one using libx265 in the > application (and generic libraries ca

Re: [x265] [PATCH 1 of 2] Add support for customizing logging

2018-03-19 Thread Ashok Kumar Mishra
On Mon, Mar 19, 2018 at 3:59 AM, Andrey Semashev wrote: > On 03/18/18 20:04, Derek Buitenhuis wrote: > >> On 3/16/2018 3:28 PM, Andrey Semashev wrote: >> >>> +/* x265_set_log: >>> + * Sets a custom logger function */ >>> +void x265_set_log(x265_log_t log); >>> >> >> I would like to voice my

Re: [x265] [PATCH 1 of 2] Add support for customizing logging

2018-03-18 Thread Andrey Semashev
On 03/18/18 20:04, Derek Buitenhuis wrote: On 3/16/2018 3:28 PM, Andrey Semashev wrote: +/* x265_set_log: + * Sets a custom logger function */ +void x265_set_log(x265_log_t log); I would like to voice my distaste for this implementation. This is a global callback, and will introduce pro

Re: [x265] [PATCH 1 of 2] Add support for customizing logging

2018-03-18 Thread Derek Buitenhuis
On 3/16/2018 3:28 PM, Andrey Semashev wrote: > +/* x265_set_log: > + * Sets a custom logger function */ > +void x265_set_log(x265_log_t log); I would like to voice my distaste for this implementation. This is a global callback, and will introduce problems with e.g. multiple libraries or dep

[x265] [PATCH 1 of 2] Add support for customizing logging

2018-03-16 Thread Andrey Semashev
# HG changeset patch # User Andrey Semashev # Date 1515596947 -10800 # Wed Jan 10 18:09:07 2018 +0300 # Branch add_custom_logging_v3 # Node ID 3ebefb64a1eb1487389db4ff7a808490b3005c39 # Parent d7c26df32fae052b7e895fee9bda1c22b24cc44b Add support for customizing logging This commit adds supp

[x265] [PATCH 1 of 2] Add support for customizing logging

2018-01-10 Thread Andrey Semashev
# HG changeset patch # User Andrey Semashev # Date 1515596947 -10800 # Wed Jan 10 18:09:07 2018 +0300 # Branch add_custom_logging # Node ID a5ad2f32cd45697897fdf6b643c69291861520c7 # Parent 2f3c4158cf3553030920708271bc43cdc79932a3 Add support for customizing logging This commit adds support