Re: [Xen-devel] [PATCH v2] sched: credit2: respect per-vcpu hard affinity

2015-03-13 Thread Justin Weaver
Dario, >> Without the processor assignment >> here the vcpu might go on being assigned to a processor it no longer >> is allowed to run on. >> > Ok. > >> In that case, function runq_candidate may only >> get called for the vcpu's old processor, and runq_candidate will no >> longer let a vcpu run o

Re: [Xen-devel] PML (Page Modification Logging) design for Xen

2015-03-13 Thread Kai Huang
On Thu, Mar 12, 2015 at 7:19 PM, Andrew Cooper wrote: > On 12/03/15 07:36, Kai Huang wrote: >> > It might also be nice to be able to enable or disable this feature > with a sysctl call; but that's just a nice-to-have. This feature should either be used or not. It is impractical to >>

[Xen-devel] [PATCH] libxc/xentrace: Replace xc_tbuf_set_cpu_mask with CPU mask with xc_cpumap_t instead of uint32_t

2015-03-13 Thread Konrad Rzeszutek Wilk
We replace the implementation of xc_tbuf_set_cpu_mask with an xc_cpumap_t instead of a uint32_t. This means we can use an arbitrary bitmap without being limited to the 32-bits as previously we were. Furthermore since there is only one user of xc_tbuf_set_cpu_mask we just replace it and its user in

Re: [Xen-devel] [PATCH RFC 02/14] libxc: xc_core_arch_memory_map_get populate errno

2015-03-13 Thread Konrad Rzeszutek Wilk
On Fri, Mar 13, 2015 at 08:20:32PM +, Andrew Cooper wrote: > On 13/03/15 19:31, Konrad Rzeszutek Wilk wrote: > > with proper value (ENOMEM) when reporting failures. > > > > Signed-off-by: Konrad Rzeszutek Wilk > > --- > > tools/libxc/xc_core_arm.c | 1 + > > tools/libxc/xc_core_x86.c | 1 + >

[Xen-devel] [PATCH v2 4/5] libxl: vcpuset: Remove useless limit on max_vcpus.

2015-03-13 Thread Konrad Rzeszutek Wilk
The check is superflous. If the 'max_vcpus' (argument value) is greater than pCPU and --ignore-host has not been supplied we would print an warning and return and not call this code. If the --ignore-host parameter had been used we would never end up in this condition and enforce 'max_vcpus'. The

[Xen-devel] [PATCH v2 2/5] libxl: vcpuset: Return error values.

2015-03-13 Thread Konrad Rzeszutek Wilk
The function does not return any values at all. Convert the internal libxl ones (ERROR_FAIL, ..., etc) to positive values and for the other cases just return standard libxl values. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxl/xl_cmdimpl.c | 23 +-- 1 file changed, 13

[Xen-devel] [PATCH v2 5/5] libxl: vcpu-set - allow to decrease vcpu count on overcommitted guests (v3)

2015-03-13 Thread Konrad Rzeszutek Wilk
We have a check to warn the user if they are overcommitting. But the check only checks the hosts CPU amount and does not take into account the case when the user is trying to fix the overcommit. That is - they want to limit the amount of online VCPUs. This fix allows the user to offline vCPUs with

[Xen-devel] [PATCH v2 1/5] libxl: Add ERROR_NOTFOUND for libxl_domain_info when it cannot find the domain

2015-03-13 Thread Konrad Rzeszutek Wilk
And use that for all of its callers in the tree. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxl/libxl.c | 18 +++--- tools/libxl/libxl.h | 4 +++- tools/libxl/libxl_types.idl | 1 + tools/libxl/xl_cmdimpl.c| 7 --- 4 files changed, 19 insertions(+), 1

[Xen-devel] [PATCH v2] Fix xl vcpu-set to decrease amount of vCPUS without warnining.

2015-03-13 Thread Konrad Rzeszutek Wilk
Hey, This patchset had been floating in the past. The aim for is to allow the user to do 'xl vcpu-set X' where the X can be bigger than the amount of physical CPUs the machine has. You can do this by launching an guest with huge amount of virtual CPUs without issues. >From >(http://lists.xenpro

[Xen-devel] [PATCH v2 3/5] libxl: vcpuset: Check max_vcpus argument against the maximum number of vCPUs the guest has set.

2015-03-13 Thread Konrad Rzeszutek Wilk
The maximum number of VCPUs the guest can have is determined during domain creation and is set by 'maxvcpus' parameter (in the guest config). Trying to set the amount of vCPUs above said value in vcpuset will result in an error - and we can catch it here (instead of later in the function) and print

Re: [Xen-devel] [PATCH RFC 02/14] libxc: xc_core_arch_memory_map_get populate errno

2015-03-13 Thread Andrew Cooper
On 13/03/15 19:31, Konrad Rzeszutek Wilk wrote: > with proper value (ENOMEM) when reporting failures. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > tools/libxc/xc_core_arm.c | 1 + > tools/libxc/xc_core_x86.c | 1 + > 2 files changed, 2 insertions(+) > > diff --git a/tools/libxc/xc_core_arm.c

Re: [Xen-devel] [PATCH 0/4] x86/MSI-X: XSA-120 follow-up

2015-03-13 Thread Andrew Cooper
On 10/03/15 16:16, Jan Beulich wrote: > The problem requiring the first patch here is actually what lead to > XSA-120. > > 1: be more careful during teardown > 2: access MSI-X table only after having enabled MSI-X > 3: reduce fiddling with control register during restore > 4: cleanup > > Signed-off

Re: [Xen-devel] [PATCH 4/4] x86/MSI-X: cleanup

2015-03-13 Thread Andrew Cooper
On 10/03/15 16:29, Jan Beulich wrote: > - __pci_enable_msix() now checks that an MSI-X capability was actually > found > - pass "pos" to msix_capability_init() as both callers already know it > (and hence there's no need to re-obtain it) > - call __pci_disable_msi{,x}() directly instead of via

Re: [Xen-devel] [PATCH RFC 03/14] libxc: Fix xc_domain_get_tsc_info returning -Exx instead of -1.

2015-03-13 Thread Konrad Rzeszutek Wilk
On Fri, Mar 13, 2015 at 03:31:12PM -0400, Konrad Rzeszutek Wilk wrote: > Instead put the -Exx in errno. > > Signed-off-by: Konrad Rzeszutek Wilk > --- > tools/libxc/xc_domain.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/tools/libxc/xc_domain.c b/tools/libxc/x

Re: [Xen-devel] [PATCH 3/4] x86/MSI-X: reduce fiddling with control register during restore

2015-03-13 Thread Andrew Cooper
On 10/03/15 16:29, Jan Beulich wrote: > Rather than disabling and enabling MSI-X once per vector, do it just > once per device. > > Signed-off-by: Jan Beulich Reviewed-by: Andrew Cooper ___ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.

[Xen-devel] [PATCH RFC v1 2/2] xen-hvm: When using xc_domain_add_to_physmap also include errno when reporting

2015-03-13 Thread Konrad Rzeszutek Wilk
.errors - as it will most likely have the proper error value. Signed-off-by: Konrad Rzeszutek Wilk --- xen-hvm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/xen-hvm.c b/xen-hvm.c index 7548794..3d6fed3 100644 --- a/xen-hvm.c +++ b/xen-hvm.c @@ -348,7 +348,7 @@ go_phys

[Xen-devel] [PATCH RFC v1 1/2] xen/hw/passthrough: Use errno instead of ret for xc_physdev_map_* calls

2015-03-13 Thread Konrad Rzeszutek Wilk
As the libxc library follows (mostly) the return negative for failure and stashes the error value in errno. Signed-off-by: Konrad Rzeszutek Wilk --- hw/xen/xen_pt.c | 4 ++-- hw/xen/xen_pt_msi.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/xen/xen_pt.c b/hw/xen

[Xen-devel] [RFC PATCH v1] Include errno values in printfs for some xc_ calls.

2015-03-13 Thread Konrad Rzeszutek Wilk
Hey, I've just posted on xen-devel patches that make these two set of xc_* function conform to the style of returning -1 for error and stashing the Exx in errno. See: http://lists.xen.org/archives/html/xen-devel/2015-03/msg01766.html and http://lists.xen.org/archives/html/xen-devel/2015-03/msg017

[Xen-devel] [PATCH RFC 10/14] libxl: If xc_domain_add_to_physmap fails, include errno value

2015-03-13 Thread Konrad Rzeszutek Wilk
Instead of just the return value. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_dom_x86.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/tools/libxc/xc_dom_x86.c b/tools/libxc/xc_dom_x86.c index bf06fe4..20e379c 100644 --- a/tools/libxc/xc_dom_x86.c +++ b/to

[Xen-devel] [PATCH RFC 14/14] libxl: Fix do_memory_op to return negative value on errors

2015-03-13 Thread Konrad Rzeszutek Wilk
instead of the -Exx values (which should go in errno). This patch has HUGE implications. There is a lot of APIs that are using do_memory_op. Fortunatly most of them check for 'if (do_memory_op(..) < 0)' so will function properly. However there were some which printed the return value to the user.

[Xen-devel] [PATCH RFC 07/14] libxl: Fix xc_tmem_control to return proper error.

2015-03-13 Thread Konrad Rzeszutek Wilk
The API returns now negative values on error and stashes the error in errno. Fix the user of this API. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_tmem.c | 16 tools/xenstat/libxenstat/src/xenstat.c | 5 +++-- 2 files changed, 15 insertions(+), 6 de

[Xen-devel] [PATCH RFC 13/14] libxl: Don't assign return value to errno for E820 get/set xc_ calls.

2015-03-13 Thread Konrad Rzeszutek Wilk
We should be using the errno that the hypercall left instead of overwritting it with the return value. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxl/libxl_x86.c | 9 +++-- 1 file changed, 3 insertions(+), 6 deletions(-) diff --git a/tools/libxl/libxl_x86.c b/tools/libxl/libxl_x86.c i

[Xen-devel] [PATCH RFC 08/14] libxl: Check xc_domain_maximum_gpfn for negative return values

2015-03-13 Thread Konrad Rzeszutek Wilk
Instead of assuming everything is always OK. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_core_arm.c| 14 +++--- tools/libxc/xc_core_x86.c| 21 + tools/libxc/xc_domain_save.c | 8 +++- 3 files changed, 35 insertions(+), 8 deletions(-) diff --g

[Xen-devel] [PATCH RFC 03/14] libxc: Fix xc_domain_get_tsc_info returning -Exx instead of -1.

2015-03-13 Thread Konrad Rzeszutek Wilk
Instead put the -Exx in errno. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_domain.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/libxc/xc_domain.c b/tools/libxc/xc_domain.c index 845d1d7..eb3a5f2 100644 --- a/tools/libxc/xc_domain.c +++ b/tools/libx

[Xen-devel] [PATCH RFC 11/14] libxl: Print xc_domain_decrease_reservation proper errno value.

2015-03-13 Thread Konrad Rzeszutek Wilk
Instead of just the return value. The other calls check for the negative value and don't print any of the data - so this patch just updates on call-site to include the proper error value. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_domain_restore.c | 2 +- 1 file changed, 1 insertion

[Xen-devel] [PATCH RFC 09/14] libxl: Check xc_maximum_ram_page for negative return values.

2015-03-13 Thread Konrad Rzeszutek Wilk
Instead of assuming everything is always OK. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xg_save_restore.h | 3 +++ tools/misc/xen-mfndump.c | 2 +- 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/libxc/xg_save_restore.h b/tools/libxc/xg_save_restore.h index bdd

[Xen-devel] [PATCH RFC 05/14] libxl: Return negative value and stash error in errno for xc_offline_page API

2015-03-13 Thread Konrad Rzeszutek Wilk
And also fix the user of it to print the proper error value. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_offline_page.c | 42 -- tools/libxc/xc_private.c | 3 ++- tools/misc/xen-hptool.c | 6 +++--- 3 files changed, 33 insertions(+

[Xen-devel] [PATCH RFC 01/14] libxc: Replaces tabs with spaces in xc_cpupool_freeinfo

2015-03-13 Thread Konrad Rzeszutek Wilk
The goto looks very wrong when the rest of the code has spaces. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_cpupool.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/libxc/xc_cpupool.c b/tools/libxc/xc_cpupool.c index 6393cfb..828f234 100644 --- a/tools/

[Xen-devel] [PATCH RFC 06/14] libxl: Fix xc_pm API calls to return negative error and stash error in errno.

2015-03-13 Thread Konrad Rzeszutek Wilk
Oddly enough the user of this API did the right thing - check for return being negative and used 'errno' for the real error. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_pm.c | 54 +++-- 1 file changed, 36 insertions(+), 18 deletions(-)

[Xen-devel] [PATCH RFC 12/14] libxl: Check xc_sharing_* for proper return values.

2015-03-13 Thread Konrad Rzeszutek Wilk
If there is a negative return value - check for that and also use errno for the proper error value. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxl/libxl.c | 4 ++-- tools/tests/mem-sharing/memshrtool.c | 12 ++-- 2 files changed, 12 insertions(+), 4 deletions(-)

[Xen-devel] [PATCH RFC 04/14] libxl: xc_physdev_map return -1 and populate errno.

2015-03-13 Thread Konrad Rzeszutek Wilk
The users of these (qemu) check for a negative value so we are safe in regards to that. However they also use the return value to inform the user of the error. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_physdev.c | 12 1 file changed, 8 insertions(+), 4 deletions(-) di

[Xen-devel] [PATCH RFC 02/14] libxc: xc_core_arch_memory_map_get populate errno

2015-03-13 Thread Konrad Rzeszutek Wilk
with proper value (ENOMEM) when reporting failures. Signed-off-by: Konrad Rzeszutek Wilk --- tools/libxc/xc_core_arm.c | 1 + tools/libxc/xc_core_x86.c | 1 + 2 files changed, 2 insertions(+) diff --git a/tools/libxc/xc_core_arm.c b/tools/libxc/xc_core_arm.c index 16508e7..888a3ac 100644 --- a/

[Xen-devel] [PATCH RFC v1] Fix up libxc errno and return mismatch.

2015-03-13 Thread Konrad Rzeszutek Wilk
Dear Maintainers of Libxl, This is all started with me using 'xc_domain_get_tsc_info' as template and the realizing that libxl should really return -1 for errors and we should stash the Exx value in errno. As I started fixing this up the job got bigger and bigger. There are still some in the migr

[Xen-devel] [ovmf test] 36343: trouble: blocked/broken/pass

2015-03-13 Thread xen . org
flight 36343 ovmf real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36343/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 3 host-install(3) broken REGR. vs. 36087 build-a

[Xen-devel] [qemu-upstream-4.4-testing test] 36356: trouble: blocked/broken

2015-03-13 Thread xen . org
flight 36356 qemu-upstream-4.4-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36356/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 3 host-install(3) broken REG

Re: [Xen-devel] [PATCH 2/4] x86/MSI-X: access MSI‑X table only after having enabled MSI‑X

2015-03-13 Thread Andrew Cooper
On 10/03/15 16:28, Jan Beulich wrote: > As done in Linux by f598282f51 ("PCI: Fix the NIU MSI-X problem in a > better way") and its broken predecessor, make sure we don't access the > MSI-X table without having enabled MSI-X first, using the mask-all flag > instead to prevent interrupts from occurr

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-13 Thread George Dunlap
On 03/13/2015 06:29 PM, Andrew Cooper wrote: >> +#define CREDIT2_OPT_RUNQUEUE_CORE 1 >> +#define CREDIT2_OPT_RUNQUEUE_SOCKET 2 > > You can drop _OPT out of the name. It serves only to make the constant > longer. I suggested _OPT so that nobody would be confused into thinking they were used in t

Re: [Xen-devel] [PATCH 1/2] x86: identifying the boot cpu

2015-03-13 Thread George Dunlap
On 03/13/2015 06:16 PM, Andrew Cooper wrote: > Please use git-send-email and thread your patch series properly. You > are still submitting 3 independent emails. > > On 13/03/15 18:07, Uma Sharma wrote: >> Provide helpers to access the socket and core IDs, resulting from >> identification phase. >

Re: [Xen-devel] Allow controlling NAPI weight of virtual network interfaces (vif) with sysfs

2015-03-13 Thread Ronald Pina
Hi Zoltan Yes , i successfully achieved good results using tc tools, it could do the job and the performance was great. But my primary goal is to make a study about the of performance impact of the weight parameter. It must be noted that Xen use NAPI, and on dom0 every vif is treated in the sam

[Xen-devel] [qemu-upstream-4.3-testing test] 36340: trouble: blocked/broken/pass

2015-03-13 Thread xen . org
flight 36340 qemu-upstream-4.3-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36340/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64-pvops 3 host-install(3) broken REG

Re: [Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-13 Thread Andrew Cooper
On 13/03/15 18:11, Uma Sharma wrote: > This patch do the following things: > -Insertion of runqueue_per_core code > -Boot paarmeter creation to select runqueue > -Update of xen-command-line.markdown > > Signed-off-by : Uma Sharma > --- > docs/misc/xen-command-line.markdown | 7 +++ > xen/c

[Xen-devel] [qemu-upstream-4.2-testing test] 36332: tolerable trouble: blocked/broken/pass - PUSHED

2015-03-13 Thread xen . org
flight 36332 qemu-upstream-4.2-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36332/ Failures :-/ but no regressions. Tests which did not succeed, but are not blocking: test-i386-i386-xl-qemuu-winxpsp3 1 build-check(1) blocked n/a build-i386-libvirt

Re: [Xen-devel] [PATCH 1/2] x86: identifying the boot cpu

2015-03-13 Thread Andrew Cooper
Please use git-send-email and thread your patch series properly. You are still submitting 3 independent emails. On 13/03/15 18:07, Uma Sharma wrote: > Provide helpers to access the socket and core IDs, resulting from > identification phase. > Initialize socket and core ID to -1 i.e invalid instea

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Konrad Rzeszutek Wilk
On Fri, Mar 13, 2015 at 06:05:15PM +, Andrew Cooper wrote: > On 13/03/15 18:02, Konrad Rzeszutek Wilk wrote: > >> * vsyscall in Linux (fair) > >> - Konrad Rzeszutek Wilk > > Not done. Still in 'git stash'. > > > >> * Convert tasklet to per-cpu tasklets (fair) > >>RFC posted > >> - K

[Xen-devel] [PATCH v2 2/2] sched_credit2.c: runqueue_per_core code

2015-03-13 Thread Uma Sharma
This patch do the following things: -Insertion of runqueue_per_core code -Boot paarmeter creation to select runqueue -Update of xen-command-line.markdown Signed-off-by : Uma Sharma --- docs/misc/xen-command-line.markdown | 7 +++ xen/common/sched_credit2.c | 31 +++

Re: [Xen-devel] [PATCH 1/4] x86/MSI-X: be more careful during teardown

2015-03-13 Thread Andrew Cooper
On 10/03/15 16:27, Jan Beulich wrote: > When a device gets detached from a guest, pciback will clear its > command register, thus disabling both memory and I/O decoding. The > disabled memory decoding, however, has an effect on the MSI-X table > accesses the hypervisor does: These won't have the in

[Xen-devel] [PATCH 1/2] x86: identifying the boot cpu

2015-03-13 Thread Uma Sharma
Provide helpers to access the socket and core IDs, resulting from identification phase. Initialize socket and core ID to -1 i.e invalid instead of 0. Having that field in all elements set to 0 would induce credit2 to think that the pCPU have already been initialized, and that all are on socket 0 in

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Andrew Cooper
On 13/03/15 18:02, Konrad Rzeszutek Wilk wrote: >> * vsyscall in Linux (fair) >> - Konrad Rzeszutek Wilk > Not done. Still in 'git stash'. > >> * Convert tasklet to per-cpu tasklets (fair) >>RFC posted >> - Konrad Rzeszutek Wilk > Pff.. I've the patches but would need to post them and >

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Konrad Rzeszutek Wilk
On Thu, Mar 12, 2015 at 11:54:15AM +, Jan Beulich wrote: > >>> On 12.03.15 at 11:21, wrote: > > == Linux == > > Wouldn't it make sense to move external projects down, and have > our core pieces (hypervisor, tool stack, maybe qemu) be near the > top? > > > * Convert tasklet to per-cpu taskle

[Xen-devel] [qemu-upstream-4.4-testing test] 36333: trouble: blocked/broken/pass

2015-03-13 Thread xen . org
flight 36333 qemu-upstream-4.4-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36333/ Failures and problems with tests :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 3 host-install(3) broken REG

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Konrad Rzeszutek Wilk
> * vsyscall in Linux (fair) > - Konrad Rzeszutek Wilk Not done. Still in 'git stash'. > * Convert tasklet to per-cpu tasklets (fair) >RFC posted > - Konrad Rzeszutek Wilk Pff.. I've the patches but would need to post them and redo them. Too busy right now. Might as well move them t

[Xen-devel] [PATCH v2 0/2] credit2 runqueue_per_core code

2015-03-13 Thread Uma Sharma
Hi everyone, This series of patch inserts runqueue_per_core code and creates a boot parameter to choose which type of runqueue mapping to perform i.e core or socket. Core is used by default as runqueue_per_core scheduler performs better than runqueue_per_socket. This series mainly performs the

Re: [Xen-devel] [PATCH 00/11] Alternate p2m: support multiple copies of host p2m

2015-03-13 Thread Ed White
>> >> Is there any chance you might reconsider your decision not to help >> with toolstack support of the patch series? I'm still trying to find >> an internal resource to do that work, but right now it's the biggest >> risk I see to getting the series into 4.6. > > My comment regarding hesitation

[Xen-devel] [GIT PULL] xen: bug fixes for 4.0-rc3

2015-03-13 Thread David Vrabel
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Linus, Please git pull the following tag: git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git stable/for-linus-4.0-rc3-tag xen: bug fixes for 4.0-rc3 - - Fix a PV regression in 3.19. - - Fix a dom0 crash on hosts with large numbers of PIRQs

[Xen-devel] [xen-4.2-testing test] 36328: regressions - FAIL

2015-03-13 Thread xen . org
flight 36328 xen-4.2-testing real [real] http://www.chiark.greenend.org.uk/~xensrcts/logs/36328/ Regressions :-( Tests which did not succeed and are blocking, including tests which could not be run: build-amd64 5 xen-build fail REGR. vs. 35988 build-i386

Re: [Xen-devel] Xen 4.6 Development Update (two months reminder)

2015-03-13 Thread Ed White
> == Hypervisor == > > * Alternate p2m: support multiple copies of host p2m (ok) > - Ed White > I'm hoping to see some progress on getting this restarted in the next 2 or 3 weeks, with additional Intel resources. Ed ___ Xen-devel mailing list X

Re: [Xen-devel] [PATCHv7 0/2] xen: improve migration performance

2015-03-13 Thread David Vrabel
On 11/03/15 14:49, David Vrabel wrote: > This series signficantly improves the performance of migration by > speeding up privcmd's MMAPBATCH_V2 ioctl (for PV toolstack domains). Applied to devel/for-linus-4.1. David ___ Xen-devel mailing list Xen-devel

Re: [Xen-devel] [PATCH v2] sched: credit2: respect per-vcpu hard affinity

2015-03-13 Thread Dario Faggioli
Hey, I came across this patch again for other reasons, and I realized I've a few more (minor) comments: On Sun, 2015-02-08 at 17:45 -1000, Justin T. Weaver wrote: > From: "Justin T. Weaver" > diff --git a/xen/common/sched_credit2.c b/xen/common/sched_credit2.c > index cf53770..de8fb5a 100644 > -

Re: [Xen-devel] Allow controlling NAPI weight of virtual network interfaces (vif) with sysfs

2015-03-13 Thread Zoltan Kiss
Hi, I reckon you want to do this for the same reason you started this thread a month ago: http://lists.xen.org/archives/html/xen-devel/2015-02/msg00228.html Have you considered the suggestions given there? (using the existing traffic shaping facilities of the kernel). As Wei said, you would

Re: [Xen-devel] [PATCH v3 20/24] xen/passthrough: Extend XEN_DOMCTL_assign_device to support DT device

2015-03-13 Thread Julien Grall
Hi, On 11/03/2015 13:50, Julien Grall wrote: On 11/03/2015 12:37, Ian Campbell wrote: On Tue, 2015-03-10 at 16:33 +, Julien Grall wrote: Hi Ian, On 20/02/15 17:17, Ian Campbell wrote: +/* TODO: Do we need to check is_dying? Mostly to protect against + * hypercall trying to passth

Re: [Xen-devel] [PATCH 5/6] xsm: add CAT related xsm policies

2015-03-13 Thread Daniel De Graaf
On 03/13/2015 06:13 AM, Chao Peng wrote: Add xsm policies for Cache Allocation Technology(CAT) related hypercalls to restrict the functions visibility to control domain only. Signed-off-by: Chao Peng Acked-by: Daniel De Graaf ___ Xen-devel mailin

Re: [Xen-devel] [PATCH v4 5/9] sysctl: Add sysctl interface for querying PCI topology

2015-03-13 Thread Boris Ostrovsky
On 03/13/2015 12:03 PM, Jan Beulich wrote: On 10.03.15 at 03:27, wrote: +case XEN_SYSCTL_pcitopoinfo: +{ +xen_sysctl_pcitopoinfo_t *ti = &op->u.pcitopoinfo; + +if ( guest_handle_is_null(ti->devs) || + guest_handle_is_null(ti->nodes) || + (ti->firs

Re: [Xen-devel] [PATCH] add upstream GRUB to the Xen build system

2015-03-13 Thread David Vrabel
On 13/03/15 16:02, Stefano Stabellini wrote: > On Fri, 13 Mar 2015, David Vrabel wrote: >> On 13/03/15 15:33, Stefano Stabellini wrote: >>> Clone and build upstream GRUB to generate x86_64 and i386 pvgrub2 >>> binaries. See Ian's blog post for more information: >> >> Why? If pvgrub2 is available o

Re: [Xen-devel] [PATCH v3 5/7] vTPM: Delete the xenstore directory of frontend device

2015-03-13 Thread Wei Liu
On Tue, Mar 10, 2015 at 08:14:00AM -0400, Quan Xu wrote: > when virtual machine is destroyed. > > Signed-off-by: Quan Xu > --- > tools/libxl/libxl_device.c | 61 > +++--- > 1 file changed, 57 insertions(+), 4 deletions(-) > > diff --git a/tools/libxl/lib

Re: [Xen-devel] [PATCH v3 4/7] vTPM: add vTPM device for HVM virtual machine

2015-03-13 Thread Wei Liu
On Tue, Mar 10, 2015 at 08:13:59AM -0400, Quan Xu wrote: > refactor libxl__device_vtpm_add to call the right helpers > libxl__device_vtpm_add_{pv,hvm}. For HVM virtual machine, > it does not support hot-plug and hot-unplug, as it requires > SeaBios to initalize ACPI and virtual MMIO space for TPM >

Re: [Xen-devel] [PATCH] add upstream GRUB to the Xen build system

2015-03-13 Thread Stefano Stabellini
On Fri, 13 Mar 2015, David Vrabel wrote: > On 13/03/15 15:33, Stefano Stabellini wrote: > > Clone and build upstream GRUB to generate x86_64 and i386 pvgrub2 > > binaries. See Ian's blog post for more information: > > Why? If pvgrub2 is available on the system libxl should make use of it, > but t

Re: [Xen-devel] [PATCH v4 2/9] pci: Stash device's PXM information in struct pci_dev

2015-03-13 Thread Jan Beulich
>>> On 10.03.15 at 03:27, wrote: > --- a/xen/include/xen/pci.h > +++ b/xen/include/xen/pci.h > @@ -57,6 +57,8 @@ struct pci_dev { > > u8 phantom_stride; > > +u8 node; /* NUMA node */ I was about to commit this when I noticed that you use u8 instead of nodeid_t (which you had introduc

Re: [Xen-devel] [PATCH v3 6/7] vTPM: Parse envent string from QEMU frontend

2015-03-13 Thread Wei Liu
On Tue, Mar 10, 2015 at 08:14:01AM -0400, Quan Xu wrote: > Signed-off-by: Quan Xu > --- > extras/mini-os/tpmback.c | 21 - > 1 file changed, 16 insertions(+), 5 deletions(-) > > diff --git a/extras/mini-os/tpmback.c b/extras/mini-os/tpmback.c > index 8a0a983..b8f4c8f 100644 >

[Xen-devel] [PATCH OSSTEST] README.dev: Document steps after restarting ms-ownerdaemon

2015-03-13 Thread Ian Campbell
Signed-off-by: Ian Campbell --- README.dev | 15 +++ 1 file changed, 15 insertions(+) diff --git a/README.dev b/README.dev index aae4f17..c53e065 100644 --- a/README.dev +++ b/README.dev @@ -164,3 +164,18 @@ $HOME/bisects/for-$branch.git/stop $HOME/testing.git/$xenbranch.stop s

Re: [Xen-devel] [PATCH v4 5/9] sysctl: Add sysctl interface for querying PCI topology

2015-03-13 Thread Jan Beulich
>>> On 10.03.15 at 03:27, wrote: > +case XEN_SYSCTL_pcitopoinfo: > +{ > +xen_sysctl_pcitopoinfo_t *ti = &op->u.pcitopoinfo; > + > +if ( guest_handle_is_null(ti->devs) || > + guest_handle_is_null(ti->nodes) || > + (ti->first_dev > ti->num_devs) ) > +

[Xen-devel] Xen Security Advisory 98 (CVE-2014-3969) - insufficient permissions checks accessing guest memory on ARM

2015-03-13 Thread Xen . org security team
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Xen Security Advisory CVE-2014-3969 / XSA-98 version 5 insufficient permissions checks accessing guest memory on ARM UPDATES IN VERSION 5 The issue described in update 4 also affe

Re: [Xen-devel] [PATCH] add upstream GRUB to the Xen build system

2015-03-13 Thread David Vrabel
On 13/03/15 15:33, Stefano Stabellini wrote: > Clone and build upstream GRUB to generate x86_64 and i386 pvgrub2 > binaries. See Ian's blog post for more information: Why? If pvgrub2 is available on the system libxl should make use of it, but there doesn't seem to be a good reason for cloning and

Re: [Xen-devel] [PATCH v2] xsm: add device tree labeling support

2015-03-13 Thread Julien Grall
Hi Daniel, On 12/03/2015 20:42, Daniel De Graaf wrote: This adds support in the hypervisor and policy build toolchain for Xen/Flask policy version 30, which adds the ability to label ARM device tree nodes and expands the IOMEM ocontext entries to 64 bits. Signed-off-by: Daniel De Graaf I add

Re: [Xen-devel] [PATCH v4 4/9] sysctl: Make XEN_SYSCTL_numainfo a little more efficient

2015-03-13 Thread Jan Beulich
>>> On 10.03.15 at 03:27, wrote: > @@ -522,7 +532,7 @@ struct xen_sysctl_numainfo { > * in the system is larger than the caller can handle, then a 2-d array > of > * the maximum size handleable by the caller is constructed. > */ > -XEN_GUEST_HANDLE_64(uint32) node_to_node_di

Re: [Xen-devel] [PATCH] add upstream GRUB to the Xen build system

2015-03-13 Thread Stefano Stabellini
On Fri, 13 Mar 2015, Stefano Stabellini wrote: > Clone and build upstream GRUB to generate x86_64 and i386 pvgrub2 > binaries. See Ian's blog post for more information: > > https://blog.xenproject.org/2015/01/07/using-grub-2-as-a-bootloader-for-xen-pv-guests/ > > Signed-off-by: Stefano Stabellini

Re: [Xen-devel] [PATCH v4 3/9] sysctl: Make XEN_SYSCTL_topologyinfo sysctl a little more efficient

2015-03-13 Thread Jan Beulich
>>> On 10.03.15 at 03:27, wrote: > +struct xen_sysctl_cputopo { > +uint32_t core; > +uint32_t socket; > +uint8_t node; > +}; Let's avoid me asking for explicit padding as well a future problems (it's sysctl and hence can be changed, but anyway) by making the node a uint32_t too (espec

Re: [Xen-devel] [PATCH v3 3/7] vTPM: add TPM TCPA and SSDT for HVM virtual machine when vTPM is added

2015-03-13 Thread Wei Liu
On Tue, Mar 10, 2015 at 08:13:58AM -0400, Quan Xu wrote: > Signed-off-by: Quan Xu > --- > tools/firmware/hvmloader/acpi/build.c | 7 --- > tools/libxl/libxl_create.c| 5 - > 2 files changed, 8 insertions(+), 4 deletions(-) > > diff --git a/tools/firmware/hvmloader/acpi/build.

Re: [Xen-devel] [PATCH v3 2/7] vTPM: limit libxl__add_vtpms() function to para virtual machine

2015-03-13 Thread Wei Liu
On Tue, Mar 10, 2015 at 08:13:57AM -0400, Quan Xu wrote: > Signed-off-by: Quan Xu > --- > tools/libxl/libxl_create.c | 11 +-- > 1 file changed, 9 insertions(+), 2 deletions(-) > > diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c > index b1ff5ae..66877b3 100644 > ---

Re: [Xen-devel] stubdom vtpm build failure in staging

2015-03-13 Thread Xu, Quan
> -Original Message- > From: Olaf Hering [mailto:o...@aepfle.de] > Sent: Friday, March 13, 2015 9:30 PM > To: Xu, Quan > Cc: xen-devel@lists.xen.org; Ian Campbell; Daniel De Graaf > Subject: Re: [Xen-devel] stubdom vtpm build failure in staging > > On Thu, Mar 12, Xu, Quan wrote: > > >

[Xen-devel] [PATCH] add upstream GRUB to the Xen build system

2015-03-13 Thread Stefano Stabellini
Clone and build upstream GRUB to generate x86_64 and i386 pvgrub2 binaries. See Ian's blog post for more information: https://blog.xenproject.org/2015/01/07/using-grub-2-as-a-bootloader-for-xen-pv-guests/ Signed-off-by: Stefano Stabellini --- Config.mk|3 ++ tools/Ma

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Wei Liu
On Fri, Mar 13, 2015 at 02:45:28PM +0100, Olaf Hering wrote: > On Thu, Mar 12, Ian Campbell wrote: > > > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote: > > > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I > > > assume its required to validate input in libxl_device_

Re: [Xen-devel] [PATCH v3 1/7] vTPM: event channel bind interdomain with para/hvm virtual machine

2015-03-13 Thread Xu, Quan
> -Original Message- > From: xen-devel-boun...@lists.xen.org > [mailto:xen-devel-boun...@lists.xen.org] On Behalf Of Wei Liu > Sent: Friday, March 13, 2015 10:03 PM > To: Xu, Quan > Cc: wei.l...@citrix.com; k...@xen.org; ian.campb...@citrix.com; > stefano.stabell...@eu.citrix.com; t...@xe

Re: [Xen-devel] [PATCH v2 5/7] xl: enable using ranges of pCPUs when creating cpupools

2015-03-13 Thread Wei Liu
On Fri, Mar 13, 2015 at 12:09:41PM +0100, Dario Faggioli wrote: > instead of just list of single pCPUs or NUMA node IDs, as > it happens right now. > > On the other hand, after this change, strings containing > pCPUs and NUMA node ranges is supported. The syntax is the > same one supported by the

Re: [Xen-devel] [PATCH v2 4/7] xl: enable using ranges of pCPUs when manipulating cpupools

2015-03-13 Thread Wei Liu
On Fri, Mar 13, 2015 at 12:09:32PM +0100, Dario Faggioli wrote: > in fact, right now, xl sub-commands 'cpupool-cpu-add' and > 'cpupool-cpu-remove' only accept the specification of one > pCPU to be added or removed to/from a cpupool. > > With this change, they can deal with ranges, like "4-8", > or

Re: [Xen-devel] [PATCH v2 3/7] libxl: introduce libxl_cpupool_cpu{add, remove}_cpumap()

2015-03-13 Thread Wei Liu
On Fri, Mar 13, 2015 at 12:09:24PM +0100, Dario Faggioli wrote: > To add (removes) to (from) a cpupool all the pCPUs corresponding > to the bits that are set in the passed bitmap. > > This is convenient and useful in order to implement, in xl, > the possibility of specifying ranges of pCPUs to be

Re: [Xen-devel] [PATCH v1 2/3] sched_credit2.c : runqueue_per_core code

2015-03-13 Thread George Dunlap
On 03/12/2015 02:57 PM, Uma Sharma wrote: > This patch do the following things: > -Insertion of runqueue_per_core code > -Boot paarmeter creation to select runqueue > > Signed-off-by : Uma Sharma > --- > xen/common/sched_credit2.c | 39 --- > 1 file changed, 3

Re: [Xen-devel] [PATCH v2] xsm: add device tree labeling support

2015-03-13 Thread Daniel De Graaf
On 03/13/2015 06:05 AM, Julien Grall wrote: Hi Jan, On 13/03/2015 09:23, Jan Beulich wrote: On 12.03.15 at 21:42, wrote: @@ -1999,11 +2055,23 @@ int policydb_read(struct policydb *p, void *fp) "Old xen policy does not support iomemcon"); goto ba

Re: [Xen-devel] [PATCH v6 04/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-03-13 Thread Bjorn Helgaas
On Fri, Mar 13, 2015 at 9:01 AM, Konrad Rzeszutek Wilk wrote: > On Fri, Mar 13, 2015 at 08:24:58AM -0500, Bjorn Helgaas wrote: >> On Thu, Mar 12, 2015 at 9:36 PM, Yijing Wang wrote: >> > + pci_add_resource(&resources, &ioport_resource); >> > + pci_add_resource(&resources, &iomem_resourc

Re: [Xen-devel] xen/x86: unable to build with gcc5

2015-03-13 Thread Ian Campbell
On Fri, 2015-03-13 at 13:32 +, M A Young wrote: > On Fri, 13 Mar 2015, Ian Campbell wrote: > > > On Fri, 2015-03-13 at 12:10 +, Jan Beulich wrote: > > [...] > > > For all of the above, at a first glance I'd say compiler bug. But to > > > be sure, could you send the three .o-s? > > See htt

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Ian Campbell
On Fri, 2015-03-13 at 14:44 +0100, Olaf Hering wrote: > On Thu, Mar 12, Ian Campbell wrote: > > > On Thu, 2015-03-12 at 17:20 +0100, Olaf Hering wrote: > > > On Wed, Mar 11, Ian Campbell wrote: > > > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > > +int libxl_device_vscsi_p

Re: [Xen-devel] [PATCH v2] x86/domctl: Improve XEN_DOMCTL_hypercall_init error handling

2015-03-13 Thread Wei Liu
On Thu, Mar 12, 2015 at 11:03:22AM +, Andrew Cooper wrote: > EACCES cannot be distinguished against an incorrect DOMCTL_INTERFACE_VERSION, > and will cause an incorrect "need to rebuild the user-space tool set?" message > from libxc. > > On the libxc side, put the useful piece of information i

Re: [Xen-devel] [PATCH v6 04/30] xen/PCI: Don't use deprecated function pci_scan_bus_parented()

2015-03-13 Thread Konrad Rzeszutek Wilk
On Fri, Mar 13, 2015 at 08:24:58AM -0500, Bjorn Helgaas wrote: > On Thu, Mar 12, 2015 at 9:36 PM, Yijing Wang wrote: > > + pci_add_resource(&resources, &ioport_resource); > > + pci_add_resource(&resources, &iomem_resource); > > + pci_add_resource(&resources, &busn_resource); >

Re: [Xen-devel] [PATCH v3 1/7] vTPM: event channel bind interdomain with para/hvm virtual machine

2015-03-13 Thread Wei Liu
On Tue, Mar 10, 2015 at 08:13:56AM -0400, Quan Xu wrote: > Signed-off-by: Quan Xu > --- > extras/mini-os/tpmback.c | 25 ++--- FYI mini-os now lives in a separate tree. http://xenbits.xen.org/gitweb/?p=mini-os.git;a=summary > 1 file changed, 14 insertions(+), 11 deletions(

Re: [Xen-devel] [PATCH 2/6] x86: add support for COS/CBM manangement

2015-03-13 Thread Konrad Rzeszutek Wilk
> +static bool_t psr_check_cbm(unsigned int cbm_len, uint64_t cbm) > +{ > +unsigned int first_bit, zero_bit; > + > +/* Set bits should only in the range of [0, cbm_len) */ Missing '.'. > +if ( cbm & (~0ull << cbm_len) ) > +return 0; > + > +/* At least two contiguous bits n

Re: [Xen-devel] Allow controlling NAPI weight of virtual network interfaces (vif) with sysfs

2015-03-13 Thread Wei Liu
On Fri, Mar 13, 2015 at 01:49:34PM +0100, Ronald Pina wrote: > My main idea was to adapt the the function of static int > change_weight(struct net_device *net, unsigned long new_weight) and > static ssize_t store_weight(struct device *dev, struct > device_attribute *attr, const char *buf, size_t le

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: > On Thu, 2015-03-12 at 17:07 +0100, Olaf Hering wrote: > > Related: I see libxl_device_vscsi_dispose does now a pointer check, so I > > assume its required to validate input in libxl_device_vscsi_get_host. > Not sure what you mean, you should call libxl_device_

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Wed, Mar 11, Ian Campbell wrote: > On Wed, 2015-03-11 at 17:02 +0100, Olaf Hering wrote: > > On Wed, Mar 11, Ian Campbell wrote: > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > +void libxl_device_vscsi_append_dev(libxl_ctx *ctx, libxl_device_vscsi > > > > *hst, > > > >

Re: [Xen-devel] [PATCH v3 4/4] libxl: add support for vscsi

2015-03-13 Thread Olaf Hering
On Thu, Mar 12, Ian Campbell wrote: > On Thu, 2015-03-12 at 17:20 +0100, Olaf Hering wrote: > > On Wed, Mar 11, Ian Campbell wrote: > > > > > On Fri, 2015-03-06 at 10:45 +0100, Olaf Hering wrote: > > > > +int libxl_device_vscsi_parse_pdev(libxl__gc *gc, char *pdev, unsigned > > > > int *hst, > >

Re: [Xen-devel] [PATCH 1/6] x86: detect and initialize Intel CAT feature

2015-03-13 Thread Konrad Rzeszutek Wilk
> > +cat_cpu_init(smp_processor_id()); > > Do 'if (!cat_cpu_init(..)).`' > > as the CPU might not support this. > > At which point you should also free the cat_socket_info and And also set cat_socket_info = NULL. > not register the cpu notifier. > > > +register_cpu_notifier(&cpu_nfb);

Re: [Xen-devel] [PATCH 1/6] x86: detect and initialize Intel CAT feature

2015-03-13 Thread Konrad Rzeszutek Wilk
On Fri, Mar 13, 2015 at 06:13:20PM +0800, Chao Peng wrote: > Detect Intel Cache Allocation Technology(CAT) feature and store the > cpuid information for later use. Currently only L3 cache allocation is > supported. The L3 CAT features may vary among sockets so per-socket > feature information is st

  1   2   >