>>> On 09.09.15 at 04:55, wrote:
> Otherwise we may hit assertion in vpmu_initialise() if vcpu is offlined
> and then onlined again.
>
> For tidyness, set priv_context to NULL as well.
>
> Signed-off-by: Boris Ostrovsky
Acked-by: Jan Beulich
___
X
>>> On 09.09.15 at 03:59, wrote:
> @@ -2310,12 +2312,16 @@ static int intel_iommu_assign_device(
> PCI_DEVFN2(bdf) == devfn &&
> rmrr->scope.devices_cnt > 1 )
> {
> -printk(XENLOG_G_ERR VTDPREFIX
> - " cannot assign %04x:%02x:%02x.
So can Xen change log level dynamically like Linux? If yes, we might
change this level temporarily while passing through IGD. If not, any
suggestion?
First of all you could boot without lowering the log level (non-debug
builds) or raising the log level ("loglvl=warning"; debug builds). But
Sor
We should lower loglevel to XENLOG_G_DEBUG while mapping or
unmapping memory via XEN_DOMCTL_memory_mapping since its
fair enough to check this info just while debugging.
CC: Ian Campbell
CC: Ian Jackson
CC: Jan Beulich
CC: Keir Fraser
CC: Tim Deegan
Signed-off-by: Tiejun Chen
---
xen/common
>>> On 08.09.15 at 18:02, wrote:
> I believe the driver does support use of multiple interrupts based on
> the previous explanation of the lspci output where it was established
> that the device could use up to 8 interrupts which is what I see on bare
> metal.
Where is the proof of that? All I've
This is the xl/xc changes to support Intel Code/Data Prioritization.
CAT xl commands to set/get CBMs are extended to support CDP.
Signed-off-by: He Chen
---
tools/libxc/include/xenctrl.h | 7 --
tools/libxc/xc_psr.c | 17 +-
tools/libxl/libxl.h | 10 +
CDP extends CAT and provides the capacity to control L3 code & data
cache. With CDP, one COS correspond to two CMBs(code & data). cbm_type
is added to support distinguish different CBM operation. Besides, new
domctl cmds are introdunced to support set/get CDP CBM. Some CAT
functions to operation CB
Intel Code/Data Prioritization(CDP) feature is based on CAT. cdp_enabled
is added to CAT socket info to indicate CDP is on or off on the socket,
note that cos_max would be half when CDP is on. struct psr_cat_cbm is
extended to support CDP operation. Extend psr_get_cat_l3_info sysctl to
get CDP stat
Changes in v2:
- x86: Enable CDP by boot parameter instead of enabling/disabling CDP at
runtime (suggested by Andrew)
- tools: remove psr-cat-cdp-enable/disable xl commands
- code style
Code/Data Prioritization(CDP) is offered in Intel Broadwell and later server
platforms, which is an extension of
Add CDP command in xl interface man page and add description of CDP
in xl-psr.markdown.
Signed-off-by: He Chen
---
docs/man/xl.pod.1 | 14 ++
docs/misc/xl-psr.markdown | 44 +++-
2 files changed, 53 insertions(+), 5 deletions(-)
diff -
flight 61591 linux-mingo-tip-master real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61591/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
build-i386-pvops 5 kernel-build fail REGR. vs. 60684
test-amd64
flight 61593 libvirt real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61593/
Failures :-/ but no regressions.
Tests which did not succeed, but are not blocking:
test-armhf-armhf-libvirt-qcow2 9 debian-di-installfail never pass
test-amd64-amd64-libvirt 12 migrate-sup
flight 61573 qemu-mainline real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61573/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
test-armhf-armhf-xl-rtds 11 guest-start fail REGR. vs. 60958
Tests which did not succeed,
Otherwise we may hit assertion in vpmu_initialise() if vcpu is offlined
and then onlined again.
For tidyness, set priv_context to NULL as well.
Signed-off-by: Boris Ostrovsky
---
xen/arch/x86/cpu/vpmu_amd.c | 2 ++
xen/arch/x86/cpu/vpmu_intel.c | 2 ++
2 files changed, 4 insertions(+)
diff -
flight 61526 linux-3.4 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61526/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-debianhvm-amd64 6 xen-boot fail REGR. vs. 30511
test-amd64-amd64-xl-qem
Currently we don't allow passing through any group devices which are
sharing same RMRR entry since it would break security among VMs. And
indeed, we expect we can figure out a better way to handle this kind
of case completely.
But before the group assignment gets implemented, we might make this
pe
flight 61524 linux-3.18 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61524/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-pvh-intel 11 guest-start fail REGR. vs. 58581
Regressions which are
On 09/08/15 19:26, Anthony PERARD wrote:
> On Fri, Aug 28, 2015 at 10:17:28AM +0200, Laszlo Ersek wrote:
>> On 08/08/15 02:02, Zeng, Star wrote:
-Original Message-
From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
Laszlo Ersek
Sent: Saturday, August
Hello everyone, I need to use vTPM to finish a project but I encounter the
same problem as
http://lists.xenproject.org/archives/html/xen-devel/2015-06/msg03930.html
I followed the steps explained in
https://mhsamsal.wordpress.com/2013/12/05/configuring-virtual-tpm-vtpm-for-xen-4-3-guest-virtual-ma
On 8 September 2015 at 18:21, Stefano Stabellini
wrote:
> The following changes since commit 8611280505119e296757a60711a881341603fa5a:
>
> target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200)
>
> are available in the git repository at:
>
> git://xenbits.xen.org/people/sstabelli
flight 61522 linux-3.14 real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61522/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-i386-xl-vhd 13 guest-saverestore fail REGR. vs. 60666
test-amd64-i386-xl-qco
On 08/09/15 16:15, Ian Campbell wrote:
On Tue, 2015-09-08 at 15:03 +, Antti Kantee wrote:
For unikernels, the rump kernel project provides Rumprun, which can
provide you with a near-full POSIX'y interface.
I'm not 100% clear: Does rumprun _build_ or _run_ the application? It sound
s like
flight 61523 ovmf real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61523/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemuu-ovmf-amd64 9 debian-hvm-install fail REGR. vs. 60869
test-amd64-i386-xl-qemuu-ovm
From: Konrad Rzeszutek Wilk
It has changed but the comments still refer to the old names.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
Signed-off-by: Stefano Stabellini
---
hw/xen/xen_pt.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/x
From: Konrad Rzeszutek Wilk
.errors - as it will most likely have the proper error value.
Signed-off-by: Konrad Rzeszutek Wilk
Acked-by: Stefano Stabellini
Signed-off-by: Stefano Stabellini
---
xen-hvm.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/xen-hvm.c b/x
From: Jan Beulich
The number of slots per page being 511 (i.e. not a power of two) means
that the (32-bit) read and write indexes going beyond 2^32 will likely
disturb operation. The hypervisor side gets I/O req server creation
extended so we can indicate that we're using suitable atomic accesses
From: Konrad Rzeszutek Wilk
We would like to know what the MSI register value is to help
in troubleshooting in the field. As such modify the logging
logic to include such details in xen_pt_msgctrl_reg_write.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
Signed-off-by: St
From: Konrad Rzeszutek Wilk
However the init routines assume that on errors the return
code is -1 (as the libxc API is) - while those xen_host_* routines follow
another paradigm - negative errno on return, 0 on success.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
Signe
From: Tiejun Chen
The OpRegion shouldn't be mapped 1:1 because the address in the host
can't be used in the guest directly.
This patch traps read and write access to the opregion of the Intel
GPU config space (offset 0xfc).
The original patch is from Jean Guyader
Signed-off-by: Tiejun Chen
S
From: Konrad Rzeszutek Wilk
If XEN_PT_LOGGING_ENABLED is enabled the XEN_PT_LOG macros start
using the first argument. Which means if within the function there
is only one user of the argument ('d') and XEN_PT_LOGGING_ENABLED
is not set, we get compiler warnings. This is not the case now
but with
From: Konrad Rzeszutek Wilk
As we do not use it outside our code.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
Signed-off-by: Stefano Stabellini
---
hw/xen/xen_pt.h |1 -
hw/xen/xen_pt_msi.c |2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --gi
From: Konrad Rzeszutek Wilk
In Xen 4.6 commit cd2f100f0f61b3f333d52d1737dd73f02daee592
"libxc: Fix do_memory_op to return negative value on errors"
made the libxc API less odd-ball: On errors, return value is
-1 and error code is in errno. On success the return value
is either 0 or an positive va
On Fri, Aug 28, 2015 at 10:17:28AM +0200, Laszlo Ersek wrote:
> On 08/08/15 02:02, Zeng, Star wrote:
> >> -Original Message-
> >> From: edk2-devel [mailto:edk2-devel-boun...@lists.01.org] On Behalf Of
> >> Laszlo Ersek
> >> Sent: Saturday, August 8, 2015 12:00 AM
> >> To: edk2-devel-01
> >>
Now that is fully Acked, could you please rebase on
http://marc.info/?i=alpine.DEB.2.02.1509081818590.2672%40kaball.uk.xensource.com
and resend?
Thanks!
- Stefano
On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote:
> Hey!
>
> Since v1: (http://lists.xen.org/archives/html/xen-devel/2015-07/msg0044
From: Tiejun Chen
Currently IGD drivers always need to access PCH by 1f.0. But we
don't want to poke that directly to get ID, and although in real
world different GPU should have different PCH. But actually the
different PCH DIDs likely map to different PCH SKUs. We do the
same thing for the GPU.
From: Don Slutz
Signed-off-by: Stefano Stabellini
Signed-off-by: Don Slutz
---
trace-events |7 +++
xen-hvm.c| 21 +
2 files changed, 28 insertions(+)
diff --git a/trace-events b/trace-events
index 0a82f0c..985b041 100644
--- a/trace-events
+++ b/trace-events
From: Tiejun Chen
Currently we just register this isa bridge when we use IGD
passthrough in Xen side.
Signed-off-by: Tiejun Chen
Acked-by: Stefano Stabellini
Signed-off-by: Stefano Stabellini
---
hw/xen/xen_pt.c | 22 ++
1 file changed, 22 insertions(+)
diff --git a/hw
The following changes since commit 8611280505119e296757a60711a881341603fa5a:
target-microblaze: Use setcond for pcmp* (2015-09-08 08:49:33 +0200)
are available in the git repository at:
git://xenbits.xen.org/people/sstabellini/qemu-dm.git tags/xen-2015-09-08-tag
for you to fetch changes up
From: Tiejun Chen
Pass types to configure pc_init1().
Signed-off-by: Tiejun Chen
Signed-off-by: Stefano Stabellini
Acked-by: Michael S. Tsirkin
---
hw/i386/pc_piix.c | 14 --
1 file changed, 8 insertions(+), 6 deletions(-)
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
ind
From: Tiejun Chen
basic gfx passthrough support:
- add a vga type for gfx passthrough
- register/unregister legacy VGA I/O ports and MMIOs for passthrough GFX
Signed-off-by: Tiejun Chen
Signed-off-by: Yang Zhang
Acked-by: Stefano Stabellini
Signed-off-by: Stefano Stabellini
---
hw/core/mach
From: Tiejun Chen
Now we retrieve VGA bios like kvm stuff in qemu but we need to
fix Device Identification in case if its not matched with the
real IGD device since Seabios is always trying to compare this
ID to work out VGA BIOS.
Signed-off-by: Tiejun Chen
Acked-by: Stefano Stabellini
Signed-
From: Tiejun Chen
Implement a pci host bridge specific to passthrough. Actually
this just inherits the standard one. And we also just expose
a minimal real host bridge pci configuration subset.
Signed-off-by: Tiejun Chen
Signed-off-by: Stefano Stabellini
Acked-by: Michael S. Tsirkin
---
hw/p
From: Tiejun Chen
We will try to reuse assign_dev_load_option_rom in xen side, and
especially its a good beginning to unify pci assign codes both on
kvm and xen in the future.
Signed-off-by: Tiejun Chen
Signed-off-by: Stefano Stabellini
Acked-by: Michael S. Tsirkin
---
hw/i386/Makefile.objs
From: Tiejun Chen
Just register that pci host bridge specific to passthrough.
Signed-off-by: Tiejun Chen
Acked-by: Stefano Stabellini
Signed-off-by: Stefano Stabellini
---
hw/i386/pc_piix.c | 15 +--
1 file changed, 13 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc_piix
From: "Michael S. Tsirkin"
IGD passthrough wants to supply a different pci and
host devices, inheriting i440fx devices. Make types
configurable.
Signed-off-by: Michael S. Tsirkin
Signed-off-by: Tiejun Chen
Signed-off-by: Stefano Stabellini
---
hw/i386/pc_piix.c|4 +++-
hw/pci-host/pi
On 08/09/15 16:17, Juergen Gross wrote:
>
> I'd suggest an update of arch/x86/include/asm/xen/interface.h regarding
> a possible change of max_pfn. Something like:
>
> ...
>* p2m_vaddr holds the virtual address of the linear p2m list. All
>* entries in the range [0...max_pfn[ are accessib
Ian Campbell, le Tue 08 Sep 2015 17:37:21 +0100, a écrit :
> On Tue, 2015-09-08 at 18:26 +0200, Samuel Thibault wrote:
> > Ian Campbell, le Tue 08 Sep 2015 17:15:40 +0100, a écrit :
> > > Is it at all possible (even theoretically) to take a shared library
> > > (which
> > > is relocatable as requir
On 09/08/2015 03:17 PM, Ian Campbell wrote:
> On Mon, 2015-08-10 at 18:35 +0800, Chunyan Liu wrote:
>
> Sorry for the delay, between 4.6 freeze crunch, conference and vacation
> I've been a bit swamped.
>
> I'm just going to comment on the APIs (mainly public libxl.h and .idl) in
> this pass.
>
flight 61525 seabios real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61525/
Failures :-/ but no regressions.
Regressions which are regarded as allowable (not blocking):
test-amd64-amd64-xl-qemuu-win7-amd64 17 guest-stop fail like 61266
Tests which did not succeed, but a
On Tue, 2015-09-08 at 18:26 +0200, Samuel Thibault wrote:
> Ian Campbell, le Tue 08 Sep 2015 17:15:40 +0100, a écrit :
> > Is it at all possible (even theoretically) to take a shared library
> > (which
> > is relocatable as required) and to do a compile time static linking
> > pass on
> > it? i.e.
Ian Campbell, le Tue 08 Sep 2015 17:15:40 +0100, a écrit :
> Is it at all possible (even theoretically) to take a shared library (which
> is relocatable as required) and to do a compile time static linking pass on
> it? i.e. use libfoo.so but still do static linking?
€ gcc test.c -o libtest.so -sh
On Tue, 2015-09-08 at 15:03 +, Antti Kantee wrote:
> For unikernels, the rump kernel project provides Rumprun, which can
> provide you with a near-full POSIX'y interface.
I'm not 100% clear: Does rumprun _build_ or _run_ the application? It sound
s like it builds but the name suggests otherw
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 61521: regressions -
FAIL"):
> That's what I was about to say in a reply to your earlier mail. To me
> this still means the guest booted up successfully (or else it wouldn't
> have accepted the TCP connection). I agree its "ssh server" servi
>>> On 08.09.15 at 17:45, wrote:
> Ian Jackson writes ("Re: [Xen-devel] [xen-unstable test] 61521: regressions -
> FAIL"):
>> A more likely explanation is that the host sometimes fails to complete
>> its bootup within a reasonable time.
>
> Actually, looking at a bit more of the osstest transcri
-BEGIN PGP SIGNED MESSAGE-
Hash: SHA1
Linus,
Please git pull the following tag:
git://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git for-linus-4.3-rc0-tag
xen: features and fixes for 4.3-rc0
- - Convert xen-blkfront to the multiqueue API
- - [arm] Support binding event channels t
Ian Jackson writes ("Re: [Xen-devel] [xen-unstable test] 61521: regressions -
FAIL"):
> A more likely explanation is that the host sometimes fails to complete
> its bootup within a reasonable time.
Actually, looking at a bit more of the osstest transcript:
2015-09-08 09:14:32 Z guest debianhvm.g
Jan Beulich writes ("Re: [Xen-devel] [xen-unstable test] 61521: regressions -
FAIL"):
> This or some random (but reoccurring) failure.
I agree with Ian C that this isn't likely to be an infrastructure
problem. It's probably an actual bug.
> Not so long ago I already mentioned that for the purpo
On Tue, Sep 08, 2015 at 04:13:06PM +0100, Ian Campbell wrote:
> On Tue, 2015-09-08 at 15:52 +0100, Wei Liu wrote:
> > On Tue, Sep 08, 2015 at 02:30:30PM +, osstest service owner wrote:
> > > flight 61521 xen-unstable real [real]
> > > http://logs.test-lab.xenproject.org/osstest/logs/61521/
> >
On Tue, Sep 08, 2015 at 03:39:53PM +0100, Ian Jackson wrote:
> Wei Liu writes ("[PATCH for 4.6 2/2] xl/libxl: disallow restoring guest with
> vNUMA configured"):
> > This is due to restoring a guest uses another path different from the
> > creation path and migration v2 frame record doesn't contai
On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote:
> We do not want to have two entries to cache the guest configuration
> registers: XenPTReg->data and dev.config. Instead we want to use
> only the dev.config.
>
> To do without much complications we rip out the ->data field
> and replace it with an
On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote:
> It should never happen, but in case it does (an developer adds
> a new register and the 'init_val' expands past the register
> size) we want to report. The code will only write up to
> reg->size so there is no runtime danger of the register spillin
Applied
On Tue, 8 Sep 2015, Konrad Rzeszutek Wilk wrote:
> Hey!
>
> Since v2 (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00431.html)
> - Added Reviewed-by.
>
> since RFC
> [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07326.html]
> - Added Acks
> - Followed 'xen: Pri
On Tue, 2015-09-08 at 09:49 -0500, Doug Goldstein wrote:
> > Midlevel library stability
> > ==
> >
> > libxenlight is only API not ABI stable. This is a pain in particular
> > for libvirt which needs binNMU for new Xen package.
> >
> > We would like to eventually offer ABI
Ian Campbell writes ("Re: [PATCH] MAINTAINERS: stable backports should be
requested on xen-devel"):
> AIUI the branching process involves tweaking this text to refer to the
> specific maintainers of the given stable branch.
Yes. Sometimes older stable branches have different maintainers.
> IOW
On Tue, Sep 08, 2015 at 02:30:30PM +, osstest service owner wrote:
> flight 61521 xen-unstable real [real]
> http://logs.test-lab.xenproject.org/osstest/logs/61521/
>
> Regressions :-(
>
> Tests which did not succeed and are blocking,
> including tests which could not be run:
> test-amd64-am
On Tue, 2015-09-08 at 15:38 +0100, Ian Jackson wrote:
> Ian Campbell writes ("Re: [PATCH] MAINTAINERS: stable backports should be
> requested on xen-devel"):
> > AIUI the branching process involves tweaking this text to refer to the
> > specific maintainers of the given stable branch.
>
> Yes. So
Hi,
Wei Liu hinted that I should "chime in and / or provide corrections"
(his words). I'll attempt to do exactly that by not really replying to
anything specific. For the record, when I say "we" in this mail, I mean
"people who have contributed to the rump kernel project" (as also
indicated
On 09/08/2015 03:36 PM, David Vrabel wrote:
With commit 633d6f17cd91ad5bf2370265946f716e42d388c6 (x86/xen: prepare
p2m list for memory hotplug) the P2M may be sized to accomdate a much
s/accomdate/accommodate/
larger amount of memory than the domain currently has.
When saving a domain, the t
On Tue, 2015-09-08 at 15:52 +0100, Wei Liu wrote:
> On Tue, Sep 08, 2015 at 02:30:30PM +, osstest service owner wrote:
> > flight 61521 xen-unstable real [real]
> > http://logs.test-lab.xenproject.org/osstest/logs/61521/
> >
> > Regressions :-(
> >
> > Tests which did not succeed and are bloc
>>> On 08.09.15 at 16:52, wrote:
> On Tue, Sep 08, 2015 at 02:30:30PM +, osstest service owner wrote:
>> flight 61521 xen-unstable real [real]
>> http://logs.test-lab.xenproject.org/osstest/logs/61521/
>>
>> Regressions :-(
>>
>> Tests which did not succeed and are blocking,
>> including te
On 9/8/15 5:55 AM, Jan Beulich wrote:
On 08.09.15 at 12:49, wrote:
>> Jan Beulich writes ("Re: [Xen-devel] Notes from Xen BoF at Debconf15"):
>>> Right - 4.4.3 already was released with just one RC, and indeed I
>>> meant to stay with that model considering the little (if any) feedback
>>> we
On 9/8/15 4:24 AM, Ian Campbell wrote:
> Xen upstream BoF
>
>
> We had a discussion around Xen and packaging at Debian's annual developer
> conference (Debconf) a few weeks back:
> https://summit.debconf.org/debconf15/meeting/279/xen-upstream-bof/
While I'm not a Debian guy and w
Wei Liu writes ("[PATCH for 4.6 2/2] xl/libxl: disallow restoring guest with
vNUMA configured"):
> This is due to restoring a guest uses another path different from the
> creation path and migration v2 frame record doesn't contain node
> information.
The effect of this would be that you could do
Ian Campbell writes ("Re: [PATCH OSSTEST v2 4/6] ts-openstack-devstack: Deploy
OpenStack on a host"):
> On Thu, 2015-08-06 at 18:03 +0100, Anthony PERARD wrote:
> > This script also install packages needed and clone every OpenStack trees to
> > be use by devstack to deploy OpenStack.
>
> How abou
flight 61521 xen-unstable real [real]
http://logs.test-lab.xenproject.org/osstest/logs/61521/
Regressions :-(
Tests which did not succeed and are blocking,
including tests which could not be run:
test-amd64-amd64-xl-qemut-debianhvm-amd64 19 guest-start/debianhvm.repeat fail
REGR. vs. 61059
Reg
On Mon, 2015-08-10 at 18:35 +0800, Chunyan Liu wrote:
Sorry for the delay, between 4.6 freeze crunch, conference and vacation
I've been a bit swamped.
I'm just going to comment on the APIs (mainly public libxl.h and .idl) in
this pass.
> diff --git a/tools/libxl/libxl.h b/tools/libxl/libxl.h
> i
Instead we have the emulation registers ->init functions which
consult the host values to see what the initial value should be
and they are responsible for populating the dev.config.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt.c | 7 +--
1 file cha
and if we have failures we call xen_pt_destroy introduced in
'xen/pt: Move bulk of xen_pt_unregister_device in its own routine.'
and free all of the allocated structures.
Acked-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt.c | 24
1 file
For a passthrough device we maintain a state of emulated
registers value contained within d->config. We also consult
the host registers (and apply ro and write masks) whenever
the guest access the registers. This is done in xen_pt_pci_write_config
and xen_pt_pci_read_config.
Also in this picture w
Hey!
Since v1: (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00442.html)
- Acked on review.
RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07350.html]
- Added Acks
- Fixed bugs
This patchset is dependent on the "Cleanups + various fixes due to libxl ABI
more logging o
To deal with xen_host_pci_[set|get]_ functions returning error values
and clearing ourselves in the init function we should make the
.exit (xen_pt_unregister_device) function be idempotent in case
the generic code starts calling .exit (or for fun does it before
calling .init!).
Reviewed-by: Stefan
We seem to only use these functions when de-activating the
MSI - so just log errors.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt_msi.c | 18 ++
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/hw/xen/xen_pt_msi.c b/hw/xen/
We do not want to have two entries to cache the guest configuration
registers: XenPTReg->data and dev.config. Instead we want to use
only the dev.config.
To do without much complications we rip out the ->data field
and replace it with an pointer to the dev.config. This way we
have the type-checkin
To help with troubleshooting in the field.
Acked-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt_config_init.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/hw/xen/xen_pt_config_init.c b/hw/xen/xen_pt_config_init.c
index 727f814..67ecc71 100644
--- a
During init time we treat the dev.config area as a cache
of the host view. However during execution time we treat it
as guest view (by the generic PCI API). We need to sync Xen's
code to the generic PCI API view. This is the first step
by replacing all of the code that uses dev.config or
pci_get_[b
It should never happen, but in case it does (an developer adds
a new register and the 'init_val' expands past the register
size) we want to report. The code will only write up to
reg->size so there is no runtime danger of the register spilling
across other ones - however to catch this sort of thing
This way we can call it if we fail during init.
This code movement introduces no changes.
Acked-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt.c | 115 +---
1 file changed, 60 insertions(+), 55 deletions(-)
dif
However the init routines assume that on errors the return
code is -1 (as the libxc API is) - while those xen_host_* routines follow
another paradigm - negative errno on return, 0 on success.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt.c | 2 +-
1 file
We would like to know what the MSI register value is to help
in troubleshooting in the field. As such modify the logging
logic to include such details in xen_pt_msgctrl_reg_write.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt_config_init.c | 6 +++---
1
Discovered some fallouts when I tried to fix a migration v2 bug.
Wei Liu (2):
libxl: set ret to non-zero value in failure path
xl/libxl: disallow restoring guest with vNUMA configured
docs/man/xl.cfg.pod.5 | 2 ++
tools/libxl/libxl_create.c | 11 +++
2 files changed, 13 inserti
This is due to restoring a guest uses another path different from the
creation path and migration v2 frame record doesn't contain node
information.
Signed-off-by: Wei Liu
---
Cc: andrew.coop...@citrix.com
I don't think this is specific to migration v2. Legacy migration suffers
from the same issu
... otherwise we have something like:
xl: libxl_create.c:968: initiate_domain_create: Assertion `ret' failed.
Signed-off-by: Wei Liu
---
tools/libxl/libxl_create.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/libxl/libxl_create.c b/tools/libxl/libxl_create.c
index 5128160..29c2641
It has changed but the comments still refer to the old names.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index ed5fcae..706e3d9 100644
--- a/hw
In Xen 4.6 commit cd2f100f0f61b3f333d52d1737dd73f02daee592
"libxc: Fix do_memory_op to return negative value on errors"
made the libxc API less odd-ball: On errors, return value is
-1 and error code is in errno. On success the return value
is either 0 or an positive value.
Since we could be runnin
As we do not use it outside our code.
Reviewed-by: Stefano Stabellini
Signed-off-by: Konrad Rzeszutek Wilk
---
hw/xen/xen_pt.h | 1 -
hw/xen/xen_pt_msi.c | 2 +-
2 files changed, 1 insertion(+), 2 deletions(-)
diff --git a/hw/xen/xen_pt.h b/hw/xen/xen_pt.h
index 393f36c..09358b1 100644
---
If XEN_PT_LOGGING_ENABLED is enabled the XEN_PT_LOG macros start
using the first argument. Which means if within the function there
is only one user of the argument ('d') and XEN_PT_LOGGING_ENABLED
is not set, we get compiler warnings. This is not the case now
but with the "xen/pt: Use xen_host_pci
Hey!
Since v2 (http://lists.xen.org/archives/html/xen-devel/2015-07/msg00431.html)
- Added Reviewed-by.
since RFC [https://lists.gnu.org/archive/html/qemu-devel/2015-06/msg07326.html]
- Added Acks
- Followed 'xen: Print and use errno where applicable.' suggestion by Stefano
and added a wrap
On Tue, 2015-09-08 at 14:20 +0100, Wei Liu wrote:
> On Tue, Sep 08, 2015 at 12:37:04PM +0100, Ian Campbell wrote:
> > On Sat, 2015-07-25 at 09:25 +0100, Ian Campbell wrote:
> > > As well as CC-ing the correct people. I just saw such a request on
> > > xen-users and thought this was worth clarifying
>>> On 08.09.15 at 15:35, wrote:
> On Mon, 2015-09-07 at 15:25 +0100, Stefano Stabellini wrote:
>> +static __init int kernel_decompress(struct kernel_info *info,
>> + paddr_t *addr, paddr_t *size)
>> +{
>> +char *output, *input, *end;
>> +char magic[2];
>> +
With commit 633d6f17cd91ad5bf2370265946f716e42d388c6 (x86/xen: prepare
p2m list for memory hotplug) the P2M may be sized to accomdate a much
larger amount of memory than the domain currently has.
When saving a domain, the toolstack must scan all the P2M looking for
populated pages. This results i
1 - 100 of 175 matches
Mail list logo
